From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 684322D3738 for ; Fri, 14 Nov 2025 06:57:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.254.224.24 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763103445; cv=none; b=TKQKHDxZlTGTsA4FWVZCUTzc4qWr6gDSeWyDYyheDmi5lOVQlTkRK2+lPmmOl0amzxmMVib9FTI2YBiOGRDQSnZiHR954TO4VdsC35Q2t8Eme2ilp1QnxkdC+88/khjiEGY8Ttvxy3xQKL81sSIOhOUgWOVqZh+5BO2y0MNMeEU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763103445; c=relaxed/simple; bh=TQIRRbL9dM/f1VkPgu9INKyF1KLf6LH1oqkvwVc3PzU=; h=From:To:Cc:In-Reply-To:Subject:Date:Message-ID:MIME-Version: Content-Type:References; b=ky8w2zyH3cuplj0iEv3OapZL0YlYkUmTtt9BTmU18F21UEaDmeb5exOBi0ddTZrgunCcZjCdPMZgbrGqk/hcWi211S3x96e1sAgz2qJ+FN9nO4IKaq6TCEVZPj0G2Fau7BkHNpX7FkhtZSrISJqWYBAQihB6r2i0O6/+TOzXO0s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=AF9eq+cO; arc=none smtp.client-ip=203.254.224.24 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="AF9eq+cO" Received: from epcas2p3.samsung.com (unknown [182.195.41.55]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20251114065720epoutp019b10d2e080c7d1a7cc827c404838cd73~3zTzaCBrK2089620896epoutp01f for ; Fri, 14 Nov 2025 06:57:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20251114065720epoutp019b10d2e080c7d1a7cc827c404838cd73~3zTzaCBrK2089620896epoutp01f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1763103440; bh=1vkMpsltnFXkF+G2EStX6zbbbjFa3ZqX3K9ihfvO02o=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=AF9eq+cOCo27nmRd0D85k64UWmd+h8PC9krLewVBf8bPetYybViAT+7VXgYXlBUPm D8x+8PS1FCXZnGrTxgWQwl6yqAbO9GQ7ihBF/22K7G3ho8FtJ88fSiCfVxSazWviFP ZtrPDMUbSxBwgZyBDwWkpNH/oycM8oXaZ6B/h0y4= Received: from epsnrtp03.localdomain (unknown [182.195.42.155]) by epcas2p1.samsung.com (KnoxPortal) with ESMTPS id 20251114065719epcas2p1e8849a097d46ed03d4a15f820d6e3459~3zTy8NAmg1323413234epcas2p1B; Fri, 14 Nov 2025 06:57:19 +0000 (GMT) Received: from epcas2p1.samsung.com (unknown [182.195.38.211]) by epsnrtp03.localdomain (Postfix) with ESMTP id 4d77HM3gHXz3hhTD; Fri, 14 Nov 2025 06:57:19 +0000 (GMT) Received: from epsmtip1.samsung.com (unknown [182.195.34.30]) by epcas2p1.samsung.com (KnoxPortal) with ESMTPA id 20251114065718epcas2p1f36aa81a248e01e9c78a9064c268b72f~3zTyB67lU1559915599epcas2p1K; Fri, 14 Nov 2025 06:57:18 +0000 (GMT) Received: from KORCO118486 (unknown [12.80.208.104]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20251114065718epsmtip16f5e401c43bd4752ad76b10649c268b8~3zTx7Nt-s0134501345epsmtip1i; Fri, 14 Nov 2025 06:57:18 +0000 (GMT) From: "SanghoonBae" To: "'Krzysztof Kozlowski'" , , , , , , , , Cc: , , , , , In-Reply-To: Subject: RE: [PATCH 3/4] arm64: dts: ExynosAutov920: add PCIe PHY DT nodes Date: Fri, 14 Nov 2025 15:57:18 +0900 Message-ID: <001601dc5533$eb0049f0$c100ddd0$@samsung.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQISOccZb2Ez4IvEWuwZme1oXG7+3gLz1TbfAjvUL4UCZHEM87RJTwlQ Content-Language: ko X-CMS-MailID: 20251114065718epcas2p1f36aa81a248e01e9c78a9064c268b72f X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P cpgsPolicy: CPGSC10-234,Y X-CFilter-Loop: Reflected X-CMS-RootMailID: 20250926074021epcas2p36a8dc02c84c9ca11e2318a1a8931d68a References: <20250926073921.1000866-1-sh86.bae@samsung.com> <20250926073921.1000866-4-sh86.bae@samsung.com> > > + pcie_2l_phy: pcie-phy2l@161c6000{ > > > > Node names should be generic. See also an explanation and list of examples > (not exhaustive) in DT specification: > https://protect2.fireeye.com/v1/url?k=d2bcf1f2-8d273f96-d2bd7abd- > 000babda0201-1fe7eb4ecd262f65&q=1&e=8522e96d-f1a1-4b6b-baa9- > 44344340469a&u=https%3A%2F%2Fdevicetree- > specification.readthedocs.io%2Fen%2Flatest%2Fchapter2-devicetree- > basics.html%23generic-names-recommendation > If you cannot find a name matching your device, please check in kernel > sources for similar cases or you can grow the spec (via pull request to DT > spec repo). I will rename the node referring the guideline you linked. > Plus style issues... missing space. Will add space before left brace. > I would like to see also PCIe nodes somewhere, because I wonder if num- > lanes should not be moved to PCI node (phy consumer) instead. > Current approach feels better, but maybe it just duplicates num-lanes from > the PCI? As mentioned earlier, I plan to enable the PCIe nodes later. However, I can share my prototype PCIe node that I am currently using for PCIe driver testing: pcie_0: pcie@163c0000 { compatible = "samsung,exynosautov920-pcie"; gpios = <&gph0 1 0>; /* PERST */ reg = <0x163C0000 0x1000>, <0x12000000 0x20000>, <0x2fffd000 0x2000>, <0x12600000 0x2000>; reg-names = "elbi", "dbi", "config", "atu"; #address-cells = <3>; #size-cells = <2>; #interrupt-cells = <1>; device_type = "pci"; interrupts = ; interrupt-map-mask = <0 0 0 0>; interrupt-map = <0 0 0 0 &gic GIC_SPI 444 IRQ_TYPE_LEVEL_HIGH>; clocks = <&xtcxo>; clock-names = "ref_clk"; num-lanes = <1>; num-viewport = <3>; bus-range = <0x00 0xff>; phys = <&pcie_0_phy>; samsung,pcie-ch = <0>; ranges = <0x82000000 0 0x20000000 0x20000000 0 0x1FFFD000>; status = "disabled"; }; As you expected, num-lanes will be defined only in the PCIe node. Please let me know if this composition of the DT nodes looks appropriate to you.