From: "Katsuhiro Suzuki" <suzuki.katsuhiro@socionext.com>
To: "'Mark Brown'" <broonie@kernel.org>,
"Suzuki, Katsuhiro/鈴木 勝博" <suzuki.katsuhiro@socionext.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Masami Hiramatsu <masami.hiramatsu@linaro.org>,
linux-kernel@vger.kernel.org,
Jassi Brar <jaswinder.singh@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ASoC: add DT bindings documentation for ROHM BD28623 codec
Date: Wed, 21 Feb 2018 21:26:50 +0900 [thread overview]
Message-ID: <001801d3ab0f$3fe07490$bfa15db0$@socionext.com> (raw)
In-Reply-To: <20180221121354.GG8334@sirena.org.uk>
Hello Mark,
Thank you for your review.
> -----Original Message-----
> From: Mark Brown [mailto:broonie@kernel.org]
> Sent: Wednesday, February 21, 2018 9:14 PM
> To: Suzuki, Katsuhiro <suzuki.katsuhiro@socionext.com>
> Cc: alsa-devel@alsa-project.org; Rob Herring <robh+dt@kernel.org>; devicetree@vger.kernel.org; Masami Hiramatsu
> <masami.hiramatsu@linaro.org>; Jassi Brar <jaswinder.singh@linaro.org>; linux-arm-kernel@lists.infradead.org;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 1/2] ASoC: add DT bindings documentation for ROHM BD28623 codec
>
> On Wed, Feb 21, 2018 at 01:33:10PM +0900, Katsuhiro Suzuki wrote:
>
> > +Optional properties:
> > +- VCCA-supply : regulator phandle for the VCCA supply
> > +- VCCP1-supply: regulator phandle for the VCCP1 supply
> > +- VCCP2-supply: regulator phandle for the VCCP2 supply
>
> These should be documented as mandatory unless the device genuinely
> operates without power which seems unlikely.
Indeed, this IC does not work correctly if VCC power supply is lost.
It's not optional. I'll fix it and send V2.
Regards,
--
Katsuhiro Suzuki
next prev parent reply other threads:[~2018-02-21 12:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 4:33 [PATCH 0/2] ASoC: add support for ROHM BD28623 codec Katsuhiro Suzuki
2018-02-21 4:33 ` [PATCH 1/2] ASoC: add DT bindings documentation " Katsuhiro Suzuki
2018-02-21 12:13 ` Mark Brown
2018-02-21 12:26 ` Katsuhiro Suzuki [this message]
2018-02-21 4:33 ` [PATCH 2/2] ASoC: support " Katsuhiro Suzuki
2018-02-21 12:26 ` Mark Brown
2018-02-21 13:15 ` Katsuhiro Suzuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001801d3ab0f$3fe07490$bfa15db0$@socionext.com' \
--to=suzuki.katsuhiro@socionext.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jaswinder.singh@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).