From: "Katsuhiro Suzuki" <suzuki.katsuhiro@socionext.com>
To: "'Masahiro Yamada'" <yamada.masahiro@socionext.com>,
"Suzuki, Katsuhiro/鈴木 勝博" <suzuki.katsuhiro@socionext.com>
Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
DTML <devicetree@vger.kernel.org>,
Masami Hiramatsu <masami.hiramatsu@linaro.org>,
Jassi Brar <jaswinder.singh@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] arm64: dts: uniphier: add headphone detect gpio for LD20 global board
Date: Mon, 25 Jun 2018 11:59:11 +0900 [thread overview]
Message-ID: <001a01d40c30$7e3d3110$7ab79330$@socionext.com> (raw)
In-Reply-To: <CAK7LNATB-oa+K47z+egfV2iSKoD3x2tyMNXQp1ukS2f1Yek54g@mail.gmail.com>
Hello Yamada-san,
> -----Original Message-----
> From: Masahiro Yamada <yamada.masahiro@socionext.com>
> Sent: Saturday, June 23, 2018 12:47 PM
> To: Suzuki, Katsuhiro/鈴木 勝博 <suzuki.katsuhiro@socionext.com>
> Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>; DTML
> <devicetree@vger.kernel.org>; Masami Hiramatsu <masami.hiramatsu@linaro.org>;
> Jassi Brar <jaswinder.singh@linaro.org>; Linux Kernel Mailing List
> <linux-kernel@vger.kernel.org>
> Subject: Re: [PATCH 1/2] arm64: dts: uniphier: add headphone detect gpio for LD20
> global board
>
> 2018-06-19 13:11 GMT+09:00 Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>:
> > This patch adds GPIO for headphone detection on LD20 global board.
> >
> > Signed-off-by: Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>
> > ---
> > arch/arm64/boot/dts/socionext/uniphier-ld20-global.dts | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/socionext/uniphier-ld20-global.dts
> b/arch/arm64/boot/dts/socionext/uniphier-ld20-global.dts
> > index 6a074a20c924..38b75998e2dd 100644
> > --- a/arch/arm64/boot/dts/socionext/uniphier-ld20-global.dts
> > +++ b/arch/arm64/boot/dts/socionext/uniphier-ld20-global.dts
> > @@ -60,6 +60,7 @@
> > &i2s_port4
> > &spdif_port0
> > &comp_spdif_port0>;
> > + hp-det-gpio = <&gpio UNIPHIER_GPIO_PORT(15, 0) GPIO_ACTIVE_LOW>;
>
>
> When you use irq-capable gpio pin (XIRQ0),
> please write like follows for consistency.
>
>
> hp-det-gpio = <&gpio UNIPHIER_GPIO_IRQ(0) GPIO_ACTIVE_LOW>;
>
>
> See uniphier-ld20-ref.dts for example.
Thank you for reviewing!
I'll fix it and post v2.
Regards,
--
Katsuhiro Suzuki
>
>
>
> > };
> >
> > spdif-out {
> > --
> > 2.17.1
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe devicetree" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
>
> --
> Best Regards
> Masahiro Yamada
prev parent reply other threads:[~2018-06-25 2:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 4:11 [PATCH 1/2] arm64: dts: uniphier: add headphone detect gpio for LD20 global board Katsuhiro Suzuki
2018-06-19 4:11 ` [PATCH 2/2] arm64: dts: uniphier: add headphone detect gpio for LD11 " Katsuhiro Suzuki
2018-06-23 3:47 ` [PATCH 1/2] arm64: dts: uniphier: add headphone detect gpio for LD20 " Masahiro Yamada
2018-06-25 2:59 ` Katsuhiro Suzuki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001a01d40c30$7e3d3110$7ab79330$@socionext.com' \
--to=suzuki.katsuhiro@socionext.com \
--cc=devicetree@vger.kernel.org \
--cc=jaswinder.singh@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu@linaro.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).