* [PATCH 1/2] arm64: dts: uniphier: add headphone detect gpio for LD20 global board
@ 2018-06-19 4:11 Katsuhiro Suzuki
2018-06-19 4:11 ` [PATCH 2/2] arm64: dts: uniphier: add headphone detect gpio for LD11 " Katsuhiro Suzuki
2018-06-23 3:47 ` [PATCH 1/2] arm64: dts: uniphier: add headphone detect gpio for LD20 " Masahiro Yamada
0 siblings, 2 replies; 4+ messages in thread
From: Katsuhiro Suzuki @ 2018-06-19 4:11 UTC (permalink / raw)
To: linux-arm-kernel, Masahiro Yamada, devicetree
Cc: Masami Hiramatsu, Jassi Brar, linux-kernel, Katsuhiro Suzuki
This patch adds GPIO for headphone detection on LD20 global board.
Signed-off-by: Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>
---
arch/arm64/boot/dts/socionext/uniphier-ld20-global.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/socionext/uniphier-ld20-global.dts b/arch/arm64/boot/dts/socionext/uniphier-ld20-global.dts
index 6a074a20c924..38b75998e2dd 100644
--- a/arch/arm64/boot/dts/socionext/uniphier-ld20-global.dts
+++ b/arch/arm64/boot/dts/socionext/uniphier-ld20-global.dts
@@ -60,6 +60,7 @@
&i2s_port4
&spdif_port0
&comp_spdif_port0>;
+ hp-det-gpio = <&gpio UNIPHIER_GPIO_PORT(15, 0) GPIO_ACTIVE_LOW>;
};
spdif-out {
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] arm64: dts: uniphier: add headphone detect gpio for LD11 global board
2018-06-19 4:11 [PATCH 1/2] arm64: dts: uniphier: add headphone detect gpio for LD20 global board Katsuhiro Suzuki
@ 2018-06-19 4:11 ` Katsuhiro Suzuki
2018-06-23 3:47 ` [PATCH 1/2] arm64: dts: uniphier: add headphone detect gpio for LD20 " Masahiro Yamada
1 sibling, 0 replies; 4+ messages in thread
From: Katsuhiro Suzuki @ 2018-06-19 4:11 UTC (permalink / raw)
To: linux-arm-kernel, Masahiro Yamada, devicetree
Cc: Masami Hiramatsu, Jassi Brar, linux-kernel, Katsuhiro Suzuki
This patch adds GPIO for headphone detection on LD11 global board.
Signed-off-by: Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>
---
arch/arm64/boot/dts/socionext/uniphier-ld11-global.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/socionext/uniphier-ld11-global.dts b/arch/arm64/boot/dts/socionext/uniphier-ld11-global.dts
index 798882cccbd6..e5bda40b3ec6 100644
--- a/arch/arm64/boot/dts/socionext/uniphier-ld11-global.dts
+++ b/arch/arm64/boot/dts/socionext/uniphier-ld11-global.dts
@@ -60,6 +60,7 @@
&i2s_port4
&spdif_port0
&comp_spdif_port0>;
+ hp-det-gpio = <&gpio UNIPHIER_GPIO_PORT(15, 0) GPIO_ACTIVE_LOW>;
};
spdif-out {
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] arm64: dts: uniphier: add headphone detect gpio for LD20 global board
2018-06-19 4:11 [PATCH 1/2] arm64: dts: uniphier: add headphone detect gpio for LD20 global board Katsuhiro Suzuki
2018-06-19 4:11 ` [PATCH 2/2] arm64: dts: uniphier: add headphone detect gpio for LD11 " Katsuhiro Suzuki
@ 2018-06-23 3:47 ` Masahiro Yamada
2018-06-25 2:59 ` Katsuhiro Suzuki
1 sibling, 1 reply; 4+ messages in thread
From: Masahiro Yamada @ 2018-06-23 3:47 UTC (permalink / raw)
To: Katsuhiro Suzuki
Cc: DTML, Linux Kernel Mailing List, Masami Hiramatsu,
linux-arm-kernel, Jassi Brar
2018-06-19 13:11 GMT+09:00 Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>:
> This patch adds GPIO for headphone detection on LD20 global board.
>
> Signed-off-by: Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>
> ---
> arch/arm64/boot/dts/socionext/uniphier-ld20-global.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/socionext/uniphier-ld20-global.dts b/arch/arm64/boot/dts/socionext/uniphier-ld20-global.dts
> index 6a074a20c924..38b75998e2dd 100644
> --- a/arch/arm64/boot/dts/socionext/uniphier-ld20-global.dts
> +++ b/arch/arm64/boot/dts/socionext/uniphier-ld20-global.dts
> @@ -60,6 +60,7 @@
> &i2s_port4
> &spdif_port0
> &comp_spdif_port0>;
> + hp-det-gpio = <&gpio UNIPHIER_GPIO_PORT(15, 0) GPIO_ACTIVE_LOW>;
When you use irq-capable gpio pin (XIRQ0),
please write like follows for consistency.
hp-det-gpio = <&gpio UNIPHIER_GPIO_IRQ(0) GPIO_ACTIVE_LOW>;
See uniphier-ld20-ref.dts for example.
> };
>
> spdif-out {
> --
> 2.17.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] arm64: dts: uniphier: add headphone detect gpio for LD20 global board
2018-06-23 3:47 ` [PATCH 1/2] arm64: dts: uniphier: add headphone detect gpio for LD20 " Masahiro Yamada
@ 2018-06-25 2:59 ` Katsuhiro Suzuki
0 siblings, 0 replies; 4+ messages in thread
From: Katsuhiro Suzuki @ 2018-06-25 2:59 UTC (permalink / raw)
To: 'Masahiro Yamada',
Suzuki, Katsuhiro/鈴木 勝博
Cc: linux-arm-kernel, DTML, Masami Hiramatsu, Jassi Brar,
Linux Kernel Mailing List
Hello Yamada-san,
> -----Original Message-----
> From: Masahiro Yamada <yamada.masahiro@socionext.com>
> Sent: Saturday, June 23, 2018 12:47 PM
> To: Suzuki, Katsuhiro/鈴木 勝博 <suzuki.katsuhiro@socionext.com>
> Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>; DTML
> <devicetree@vger.kernel.org>; Masami Hiramatsu <masami.hiramatsu@linaro.org>;
> Jassi Brar <jaswinder.singh@linaro.org>; Linux Kernel Mailing List
> <linux-kernel@vger.kernel.org>
> Subject: Re: [PATCH 1/2] arm64: dts: uniphier: add headphone detect gpio for LD20
> global board
>
> 2018-06-19 13:11 GMT+09:00 Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>:
> > This patch adds GPIO for headphone detection on LD20 global board.
> >
> > Signed-off-by: Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>
> > ---
> > arch/arm64/boot/dts/socionext/uniphier-ld20-global.dts | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/socionext/uniphier-ld20-global.dts
> b/arch/arm64/boot/dts/socionext/uniphier-ld20-global.dts
> > index 6a074a20c924..38b75998e2dd 100644
> > --- a/arch/arm64/boot/dts/socionext/uniphier-ld20-global.dts
> > +++ b/arch/arm64/boot/dts/socionext/uniphier-ld20-global.dts
> > @@ -60,6 +60,7 @@
> > &i2s_port4
> > &spdif_port0
> > &comp_spdif_port0>;
> > + hp-det-gpio = <&gpio UNIPHIER_GPIO_PORT(15, 0) GPIO_ACTIVE_LOW>;
>
>
> When you use irq-capable gpio pin (XIRQ0),
> please write like follows for consistency.
>
>
> hp-det-gpio = <&gpio UNIPHIER_GPIO_IRQ(0) GPIO_ACTIVE_LOW>;
>
>
> See uniphier-ld20-ref.dts for example.
Thank you for reviewing!
I'll fix it and post v2.
Regards,
--
Katsuhiro Suzuki
>
>
>
> > };
> >
> > spdif-out {
> > --
> > 2.17.1
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe devicetree" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
>
> --
> Best Regards
> Masahiro Yamada
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-25 2:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-19 4:11 [PATCH 1/2] arm64: dts: uniphier: add headphone detect gpio for LD20 global board Katsuhiro Suzuki
2018-06-19 4:11 ` [PATCH 2/2] arm64: dts: uniphier: add headphone detect gpio for LD11 " Katsuhiro Suzuki
2018-06-23 3:47 ` [PATCH 1/2] arm64: dts: uniphier: add headphone detect gpio for LD20 " Masahiro Yamada
2018-06-25 2:59 ` Katsuhiro Suzuki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).