From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Arnd Bergmann' <arnd@arndb.de>,
'Abhilash Kesavan' <a.kesavan@samsung.com>
Cc: nicolas.pitre@linaro.org, Dave.Martin@arm.com,
lorenzo.pieralisi@arm.com, daniel.lezcano@linaro.org,
linux-arm-kernel@lists.infradead.org, t.figa@samsung.com,
abrestic@chromium.org, thomas.ab@samsung.com,
inderpal.s@samsung.com, mark.rutland@arm.com,
devicetree@vger.kernel.org, grant.likely@linaro.org,
robh+dt@kernel.org, will.deacon@arm.com,
kesavan.abhilash@gmail.com, linux-samsung-soc@vger.kernel.org
Subject: RE: [PATCH v5 5/5] arm: exynos: Add MCPM call-back functions
Date: Tue, 27 May 2014 20:39:24 +0900 [thread overview]
Message-ID: <002101cf79a0$50fba0f0$f2f2e2d0$@samsung.com> (raw)
In-Reply-To: <201405271307.56729.arnd@arndb.de>
Arnd Bergmann wrote:
>
> On Monday 05 May 2014, Abhilash Kesavan wrote:
> > +static const struct mcpm_platform_ops exynos_power_ops = {
> > + .power_up = exynos_power_up,
> > + .power_down = exynos_power_down,
> > + .power_down_finish = exynos_power_down_finish,
> > +};
>
>
> I'm getting a build error in linux-next because there is
> no .power_down_finish
> member in mcpm_platform_ops here.
>
Yeah, commit 166aaf39 ("ARM: 8029/1: mcpm: Rename the power_down_finish()
functions to be less confusing") changed the name to
wait_for_cpu_powerdown...
So need to change it accordingly...
diff --git a/arch/arm/mach-exynos/mcpm-exynos.c
b/arch/arm/mach-exynos/mcpm-exynos.c
index 1ac618c..34c4e6f 100644
--- a/arch/arm/mach-exynos/mcpm-exynos.c
+++ b/arch/arm/mach-exynos/mcpm-exynos.c
@@ -235,7 +235,7 @@ static void exynos_power_down(void)
/* Not dead at this point? Let our caller cope. */
}
-static int exynos_power_down_finish(unsigned int cpu, unsigned int cluster)
+static int exynos_wait_for_powerdown(unsigned int cpu, unsigned int
cluster)
{
unsigned int tries = 100;
unsigned int cpunr = cpu + (cluster * EXYNOS5420_CPUS_PER_CLUSTER);
@@ -261,7 +261,7 @@ static int exynos_power_down_finish(unsigned int cpu,
unsigned int cluster)
static const struct mcpm_platform_ops exynos_power_ops = {
.power_up = exynos_power_up,
.power_down = exynos_power_down,
- .power_down_finish = exynos_power_down_finish,
+ .wait_for_powerdown = exynos_wait_for_powerdown,
};
static void __init exynos_mcpm_usage_count_init(void)
Thanks,
Kukjin
next prev parent reply other threads:[~2014-05-27 11:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 16:26 [PATCH v5 0/5] MCPM backend for Exynos5420 Abhilash Kesavan
[not found] ` <1399307221-8659-1-git-send-email-a.kesavan-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-05-05 16:26 ` [PATCH v5 1/5] ARM: EXYNOS: Add generic cpu power control functions for all exynos based SoCs Abhilash Kesavan
2014-05-13 2:24 ` Kukjin Kim
2014-05-13 10:12 ` Abhilash Kesavan
2014-05-15 21:11 ` Tomasz Figa
2014-05-16 5:07 ` Abhilash Kesavan
2014-05-17 0:32 ` Tomasz Figa
2014-05-19 2:42 ` Abhilash Kesavan
2014-05-05 16:26 ` [PATCH v5 2/5] ARM: EXYNOS: use generic exynos cpu power control functions Abhilash Kesavan
2014-05-13 2:28 ` Kukjin Kim
2014-05-13 10:13 ` Abhilash Kesavan
2014-05-05 16:27 ` [PATCH v5 4/5] ARM: dts: exynos5420: add CCI node Abhilash Kesavan
2014-05-05 16:26 ` [PATCH v5 3/5] arm: exynos: Add generic cluster power control functions Abhilash Kesavan
2014-05-05 16:27 ` [PATCH v5 5/5] arm: exynos: Add MCPM call-back functions Abhilash Kesavan
2014-05-05 18:12 ` Nicolas Pitre
2014-05-27 11:07 ` Arnd Bergmann
2014-05-27 11:39 ` Kukjin Kim [this message]
2014-05-27 14:25 ` Abhilash Kesavan
2014-05-27 15:17 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002101cf79a0$50fba0f0$f2f2e2d0$@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=Dave.Martin@arm.com \
--cc=a.kesavan@samsung.com \
--cc=abrestic@chromium.org \
--cc=arnd@arndb.de \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=inderpal.s@samsung.com \
--cc=kesavan.abhilash@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=nicolas.pitre@linaro.org \
--cc=robh+dt@kernel.org \
--cc=t.figa@samsung.com \
--cc=thomas.ab@samsung.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).