From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jingoo Han Subject: Re: [PATCH v2] of/irq: provide int of_irq_parse_and_map_pci wrapper Date: Wed, 28 May 2014 10:35:43 +0900 Message-ID: <002301cf7a15$23eb5180$6bc1f480$%han@samsung.com> References: <4527717.yJh2gX3xCP@wuerfel> <1399624119.4833.3.camel@weser.hi.pengutronix.de> <5744457.bgUFy9g0ST@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-reply-to: Content-language: ko Sender: linux-sh-owner@vger.kernel.org To: 'Geert Uytterhoeven' , 'Arnd Bergmann' Cc: 'Lucas Stach' , devicetree@vger.kernel.org, 'Grant Likely' , 'Rob Herring' , 'Bjorn Helgaas' , 'Magnus Damm' , 'Ben Dooks' , 'linux-pci' , 'Linux-sh list' , 'Jingoo Han' List-Id: devicetree@vger.kernel.org On Friday, May 09, 2014 6:10 PM, Geert Uytterhoeven wrote: > On Fri, May 9, 2014 at 11:03 AM, Arnd Bergmann wrote: > > The pci-rcar driver is enabled for compile tests, and this has > > now shown that the driver cannot build without CONFIG_OF, > > following the inclusion of f8f2fe7355fb "PCI: rcar: Use new OF > > interrupt mapping when possible": > > > > drivers/built-in.o: In function `rcar_pci_map_irq': > > :(.text+0x1cc7c): undefined reference to `of_irq_parse_and_map_pci' > > > > As pointed out by Ben Dooks and Geert Uytterhoeven, this is actually > > supposed to build fine, which we can achieve if we make the > > declaration of of_irq_parse_and_map_pci conditional on CONFIG_OF > > and provide an empty inline function otherwise, as we do for > > a lot of other of interfaces. > > > > This lets us build the rcar_pci driver again without CONFIG_OF > > for build testing. All platforms using this driver select OF, > > so this doesn't change anything for the users. > > Thanks! > > > Signed-off-by: Arnd Bergmann > > Cc: Bjorn Helgaas > > Cc: Magnus Damm > > Cc: Geert Uytterhoeven > > Cc: Ben Dooks > > Cc: linux-pci@vger.kernel.org > > Cc: linux-sh@vger.kernel.org > > Acked-by: Geert Uytterhoeven Reviewed-by: Jingoo Han Best regards, Jingoo Han