RE: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 HS phy compatible

["Pritam Manohar Sutar" <pritam.sutar@samsung.com>]

Hi Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 08 October 2025 01:42 PM
> To: Pritam Manohar Sutar <pritam.sutar@samsung.com>; vkoul@kernel.org;
> kishon@kernel.org; robh@kernel.org; krzk+dt@kernel.org;
> conor+dt@kernel.org; alim.akhtar@samsung.com; andre.draszik@linaro.org;
> peter.griffin@linaro.org; kauschluss@disroot.org;
> ivo.ivanov.ivanov1@gmail.com; igor.belwon@mentallysanemainliners.org;
> m.szyprowski@samsung.com; s.nawrocki@samsung.com
> Cc: linux-phy@lists.infradead.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung-
> soc@vger.kernel.org; rosa.pila@samsung.com; dev.tailor@samsung.com;
> faraz.ata@samsung.com; muhammed.ali@samsung.com;
> selvarasu.g@samsung.com
> Subject: Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add
> ExynosAutov920 HS phy compatible
> 
> On 08/10/2025 13:45, Pritam Manohar Sutar wrote:
> > Hi Krzysztof,
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzk@kernel.org>
> >> Sent: 07 October 2025 11:54 AM
> >> To: Pritam Manohar Sutar <pritam.sutar@samsung.com>;
> >> vkoul@kernel.org; kishon@kernel.org; robh@kernel.org;
> >> krzk+dt@kernel.org;
> >> conor+dt@kernel.org; alim.akhtar@samsung.com;
> >> conor+andre.draszik@linaro.org;
> >> peter.griffin@linaro.org; kauschluss@disroot.org;
> >> ivo.ivanov.ivanov1@gmail.com; igor.belwon@mentallysanemainliners.org;
> >> m.szyprowski@samsung.com; s.nawrocki@samsung.com
> >> Cc: linux-phy@lists.infradead.org; devicetree@vger.kernel.org; linux-
> >> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> >> linux-samsung- soc@vger.kernel.org; rosa.pila@samsung.com;
> >> dev.tailor@samsung.com; faraz.ata@samsung.com;
> >> muhammed.ali@samsung.com; selvarasu.g@samsung.com
> >> Subject: Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy:
> >> add
> >> ExynosAutov920 HS phy compatible
> >>
> >> On 22/09/2025 14:26, Pritam Manohar Sutar wrote:
> >>> This phy needs 0.75v, 0.18v and 3.3v supplies for its internal
> >>> functionally. Power Supply's names are as per phy's User Data-Book.
> >>> These names, (dvdd, vdd18 and vdd33), are considered  for 0.75v,
> >>> 1.8v and 3.3v respectively.
> >>> "
> >>>
> >>>>
> >>>> I still cannot find constraints for the rest of properties, though.
> >>>
> >>> Sorry I didn't get it completely. Can you please elaborate on the same?
> >>
> >>
> >> Writing bindings and introductory talks elaborate on that. You add
> >> properties without constraints. That's not what we want. We want
> constraints.
> >>
> >
> > Have added only supplies in this patch-set. However, was going through
> > schema example and it says nothing is needed to define in terms of
> > supply.
> 
> 
> I don't have original patchset in my inbox anymore, so not sure what was there,
> but most likely you miss constraining the presence of these properties per each
> variant. IOW, not each of devices in the bindings have these supplies, so I expect
> syntax similar as in example-schema.
> 
> https://protect2.fireeye.com/v1/url?k=b15f03dc-eee70b7e-b15e8893-
> 000babff88b5-a120365cc01c0261&q=1&e=61c09dc1-e3de-4b16-b34f-
> edc1fae43bb8&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Fv5.19%2Fsour
> ce%2FDocumentation%2Fdevicetree%2Fbindings%2Fexample-
> schema.yaml%23L212
> 

Yes, this was already considered based on Rob's comment and
snippet is as below. 

https://lore.kernel.org/linux-phy/20250806234217.GA2030512-robh@kernel.org/

+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - samsung,exynosautov920-usbdrd-phy
+    then:
+      required:
+        - dvdd-supply
+        - vdd18-supply
+        - vdd33-supply
+
+    else:
+      properties:
+        dvdd-supply: false
+        vdd18-supply: false
+        vdd33-supply: false

I understand that you have lost the context, my bad. 
Let me share v9 with all RB tags added in v7 and v8 and 
let us have all consolidated review one more time (sorry for this).

> 
> Best regards,
> Krzysztof


Thank you,

Regards,
Pritam