From: Jingoo Han <jg1.han@samsung.com>
To: 'Rahul Sharma' <rahul.sharma@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com,
inki.dae@samsung.com, tomasz.figa@gmail.com, joshi@samsung.com,
r.sh.open@gmail.com, 'Sachin Kamat' <sachin.kamat@linaro.org>,
'Tomasz Figa' <t.figa@samsung.com>,
'Jingoo Han' <jg1.han@samsung.com>
Subject: Re: [PATCH v2 2/5] ARM: dts: enable fimd for exynos5250 based snow board
Date: Thu, 08 May 2014 16:20:05 +0900 [thread overview]
Message-ID: <002701cf6a8d$ef7b4540$ce71cfc0$%han@samsung.com> (raw)
In-Reply-To: <1399529995-8656-3-git-send-email-rahul.sharma@samsung.com>
On Thursday, May 08, 2014 3:20 PM, Rahul Sharma wrote:
>
> From: Rahul Sharma <Rahul.Sharma@samsung.com>
>
> Enable fimd node for snow board.
>
> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
> ---
> arch/arm/boot/dts/exynos5250-snow.dts | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
> index 1ce1088..796954c 100644
> --- a/arch/arm/boot/dts/exynos5250-snow.dts
> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
> @@ -206,4 +206,10 @@
> clock-frequency = <24000000>;
> };
> };
> +
> + fimd@14400000 {
> + status = "okay";
(+cc Sachin Kamat, Tomasz Figa)
For readability, how about moving 'status' to the last entry of
the node? The same comment applies to other patches, too.
Best regards,
Jingoo Han
> + samsung,invert-vclk;
> + };
> +
> };
> --
> 1.7.9.5
next prev parent reply other threads:[~2014-05-08 7:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 6:19 [PATCH v2 0/5] ARM: dts: enable display for peach-pit and snow boards Rahul Sharma
2014-05-08 6:19 ` [PATCH v2 1/5] ARM: dts: move dp hpd line to the board file for exynos5420 Rahul Sharma
2014-05-08 6:19 ` [PATCH v2 2/5] ARM: dts: enable fimd for exynos5250 based snow board Rahul Sharma
2014-05-08 7:20 ` Jingoo Han [this message]
2014-05-08 9:15 ` Rahul Sharma
2014-05-08 9:27 ` Sachin Kamat
2014-05-08 6:19 ` [PATCH v2 3/5] ARM: dts: enable dp-controller " Rahul Sharma
2014-05-08 7:42 ` Jingoo Han
2014-05-08 9:16 ` Rahul Sharma
2014-05-08 6:19 ` [PATCH v2 4/5] ARM: dts: enable fimd for exynos5420 based peach-pit board Rahul Sharma
2014-05-08 6:19 ` [PATCH v2 5/5] ARM: dts: enable dp-controller " Rahul Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002701cf6a8d$ef7b4540$ce71cfc0$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=inki.dae@samsung.com \
--cc=joshi@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=r.sh.open@gmail.com \
--cc=rahul.sharma@samsung.com \
--cc=sachin.kamat@linaro.org \
--cc=t.figa@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).