From: Jingoo Han <jg1.han@samsung.com>
To: 'Pratyush Anand' <pratyush.anand@st.com>
Cc: 'Bjorn Helgaas' <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
'Kukjin Kim' <kgene.kim@samsung.com>,
'Mohit KUMAR DCG' <Mohit.KUMAR@st.com>,
'Siva Reddy Kallam' <siva.kallam@samsung.com>,
'SRIKANTH TUMKUR SHIVANAND' <ts.srikanth@samsung.com>,
'Arnd Bergmann' <arnd@arndb.de>, 'Sean Cross' <xobs@kosagi.com>,
'Kishon Vijay Abraham I' <kishon@ti.com>,
'Thierry Reding' <thierry.reding@gmail.com>,
'Thomas Petazzoni' <thomas.petazzoni@free-electrons.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
'Jingoo Han' <jg1.han@samsung.com>
Subject: Re: [PATCH V2] PCI: exynos: add support for MSI
Date: Thu, 29 Aug 2013 13:43:00 +0900 [thread overview]
Message-ID: <003001cea472$3d6ffee0$b84ffca0$%han@samsung.com> (raw)
In-Reply-To: <20130829034508.GA3025@pratyush-vbox>
On Thursday, August 29, 2013 12:45 PM, Pratyush Anand wrote:
> On Wed, Aug 28, 2013 at 04:17:24PM +0800, Jingoo Han wrote:
> > On Friday, August 23, 2013 5:36 PM, Pratyush Anand wrote:
> > > On Fri, Aug 23, 2013 at 02:04:20PM +0800, Jingoo Han wrote:
> >
>
> [...]
>
> > > #define MAX_PCIE_PORT_SUPPORTED 3
> > > static DECLARE_BITMAP(msi_irq_in_use[MAX_PCIE_PORT_SUPPORTED],
> > > NUM_MSI_IRQS);
> > > static unsigned int *msi_data[MAX_PCIE_PORT_SUPPORTED];
> >
> > No, there is no need to do it.
> > Without this, we can use 3 RCs by adding a node of 3rd RC to dt file.
> >
>
> Yes, you can use RCs by adding nodes to dt file. But you will need one
> msi_irq_in_use and one msi_data per RC (ie per port in this driver), isn't it?
Aha, you're right.
A few minutes ago, I found the same value of msi_data is
used for 2 different RCs. It is my fault.
As you mentioned, one msi_data per RC should be used.
I will modify it in order to use one msi_data per RC.
Thank you for your kind description. :-)
Best regards,
Jingoo Han
prev parent reply other threads:[~2013-08-29 4:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 6:04 [PATCH V2] PCI: exynos: add support for MSI Jingoo Han
2013-08-23 8:35 ` Pratyush Anand
2013-08-23 9:22 ` Thierry Reding
2013-08-25 20:28 ` Arnd Bergmann
2013-08-28 8:17 ` Jingoo Han
2013-08-29 3:45 ` Pratyush Anand
2013-08-29 4:43 ` Jingoo Han [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003001cea472$3d6ffee0$b84ffca0$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=Mohit.KUMAR@st.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=kgene.kim@samsung.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=pratyush.anand@st.com \
--cc=siva.kallam@samsung.com \
--cc=thierry.reding@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=ts.srikanth@samsung.com \
--cc=xobs@kosagi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).