From: Krzysztof Kozlowski <krzk@kernel.org>
To: FUKAUMI Naoki <naoki@radxa.com>, neil.armstrong@linaro.org
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
khilman@baylibre.com, jbrunet@baylibre.com,
martin.blumenstingl@googlemail.com, devicetree@vger.kernel.org,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 2/2] arm64: dts: amlogic: change product name for Radxa ZERO 2 (Pro)
Date: Thu, 11 Jul 2024 09:45:31 +0200 [thread overview]
Message-ID: <0036cb62-7621-4458-9011-cae56208eefc@kernel.org> (raw)
In-Reply-To: <DFED8CF3B42049F8+44664265-ab1e-4d45-833c-41c370e4360b@radxa.com>
On 11/07/2024 08:58, FUKAUMI Naoki wrote:
>>>
>>> / {
>>> - compatible = "radxa,zero2", "amlogic,a311d", "amlogic,g12b";
>>> - model = "Radxa Zero2";
>>> + compatible = "radxa,zero-2pro", "amlogic,a311d", "amlogic,g12b";
>>
>> Keep old compatible.
>
> which is better?
>
> compatible = "radxa,zero2", "amlogic,a311d", "amlogic,g12b"; (no change)
> or
> compatible = "radxa,zero-2pro", "radxa,zero2", "amlogic,a311d",
> "amlogic,g12b"; (keep old one)
I propose not to change anything, at least based on your
explanations/rationale.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-11 7:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 3:40 [PATCH 1/2] dt-bindings: arm: amlogic: change product name for Radxa ZERO 2 (Pro) FUKAUMI Naoki
2024-07-11 3:40 ` [PATCH 2/2] arm64: dts: " FUKAUMI Naoki
2024-07-11 6:24 ` Krzysztof Kozlowski
2024-07-11 6:58 ` FUKAUMI Naoki
2024-07-11 7:45 ` Krzysztof Kozlowski [this message]
2024-07-11 8:52 ` FUKAUMI Naoki
2024-07-11 6:24 ` [PATCH 1/2] dt-bindings: arm: " Krzysztof Kozlowski
2024-07-11 14:20 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0036cb62-7621-4458-9011-cae56208eefc@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=naoki@radxa.com \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).