* [PATCH 1/2] dt-bindings: arm: amlogic: change product name for Radxa ZERO 2 (Pro)
@ 2024-07-11 3:40 FUKAUMI Naoki
2024-07-11 3:40 ` [PATCH 2/2] arm64: dts: " FUKAUMI Naoki
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: FUKAUMI Naoki @ 2024-07-11 3:40 UTC (permalink / raw)
To: neil.armstrong
Cc: robh, krzk+dt, conor+dt, khilman, jbrunet, martin.blumenstingl,
devicetree, linux-amlogic, FUKAUMI Naoki
a while ago, we changed product name (hardware is same),
from: Radxa ZERO2
to: Radxa ZERO 2 Pro
this patch reflect the change in dt-bindings.
Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
Documentation/devicetree/bindings/arm/amlogic.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
index 0647851ae1f5..25f509b943af 100644
--- a/Documentation/devicetree/bindings/arm/amlogic.yaml
+++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
@@ -157,7 +157,7 @@ properties:
- bananapi,bpi-m2s
- khadas,vim3
- libretech,aml-a311d-cc
- - radxa,zero2
+ - radxa,zero-2pro
- const: amlogic,a311d
- const: amlogic,g12b
--
2.43.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] arm64: dts: amlogic: change product name for Radxa ZERO 2 (Pro)
2024-07-11 3:40 [PATCH 1/2] dt-bindings: arm: amlogic: change product name for Radxa ZERO 2 (Pro) FUKAUMI Naoki
@ 2024-07-11 3:40 ` FUKAUMI Naoki
2024-07-11 6:24 ` Krzysztof Kozlowski
2024-07-11 6:24 ` [PATCH 1/2] dt-bindings: arm: " Krzysztof Kozlowski
2024-07-11 14:20 ` Rob Herring (Arm)
2 siblings, 1 reply; 8+ messages in thread
From: FUKAUMI Naoki @ 2024-07-11 3:40 UTC (permalink / raw)
To: neil.armstrong
Cc: robh, krzk+dt, conor+dt, khilman, jbrunet, martin.blumenstingl,
devicetree, linux-amlogic, FUKAUMI Naoki
a while ago, we changed product name (hardware is same),
from: Radxa ZERO2
to: Radxa ZERO 2 Pro
this patch reflect the change in dts.
Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
arch/arm64/boot/dts/amlogic/Makefile | 2 +-
...-g12b-radxa-zero2.dts => meson-g12b-radxa-zero-2pro.dts} | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
rename arch/arm64/boot/dts/amlogic/{meson-g12b-radxa-zero2.dts => meson-g12b-radxa-zero-2pro.dts} (98%)
diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
index 29417f04f886..5694ad0edcde 100644
--- a/arch/arm64/boot/dts/amlogic/Makefile
+++ b/arch/arm64/boot/dts/amlogic/Makefile
@@ -31,7 +31,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-go-ultra.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-n2-plus.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-n2.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-n2l.dtb
-dtb-$(CONFIG_ARCH_MESON) += meson-g12b-radxa-zero2.dtb
+dtb-$(CONFIG_ARCH_MESON) += meson-g12b-radxa-zero-2pro.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-g12b-s922x-bananapi-m2s.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-g12b-s922x-khadas-vim3.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-g12b-ugoos-am6.dtb
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero2.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero-2pro.dts
similarity index 98%
rename from arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero2.dts
rename to arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero-2pro.dts
index 8445701100d0..5514ca9a62fb 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero-2pro.dts
@@ -16,8 +16,8 @@
#include <dt-bindings/sound/meson-g12a-tohdmitx.h>
/ {
- compatible = "radxa,zero2", "amlogic,a311d", "amlogic,g12b";
- model = "Radxa Zero2";
+ compatible = "radxa,zero-2pro", "amlogic,a311d", "amlogic,g12b";
+ model = "Radxa ZERO 2 Pro";
aliases {
serial0 = &uart_AO;
@@ -169,7 +169,7 @@ vddcpu_b: regulator-vddcpu-b {
sound {
compatible = "amlogic,axg-sound-card";
- model = "RADXA-ZERO2";
+ model = "RADXA-ZERO-2PRO";
audio-aux-devs = <&tdmout_b>;
audio-routing = "TDMOUT_B IN 0", "FRDDR_A OUT 1",
"TDMOUT_B IN 1", "FRDDR_B OUT 1",
--
2.43.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: amlogic: change product name for Radxa ZERO 2 (Pro)
2024-07-11 3:40 [PATCH 1/2] dt-bindings: arm: amlogic: change product name for Radxa ZERO 2 (Pro) FUKAUMI Naoki
2024-07-11 3:40 ` [PATCH 2/2] arm64: dts: " FUKAUMI Naoki
@ 2024-07-11 6:24 ` Krzysztof Kozlowski
2024-07-11 14:20 ` Rob Herring (Arm)
2 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2024-07-11 6:24 UTC (permalink / raw)
To: FUKAUMI Naoki, neil.armstrong
Cc: robh, krzk+dt, conor+dt, khilman, jbrunet, martin.blumenstingl,
devicetree, linux-amlogic
On 11/07/2024 05:40, FUKAUMI Naoki wrote:
> a while ago, we changed product name (hardware is same),
>
> from: Radxa ZERO2
> to: Radxa ZERO 2 Pro
>
> this patch reflect the change in dt-bindings.
>
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
Compatible does not reflect product name changes. It should stay.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] arm64: dts: amlogic: change product name for Radxa ZERO 2 (Pro)
2024-07-11 3:40 ` [PATCH 2/2] arm64: dts: " FUKAUMI Naoki
@ 2024-07-11 6:24 ` Krzysztof Kozlowski
2024-07-11 6:58 ` FUKAUMI Naoki
0 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2024-07-11 6:24 UTC (permalink / raw)
To: FUKAUMI Naoki, neil.armstrong
Cc: robh, krzk+dt, conor+dt, khilman, jbrunet, martin.blumenstingl,
devicetree, linux-amlogic
On 11/07/2024 05:40, FUKAUMI Naoki wrote:
> a while ago, we changed product name (hardware is same),
>
> from: Radxa ZERO2
> to: Radxa ZERO 2 Pro
>
> this patch reflect the change in dts.
>
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
> ---
> arch/arm64/boot/dts/amlogic/Makefile | 2 +-
> ...-g12b-radxa-zero2.dts => meson-g12b-radxa-zero-2pro.dts} | 6 +++---
> 2 files changed, 4 insertions(+), 4 deletions(-)
> rename arch/arm64/boot/dts/amlogic/{meson-g12b-radxa-zero2.dts => meson-g12b-radxa-zero-2pro.dts} (98%)
>
> diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
> index 29417f04f886..5694ad0edcde 100644
> --- a/arch/arm64/boot/dts/amlogic/Makefile
> +++ b/arch/arm64/boot/dts/amlogic/Makefile
> @@ -31,7 +31,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-go-ultra.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-n2-plus.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-n2.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-n2l.dtb
> -dtb-$(CONFIG_ARCH_MESON) += meson-g12b-radxa-zero2.dtb
> +dtb-$(CONFIG_ARCH_MESON) += meson-g12b-radxa-zero-2pro.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-g12b-s922x-bananapi-m2s.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-g12b-s922x-khadas-vim3.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-g12b-ugoos-am6.dtb
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero2.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero-2pro.dts
> similarity index 98%
> rename from arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero2.dts
> rename to arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero-2pro.dts
> index 8445701100d0..5514ca9a62fb 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero-2pro.dts
> @@ -16,8 +16,8 @@
> #include <dt-bindings/sound/meson-g12a-tohdmitx.h>
>
> / {
> - compatible = "radxa,zero2", "amlogic,a311d", "amlogic,g12b";
> - model = "Radxa Zero2";
> + compatible = "radxa,zero-2pro", "amlogic,a311d", "amlogic,g12b";
Keep old compatible.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] arm64: dts: amlogic: change product name for Radxa ZERO 2 (Pro)
2024-07-11 6:24 ` Krzysztof Kozlowski
@ 2024-07-11 6:58 ` FUKAUMI Naoki
2024-07-11 7:45 ` Krzysztof Kozlowski
0 siblings, 1 reply; 8+ messages in thread
From: FUKAUMI Naoki @ 2024-07-11 6:58 UTC (permalink / raw)
To: Krzysztof Kozlowski, neil.armstrong
Cc: robh, krzk+dt, conor+dt, khilman, jbrunet, martin.blumenstingl,
devicetree, linux-amlogic
Hi,
thanks for your reply.
On 7/11/24 15:24, Krzysztof Kozlowski wrote:
> On 11/07/2024 05:40, FUKAUMI Naoki wrote:
>> a while ago, we changed product name (hardware is same),
>>
>> from: Radxa ZERO2
>> to: Radxa ZERO 2 Pro
>>
>> this patch reflect the change in dts.
>>
>> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
>> ---
>> arch/arm64/boot/dts/amlogic/Makefile | 2 +-
>> ...-g12b-radxa-zero2.dts => meson-g12b-radxa-zero-2pro.dts} | 6 +++---
>> 2 files changed, 4 insertions(+), 4 deletions(-)
>> rename arch/arm64/boot/dts/amlogic/{meson-g12b-radxa-zero2.dts => meson-g12b-radxa-zero-2pro.dts} (98%)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
>> index 29417f04f886..5694ad0edcde 100644
>> --- a/arch/arm64/boot/dts/amlogic/Makefile
>> +++ b/arch/arm64/boot/dts/amlogic/Makefile
>> @@ -31,7 +31,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-go-ultra.dtb
>> dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-n2-plus.dtb
>> dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-n2.dtb
>> dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-n2l.dtb
>> -dtb-$(CONFIG_ARCH_MESON) += meson-g12b-radxa-zero2.dtb
>> +dtb-$(CONFIG_ARCH_MESON) += meson-g12b-radxa-zero-2pro.dtb
>> dtb-$(CONFIG_ARCH_MESON) += meson-g12b-s922x-bananapi-m2s.dtb
>> dtb-$(CONFIG_ARCH_MESON) += meson-g12b-s922x-khadas-vim3.dtb
>> dtb-$(CONFIG_ARCH_MESON) += meson-g12b-ugoos-am6.dtb
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero2.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero-2pro.dts
>> similarity index 98%
>> rename from arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero2.dts
>> rename to arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero-2pro.dts
>> index 8445701100d0..5514ca9a62fb 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero2.dts
>> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero-2pro.dts
>> @@ -16,8 +16,8 @@
>> #include <dt-bindings/sound/meson-g12a-tohdmitx.h>
>>
>> / {
>> - compatible = "radxa,zero2", "amlogic,a311d", "amlogic,g12b";
>> - model = "Radxa Zero2";
>> + compatible = "radxa,zero-2pro", "amlogic,a311d", "amlogic,g12b";
>
> Keep old compatible.
which is better?
compatible = "radxa,zero2", "amlogic,a311d", "amlogic,g12b"; (no change)
or
compatible = "radxa,zero-2pro", "radxa,zero2", "amlogic,a311d",
"amlogic,g12b"; (keep old one)
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
> Best regards,
> Krzysztof
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] arm64: dts: amlogic: change product name for Radxa ZERO 2 (Pro)
2024-07-11 6:58 ` FUKAUMI Naoki
@ 2024-07-11 7:45 ` Krzysztof Kozlowski
2024-07-11 8:52 ` FUKAUMI Naoki
0 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2024-07-11 7:45 UTC (permalink / raw)
To: FUKAUMI Naoki, neil.armstrong
Cc: robh, krzk+dt, conor+dt, khilman, jbrunet, martin.blumenstingl,
devicetree, linux-amlogic
On 11/07/2024 08:58, FUKAUMI Naoki wrote:
>>>
>>> / {
>>> - compatible = "radxa,zero2", "amlogic,a311d", "amlogic,g12b";
>>> - model = "Radxa Zero2";
>>> + compatible = "radxa,zero-2pro", "amlogic,a311d", "amlogic,g12b";
>>
>> Keep old compatible.
>
> which is better?
>
> compatible = "radxa,zero2", "amlogic,a311d", "amlogic,g12b"; (no change)
> or
> compatible = "radxa,zero-2pro", "radxa,zero2", "amlogic,a311d",
> "amlogic,g12b"; (keep old one)
I propose not to change anything, at least based on your
explanations/rationale.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] arm64: dts: amlogic: change product name for Radxa ZERO 2 (Pro)
2024-07-11 7:45 ` Krzysztof Kozlowski
@ 2024-07-11 8:52 ` FUKAUMI Naoki
0 siblings, 0 replies; 8+ messages in thread
From: FUKAUMI Naoki @ 2024-07-11 8:52 UTC (permalink / raw)
To: Krzysztof Kozlowski, neil.armstrong
Cc: robh, krzk+dt, conor+dt, khilman, jbrunet, martin.blumenstingl,
devicetree, linux-amlogic
Hi
On 7/11/24 16:45, Krzysztof Kozlowski wrote:
> On 11/07/2024 08:58, FUKAUMI Naoki wrote:
>>>>
>>>> / {
>>>> - compatible = "radxa,zero2", "amlogic,a311d", "amlogic,g12b";
>>>> - model = "Radxa Zero2";
>>>> + compatible = "radxa,zero-2pro", "amlogic,a311d", "amlogic,g12b";
>>>
>>> Keep old compatible.
>>
>> which is better?
>>
>> compatible = "radxa,zero2", "amlogic,a311d", "amlogic,g12b"; (no change)
>> or
>> compatible = "radxa,zero-2pro", "radxa,zero2", "amlogic,a311d",
>> "amlogic,g12b"; (keep old one)
>
> I propose not to change anything, at least based on your
> explanations/rationale.
I see, I don't touch anything which already exists.
then, can I add new "Radxa ZERO 2 Pro" product?
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
> Best regards,
> Krzysztof
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: amlogic: change product name for Radxa ZERO 2 (Pro)
2024-07-11 3:40 [PATCH 1/2] dt-bindings: arm: amlogic: change product name for Radxa ZERO 2 (Pro) FUKAUMI Naoki
2024-07-11 3:40 ` [PATCH 2/2] arm64: dts: " FUKAUMI Naoki
2024-07-11 6:24 ` [PATCH 1/2] dt-bindings: arm: " Krzysztof Kozlowski
@ 2024-07-11 14:20 ` Rob Herring (Arm)
2 siblings, 0 replies; 8+ messages in thread
From: Rob Herring (Arm) @ 2024-07-11 14:20 UTC (permalink / raw)
To: FUKAUMI Naoki
Cc: khilman, devicetree, linux-amlogic, martin.blumenstingl, krzk+dt,
neil.armstrong, jbrunet, conor+dt
On Thu, 11 Jul 2024 12:40:34 +0900, FUKAUMI Naoki wrote:
> a while ago, we changed product name (hardware is same),
>
> from: Radxa ZERO2
> to: Radxa ZERO 2 Pro
>
> this patch reflect the change in dt-bindings.
>
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
> ---
> Documentation/devicetree/bindings/arm/amlogic.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y amlogic/meson-g12b-radxa-zero-2pro.dtb' for 20240711034035.3921122-1-naoki@radxa.com:
arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero-2pro.dtb: sound: Unevaluated properties are not allowed ('assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks' were unexpected)
from schema $id: http://devicetree.org/schemas/sound/amlogic,axg-sound-card.yaml#
arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero-2pro.dtb: sound: 'anyOf' conditional failed, one must be fixed:
'clocks' is a required property
'#clock-cells' is a required property
from schema $id: http://devicetree.org/schemas/clock/clock.yaml#
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-07-11 14:20 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-11 3:40 [PATCH 1/2] dt-bindings: arm: amlogic: change product name for Radxa ZERO 2 (Pro) FUKAUMI Naoki
2024-07-11 3:40 ` [PATCH 2/2] arm64: dts: " FUKAUMI Naoki
2024-07-11 6:24 ` Krzysztof Kozlowski
2024-07-11 6:58 ` FUKAUMI Naoki
2024-07-11 7:45 ` Krzysztof Kozlowski
2024-07-11 8:52 ` FUKAUMI Naoki
2024-07-11 6:24 ` [PATCH 1/2] dt-bindings: arm: " Krzysztof Kozlowski
2024-07-11 14:20 ` Rob Herring (Arm)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).