From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jingoo Han Subject: Re: [PATCH 3/5] phy: Add support for S5PV210 to the Exynos USB PHY driver Date: Sat, 26 Oct 2013 10:40:02 +0900 Message-ID: <003701ced1ec$4a511d40$def357c0$%han@samsung.com> References: <1382710529-12082-1-git-send-email-k.debski@samsung.com> <1382710529-12082-4-git-send-email-k.debski@samsung.com> <526A933C.4020904@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <526A933C.4020904-l0cyMroinI0@public.gmane.org> Content-language: ko Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: 'Kishon Vijay Abraham I' , 'Kamil Debski' Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, 'Kyungmin Park' , 'Tomasz Figa' , 'Sylwester Nawrocki' , 'Marek Szyprowski' , 'Vivek Gautam' , 'Mateusz Krawczuk' , 'Praveen Paneri' , 'Yulgon Kim' , 'Anton Tikhomirov' , 'Jingoo Han' List-Id: devicetree@vger.kernel.org On Saturday, October 26, 2013 12:50 AM, Kishon Vijay Abraham I wrote: > On Friday 25 October 2013 07:45 PM, Kamil Debski wrote: > > From: Mateusz Krawczuk > > > > Add support for the Samsung's S5PV210 SoC to the Exynos USB PHY driver. > > > > Signed-off-by: Mateusz Krawczuk > > [k.debski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org: whitespace cleanup and commit description] > > Signed-off-by: Kamil Debski > > --- > > drivers/phy/Kconfig | 7 ++ > > drivers/phy/phy-exynos-usb.c | 10 ++ > > drivers/phy/phy-exynos-usb.h | 1 + > > drivers/phy/phy-s5pv210-usb.c | 236 +++++++++++++++++++++++++++++++++++++++++ > > 4 files changed, 254 insertions(+) > > create mode 100644 drivers/phy/phy-s5pv210-usb.c [.....] > > diff --git a/drivers/phy/phy-s5pv210-usb.c b/drivers/phy/phy-s5pv210-usb.c > > new file mode 100644 > > index 0000000..575275d > > --- /dev/null > > +++ b/drivers/phy/phy-s5pv210-usb.c > > how different is this IP different from the previous ones? Does it deserve a > separate driver or the previous drivers can be re-used? [.....] > > +const struct uphy_config s5pv210_uphy_config = { > > + .cpu = TYPE_S5PV210, > > + .num_phys = S5PV210_NUM_PHYS, > > + .phys = s5pv210_phys, > > +}; > > IMO this looks similar to the other drivers. Please re-use the drivers wherever > possible. > +cc Praveen Paneri(Author of Samsung PHY driver), Yulgon Kim, Anton Tikhomirov I agree with Kishon's opinion. Actually, all Exynos USB PHY controllers are not different IPs. However, the differences between Exynos USB PHY controllers are not little. Best regards, Jingoo Han -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html