From: <Andrei.Simion@microchip.com>
To: <krzysztof.kozlowski@linaro.org>,
<krzysztof.kozlowski+dt@linaro.org>, <robh+dt@kernel.org>,
<conor+dt@kernel.org>, <claudiu.beznea@tuxon.dev>,
<lgirdwood@gmail.com>, <broonie@kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH v3] regulator: dt-bindings: microchip,mcp16502: convert to YAML
Date: Thu, 1 Feb 2024 09:02:12 +0000 [thread overview]
Message-ID: <00417e83-ee1f-42f6-a48f-e7f5d9fa374f@microchip.com> (raw)
In-Reply-To: <d2c0c5dd-e1a2-4607-9177-f3855cb5601e@linaro.org>
On 01.02.2024 10:40, Krzysztof Kozlowski wrote:
> [You don't often get email from krzysztof.kozlowski@linaro.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On 31/01/2024 14:07, Andrei Simion wrote:
>> Convert devicetree binding mcp16502-regulator.txt to YAML format.
>>
>> Signed-off-by: Andrei Simion <andrei.simion@microchip.com>
>> ---
>> Changes v2 -> v3:
>> - keep one line of regulators description
>> - add additionalProperties: false for regulators
>> - "description:" at the end for each properties
>>
>> Changes v1 -> v2:
>> - reverse subject prefixes
>> - line break after file "description:"
>> - drop description for reg
>> - drop regulator-name
>> - add regulator-initial-mode
>> - unevaluatedProperties just after $ref: regulator.yaml#
>> - additionalProperties just before "required"
>
> I missed it before, why did you move it? Previous placement was what we
> expect. I did not comment about it.
>
Ah, I will place the "additionalProperties: false" as in my first attempt in v4. Thank you for clarification.
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
>
> ---
>
> This is an automated instruction, just in case, because many review tags
> are being ignored. If you know the process, you can skip it (please do
> not feel offended by me posting it here - no bad intentions intended).
> If you do not know the process, here is a short explanation:
>
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> versions, under or above your Signed-off-by tag. Tag is "received", when
> provided in a message replied to you on the mailing list. Tools like b4
> can help here. However, there's no need to repost patches *only* to add
> the tags. The upstream maintainer will do that for tags received on the
> version they apply.
>
> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
>
> Best regards,
> Krzysztof
>
Best regards,
Andrei Simion
prev parent reply other threads:[~2024-02-01 9:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 13:07 [PATCH v3] regulator: dt-bindings: microchip,mcp16502: convert to YAML Andrei Simion
2024-02-01 8:40 ` Krzysztof Kozlowski
2024-02-01 9:02 ` Andrei.Simion [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00417e83-ee1f-42f6-a48f-e7f5d9fa374f@microchip.com \
--to=andrei.simion@microchip.com \
--cc=broonie@kernel.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).