From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6E0E1B59A for ; Tue, 28 Jan 2025 01:28:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738027739; cv=none; b=Uvpn8YbW2SglWG0A8YPhvtTUZR9BTVVVoT6ngODcuUtlIGHLOZ19p6Y5dsM0FKtd/Cqky8hgn+6suISnfBOvFms7nZzBmFk9HCyPnRuWLzkV6nsbNvaw9tMLlDJ/dQBoG1gm1aVlwaHWSPT13gkcn77ghlBRdF3p2OFena4p8z8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738027739; c=relaxed/simple; bh=VMJ//ZhdKIakDGRD4fQVsxWko+dmrXyV7Md0xi2/MdU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FjraA/dazlUFLb371BMJxg8ed/joPrAsypVqVfOXGBuDLsuq50dCvhgxfz4YzIhP9F/GVSA5s7cwQKOf00N0op2Gm6yIp/aEZSUsN4GKqMpyBhmmAIIWvPjiLI+4sSfD5l7Ju4fgmsBB7LFsh2IDddHuHUJxcnt6pb5Wj1SQ2cU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=ZOONgcZf; arc=none smtp.client-ip=209.85.167.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="ZOONgcZf" Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-3ebadbb14dcso2378394b6e.3 for ; Mon, 27 Jan 2025 17:28:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738027737; x=1738632537; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=08SMuDcYjRA/fEa36MDvgrTUtG8yD3JTS9Dq0JR83M0=; b=ZOONgcZfy/AY2aZ1a/qEKIWLwhi/okJKwAug9wFn7QiP7wCu39Uq7RWSzqQbfbKr4P 9YN5TWW0Lkk756b47C3hbKI3lhesJ30izHrtURsJd2alQJGO+By7IBdejsifansgCPjd wcx14y4L7qGDrqNuqeNw3KWHdfvhyEZEPVZlriJ4E4FUWm71S0Zw9zSnr0kMXeUSLJgT lA8dswNJlmEWVaLSKri4w7UnO8CIiPUboxdPZkun2dpBBV7mKECpdrgB86+9bL+vi9+X UL3IzYZIrbVxkihF+N/LfbJsi/TUGDJLC72W1nYiAQ45eaLH/cQdETVUONX3vzg1su3y TmIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738027737; x=1738632537; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=08SMuDcYjRA/fEa36MDvgrTUtG8yD3JTS9Dq0JR83M0=; b=dt0ltWuo4n5cfWxKOSN4L5ZMXhqYYz5Mw50SvFcW04k349ZffaXE4MvuBWTYj4ZES+ +8fyjtk8x7dhnHS0EGJ2Kz5dn7LGma/vWhxS84/yuf1ho6qPrcBqmYBb5dc8hf8urrZ4 KQ4YMKcMT6DK3lq2VfqyH47nePFBGBaKAUh3NaHYueNoSKm6MVVp8dJmmCgvn+Sozj2s 8G8yR0WcIlrmhw9y8hGflbgSqmCFtykhoOuVJgxpWnCzLvE3wN6NGQcvlLwaSXNTJrVA 1y4yU+VE1lIl4AyWKgO2xvMgqncx5dw3sOQMosvLWH8UOYeX5A45DqLam+P24kS+uEmY zHtw== X-Forwarded-Encrypted: i=1; AJvYcCU7UetfS1OP3zhm/DWsVWg3tOU+EZHJdtmbbxZ9b34P/54y6BMuIApUj7ss/YHQ1+NA/RjStjlnYwwP@vger.kernel.org X-Gm-Message-State: AOJu0Yz1z3JoGnzijLMpoL27u6Q9Dx98Btm4Lx0WF5/HSo+tNLTdUOPh rbfKdpPEnjoeLiDNXOviCSBVBeO+X7RJRtiH0mqVLtmY3ilu/qBa7LJgyJmULSE= X-Gm-Gg: ASbGncujs/1D61QlWWr7DbrJcA56VdnXgXtqQnxVSGuC+Erh16UAa5Vy8WMBY3Sdekc jSI85XTicaCiPGRTd3Btvpo8XLyh880gFCReFHyL/TcI1FuQumz07HwWJZZUjz7WZlaFeASTMed 8p80LXeTmQo6c0oY1g6Xwec3CpO+A53j5CdGlXF0sc0xFAdF1A9/txAtR1H+zeUy+lNvi4mmijW 0+RDubEQe+XZcZl7tdJrrSExC2epoC1E6aCOhNkKCxEmZLdjVhzIqzlsu4pyrsfS3fCsxoMSE8B KfN6B/xamk+dTA7s+jtx335PqKiCwYiCpP7269wdog== X-Google-Smtp-Source: AGHT+IG3JUrxTb1AoGq609NrxgfziYTKUspi+XNC7GFLYp3ofHKCUStTpoa0hxkLnYjImNXy0+o71Q== X-Received: by 2002:a05:6808:228a:b0:3e6:3878:3b9c with SMTP id 5614622812f47-3f19fc4d943mr27361274b6e.8.1738027736676; Mon, 27 Jan 2025 17:28:56 -0800 (PST) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-724ecf98615sm2680304a34.56.2025.01.27.17.28.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jan 2025 17:28:55 -0800 (PST) Message-ID: <0044dd4b-01ce-4ca0-9855-8c239b9bfb6f@baylibre.com> Date: Mon, 27 Jan 2025 19:28:53 -0600 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 02/16] dt-bindings: iio: adc: ad7768-1: add trigger-sources property To: Jonathan Santos , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: lars@metafoo.de, Michael.Hennerich@analog.com, marcelo.schmitt@analog.com, jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, jonath4nns@gmail.com, marcelo.schmitt1@gmail.com References: From: David Lechner Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/27/25 9:11 AM, Jonathan Santos wrote: > Add a new trigger-sources property to enable synchronization across > multiple devices. This property references the main device (or > trigger provider) responsible for generating the pulse to drive the > SYNC_IN of all devices in the setup. > > In addition to GPIO synchronization, The AD7768-1 also supports > synchronization over SPI, which use is recommended when the GPIO > cannot provide a pulse synchronous with the base MCLK signal. It > consists of looping back the SYNC_OUT to the SYNC_IN pin and send > a command via SPI to trigger the synchronization. > > SPI-based synchronization is enabled in the absence of adi,sync-in-gpios > property. Since adi,sync-in-gpios is not long the only method, remove it > from required properties. > > While at it, add description to the interrupt property. > > Signed-off-by: Jonathan Santos > --- > v2 Changes: > * Patch added as replacement for adi,sync-in-spi patch. > * addressed the request for a description to interrupts property. > --- > .../bindings/iio/adc/adi,ad7768-1.yaml | 22 +++++++++++++++++-- > 1 file changed, 20 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml > index 3ce59d4d065f..3e119cf1754b 100644 > --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml > @@ -26,7 +26,17 @@ properties: > clock-names: > const: mclk > > + trigger-sources: > + description: > + References the main device responsible for synchronization. In a single > + device setup, reference the own node. > + maxItems: 1 We probably actually need 2 here. One for /SYNC_IN and one for a GPIO3 pin acting as the /START signal. > + > interrupts: > + description: > + Specifies the interrupt line associated with the ADC. This refers > + to the DRDY (Data Ready) pin, which signals when conversion results are > + available. > maxItems: 1 > > '#address-cells': > @@ -46,6 +56,8 @@ properties: > sampling. A pulse is always required if the configuration is changed > in any way, for example if the filter decimation rate changes. > As the line is active low, it should be marked GPIO_ACTIVE_LOW. > + In the absence of this property, Synchronization over SPI will be > + enabled. Isn't /SYNC_OUT connected to /SYNC_IN required for synchronization over SPI? If yes, instead of adding this text, I would make the binding have: oneOf: - required: - trigger-sources - required: - adi,sync-in-gpios > > reset-gpios: > maxItems: 1 > @@ -57,6 +69,9 @@ properties: > "#io-channel-cells": > const: 1 > > + "#trigger-source-cells": > + const: 0 > + > required: > - compatible > - reg > @@ -65,7 +80,8 @@ required: > - vref-supply > - spi-cpol > - spi-cpha > - - adi,sync-in-gpios > + - trigger-sources > + - #trigger-source-cells > > patternProperties: > "^channel@([0-9]|1[0-5])$": > @@ -99,7 +115,7 @@ examples: > #address-cells = <1>; > #size-cells = <0>; > > - adc@0 { > + adc0: adc@0 { > compatible = "adi,ad7768-1"; > reg = <0>; > spi-max-frequency = <2000000>; > @@ -109,6 +125,8 @@ examples: > interrupts = <25 IRQ_TYPE_EDGE_RISING>; > interrupt-parent = <&gpio>; > adi,sync-in-gpios = <&gpio 22 GPIO_ACTIVE_LOW>; Don't we need to drop adi,sync-in-gpios here? I don't think we would have two things connected to /SYNC_IN at the same time. > + trigger-sources = <&adc0>; > + #trigger-source-cells = <0>; > reset-gpios = <&gpio 27 GPIO_ACTIVE_LOW>; > clocks = <&ad7768_mclk>; > clock-names = "mclk";