From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jingoo Han Subject: Re: [PATCH v8 0/9] Support for creating generic PCI host bridges from DT Date: Fri, 11 Jul 2014 16:33:23 +0900 Message-ID: <004501cf9cda$65703610$3050a230$%han@samsung.com> References: <1404240214-9804-1-git-send-email-Liviu.Dudau@arm.com> <20140708171828.GM6501@e106497-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-reply-to: Content-language: ko Sender: linux-pci-owner@vger.kernel.org To: 'Tanmay Inamdar' , 'Liviu Dudau' Cc: 'Rob Herring' , 'linux-pci' , 'Bjorn Helgaas' , 'Catalin Marinas' , 'Will Deacon' , 'Benjamin Herrenschmidt' , 'Arnd Bergmann' , 'linaro-kernel' , 'Grant Likely' , 'Sinan Kaya' , 'Kukjin Kim' , 'Suravee Suthikulanit' , 'Device Tree ML' , 'LKML' , 'LAKML' , 'Jingoo Han' List-Id: devicetree@vger.kernel.org On Friday, July 11, 2014 9:44 AM, Tanmay Inamdar wrote: > On Tue, Jul 8, 2014 at 10:18 AM, Liviu Dudau wr= ote: > > On Sun, Jul 06, 2014 at 04:23:43PM +0100, Rob Herring wrote: > >> On Tue, Jul 1, 2014 at 1:43 PM, Liviu Dudau = wrote: > >> > This is my resurected attempt at adding support for generic PCI = host > >> > bridge controllers that make use of device tree information to > >> > configure themselves. I've tagged it as v8 although the patches > >> > have now been reshuffled in order to ease adoption so referring = to > >> > the older versions might be a bit of a hoop jumping exercise. > >> > > >> > Changes from v7: > >> > - Reordered the patches so that fixes and non-controversial pa= tches > >> > from v7 can be accepted more easily. If agreed I can split t= he > >> > series again into patches that can be upstreamed easily and = ones > >> > that still need discussion. > >> > - Moved the of_create_host_bridge() function to drivers/of/of_= pci.c > >> > to better reflect its target use. > >> > - Added the function to remap the bus I/O resources that used = to be > >> > provided in my arm64 patch series and (re)named it pci_remap= _iospace() > >> > - Removed error code checking from parsing and mapping of IRQ = from DT > >> > in recognition that some PCI devices will not have legacy IR= Q mappings. > >> > > >> > v7 thread here with all the historic information: https://lkml.o= rg/lkml/2014/3/14/279 > >> > >> Can you publish a branch for this series please. > >> > >> Rob > >> > > > > Hi Rob, > > > > I have pushed a brach that matches my v8 patchset +1 obvious missin= g header include > > here: http://www.linux-arm.org/git?p=3Dlinux-ld.git;a=3Dshortlog;h=3D= refs/heads/for-upstream/pci_v8 > > >=20 > I was still getting following compilation error after applying arm64 > pci headers. Please let me know if I am missing something. >=20 > linux-git/drivers/of/of_pci.c: In function =E2=80=98pci_host_bridge_o= f_get_ranges=E2=80=99: > linux-git/drivers/of/of_pci.c:114:22: error: storage size of =E2=80=98= range=E2=80=99 isn=E2=80=99t known > struct of_pci_range range; > ^ > linux-git/drivers/of/of_pci.c:115:29: error: storage size of =E2=80=98= parser=E2=80=99 > isn=E2=80=99t known > struct of_pci_range_parser parser; > ^ > linux-git/drivers/of/of_pci.c:121:2: error: implicit declaration of > function =E2=80=98of_pci_range_parser_init=E2=80=99 > [-Werror=3Dimplicit-function-declaration] > err =3D of_pci_range_parser_init(&parser, dev); >=20 >=20 > Below patch fixes the errors. >=20 > diff --git a/drivers/of/of_pci.c b/drivers/of/of_pci.c > index 55d8320..da88dac 100644 > --- a/drivers/of/of_pci.c > +++ b/drivers/of/of_pci.c > @@ -2,6 +2,7 @@ > #include > #include > #include > +#include Yes, right. I also found the build errors as above mentioned. "of_address.h" should be included, in order to fix the build errors. However, for readability, the following would be better. #include +#include #include Best regards, Jingoo Han >=20 > static inline int __of_pci_pci_compare(struct device_node *node, > unsigned int data) >=20 >=20 > > Best regards, > > Liviu > > > > > > -- > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > | I would like to | > > | fix the world, | > > | but they're not | > > | giving me the | > > \ source code! / > > --------------- > > =C2=AF\_(=E3=83=84)_/=C2=AF > >