RE: [PATCH 2/5] ARM: S3C64XX: Add phy_type to pmu_isolation

[Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>]

On Tuesday, October 09, 2012 7:51 PM Vivek Gautam wrote
> 
> Hi Kishon,
> 
> Firstly, thanks for the quick review.
> 
> On Tue, Oct 9, 2012 at 11:03 AM, kishon <kishon-l0cyMroinI0@public.gmane.org> wrote:
> > Hi,
> >
> >
> > On Monday 08 October 2012 07:42 PM, Vivek Gautam wrote:
> >>
> >> It adds 'type' argument to pmu_isolation function, aligning
> >> with other platforms, which keeps track of usbphy_type.
> >>
> >> Signed-off-by: Vivek Gautam <gautam.vivek-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> >> ---
> >>   arch/arm/mach-s3c64xx/setup-usb-phy.c |    2 +-
> >>   1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/arch/arm/mach-s3c64xx/setup-usb-phy.c
> >> b/arch/arm/mach-s3c64xx/setup-usb-phy.c
> >> index 3aee778..b7d1d95 100644
> >> --- a/arch/arm/mach-s3c64xx/setup-usb-phy.c
> >> +++ b/arch/arm/mach-s3c64xx/setup-usb-phy.c
> >> @@ -13,7 +13,7 @@
> >>   #include <mach/map.h>
> >>   #include <mach/regs-sys.h>
> >>
> >> -void s5p_usb_phy_pmu_isolation(int on)
> >> +void s5p_usb_phy_pmu_isolation(int on, int type)
> >
> >
> > IMO, this patch should have been squashed with the previous patch. IIUC, you
> > have changed the call to this function for taking two arguments in your
> > previous patch. Wouldn't that introduce compilation break after applying
> > your first patch?
> Yes, that's right it will introduce compilation break, my fault.
> Just one querry, will it be good to put this arch change in [patch 1/5]?
> and then can i move similar change in [patch 3/5] as given below again
> in [patch 1/5]?

In my opinion, it would be better.
This is because it can prevent build errors.


Best regards,
Jingoo Han

> 
> diff --git a/arch/arm/mach-exynos/setup-usb-phy.c
> b/arch/arm/mach-exynos/setup-usb-phy.c
> index 1c62d20..039d246 100644
> --- a/arch/arm/mach-exynos/setup-usb-phy.c
> +++ b/arch/arm/mach-exynos/setup-usb-phy.c
> @@ -222,15 +226,40 @@ int s5p_usb_phy_exit(struct platform_device
> *pdev, int type)
>         return -EINVAL;
>  }
> 
> -void s5p_usb_phy_pmu_isolation(int on)
> +void s5p_usb_phy_pmu_isolation(int on, int type)
> 
> >
> > Thanks
> > Kishon
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> Best regards
> Vivek

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html