From: "Mathieu Olivari" <mathieu@codeaurora.org>
To: 'Paul Bolle' <pebolle@tiscali.nl>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
mturquette@linaro.org, sboyd@codeaurora.org,
peppe.cavallaro@st.com, agross@codeaurora.org,
joshc@codeaurora.org, architt@codeaurora.org,
georgi.djakov@linaro.org, wsa@the-dreams.de,
rnayak@codeaurora.org, davem@davemloft.net,
vbridger@opensource.altera.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
netdev@vger.kernel.org
Subject: RE: [PATCH 4/5] stmmac: add ipq806x glue layer
Date: Wed, 27 May 2015 09:10:16 -0700 [thread overview]
Message-ID: <004d01d09897$a06f8090$e14e81b0$@codeaurora.org> (raw)
In-Reply-To: <1432710218.27695.215.camel@x220>
My bad. This is ISC license. MODULE_LICENSE should actually be "Dual BSD/GPL".
Same license is used in other places in the kernel like drivers/net/wireless/ath/ath10k/pci.c.
I'll post a v2.
Thanks,
Mathieu
-----Original Message-----
From: Paul Bolle [mailto:pebolle@tiscali.nl]
Sent: Wednesday, May 27, 2015 12:04 AM
To: Mathieu Olivari
Cc: robh+dt@kernel.org; pawel.moll@arm.com; mark.rutland@arm.com; ijc+devicetree@hellion.org.uk; galak@codeaurora.org; mturquette@linaro.org; sboyd@codeaurora.org; peppe.cavallaro@st.com; agross@codeaurora.org; joshc@codeaurora.org; architt@codeaurora.org; georgi.djakov@linaro.org; wsa@the-dreams.de; rnayak@codeaurora.org; davem@davemloft.net; vbridger@opensource.altera.com; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-clk@vger.kernel.org; netdev@vger.kernel.org
Subject: Re: [PATCH 4/5] stmmac: add ipq806x glue layer
Just a nit: a license mismatch.
On Tue, 2015-05-26 at 12:27 -0700, Mathieu Olivari wrote:
> --- /dev/null
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c
> + * Permission to use, copy, modify, and/or distribute this software
> + for any
> + * purpose with or without fee is hereby granted, provided that the
> + above
> + * copyright notice and this permission notice appear in all copies.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL
> + WARRANTIES
> + * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
> + * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE
> + LIABLE FOR
> + * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY
> + DAMAGES
> + * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN
> + AN
> + * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING
> + OUT OF
> + * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
I have no idea which license this is.
> +MODULE_LICENSE("GPL");
But I do know that it's not GPL v2 or later (see include/linux/module.h).
Paul Bolle
next prev parent reply other threads:[~2015-05-27 16:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 19:27 [PATCH 0/5] Add support for QCA IPQ806x Ethernet GMAC controller Mathieu Olivari
[not found] ` <1432668437-27763-1-git-send-email-mathieu-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-05-26 19:27 ` [PATCH 1/5] clk: qcom: Add support for NSS/GMAC clocks and resets Mathieu Olivari
2015-05-26 19:27 ` [PATCH 4/5] stmmac: add ipq806x glue layer Mathieu Olivari
2015-05-27 7:03 ` Paul Bolle
2015-05-27 16:10 ` Mathieu Olivari [this message]
2015-05-26 19:27 ` [PATCH 2/5] stmmac: add phy-handle support to the platform layer Mathieu Olivari
2015-05-26 19:27 ` [PATCH 3/5] stmmac: add fixed-link device-tree support Mathieu Olivari
2015-05-26 19:27 ` [PATCH 5/5] net: stmmac: ipq806x: document device tree bindings Mathieu Olivari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004d01d09897$a06f8090$e14e81b0$@codeaurora.org' \
--to=mathieu@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=architt@codeaurora.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=georgi.djakov@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=joshc@codeaurora.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=pebolle@tiscali.nl \
--cc=peppe.cavallaro@st.com \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=vbridger@opensource.altera.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).