From: Kukjin Kim <kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
To: 'Jonathan Cameron'
<jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
'Chanwoo Choi'
<cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: RE: [PATCHv5 0/4] iio: adc: exynos_adc: Support Exynos3250 ADC and code clean
Date: Fri, 18 Jul 2014 14:12:27 +0900 [thread overview]
Message-ID: <005701cfa246$df97ed40$9ec7c7c0$@samsung.com> (raw)
In-Reply-To: <53AFFD69.8060702-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Jonathan Cameron wrote:
>
> On 27/06/14 05:30, Chanwoo Choi wrote:
> > Changes from v4:
> > - Use 'exynos_adc_data' structure instead of 'exynos_adc_ops' structure
> > and remove enum variable of ADC version
> > - Fix wrong name of special clock (sclk_tsadc -> sclk_adc)
> > - Add reviewed message by Naveen Krishna Chatradhi
> > - Add functions for ADC clock control
> >
> > Changes from v3:
> > - Add new 'exynos_adc_ops' structure to improve readability according to
> > Tomasz Figa comment[1]
> > [1] https://lkml.org/lkml/2014/4/16/238
> > - Add new 'exynos3250-adc-v2' compatible string to support Exynos3250 ADC
> > - Fix wrong compaitlbe string of ADC in Exynos3250 dtsi file
> >
> > Changes from v2:
> > - Check return value of clock function to deal with error exception
> > - Fix minor coding style to improve readability
> >
> > Changes from v1:
> > - Add new "samsung,exynos-adc-v3" compatible to support Exynos3250 ADC
> > - Add a patch about DT binding documentation
> >
> > Chanwoo Choi (4):
> > iio: adc: exynos_adc: Add exynos_adc_data structure to improve readability
> > iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 ADC
> > iio: devicetree: Add DT binding documentation for Exynos3250 ADC
> > ARM: dts: Fix wrong compatible string for Exynos3250 ADC
> >
> > .../devicetree/bindings/arm/samsung/exynos-adc.txt | 26 +-
> > arch/arm/boot/dts/exynos3250.dtsi | 4 +-
> > drivers/iio/adc/exynos_adc.c | 326 +++++++++++++++------
> > 3 files changed, 268 insertions(+), 88 deletions(-)
> >
> I am happy with this series, but given it touches some exynos bindings, I would
> like an ack from Kukjin Kim (or according to MAINTAINERS Ben Dooks) before taking it
> all through IIO.
>
Hi,
Sorry for late response...
The change looks good to me, so please go ahead with my ack on exynos stuff.
Acked-by: Kukjin Kim <kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Thanks,
Kukjin
prev parent reply other threads:[~2014-07-18 5:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-27 4:30 [PATCHv5 0/4] iio: adc: exynos_adc: Support Exynos3250 ADC and code clean Chanwoo Choi
2014-06-27 4:30 ` [PATCHv5 1/4] iio: adc: exynos_adc: Add exynos_adc_data structure to improve readability Chanwoo Choi
2014-06-27 4:30 ` [PATCHv5 2/4] iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 ADC Chanwoo Choi
2014-06-27 4:30 ` [PATCHv5 3/4] iio: devicetree: Add DT binding documentation for " Chanwoo Choi
[not found] ` <1403843406-28229-4-git-send-email-cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-06-29 11:37 ` Jonathan Cameron
2014-06-27 4:30 ` [PATCHv5 4/4] ARM: dts: Fix wrong compatible string " Chanwoo Choi
[not found] ` <1403843406-28229-1-git-send-email-cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-06-27 11:26 ` [PATCHv5 0/4] iio: adc: exynos_adc: Support Exynos3250 ADC and code clean Tomasz Figa
[not found] ` <53AD54EC.2050606-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-06-29 23:32 ` Chanwoo Choi
2014-06-29 11:50 ` Jonathan Cameron
2014-06-30 1:51 ` Chanwoo Choi
[not found] ` <53B0C2AB.4030201-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-07-09 7:27 ` Chanwoo Choi
[not found] ` <53AFFD69.8060702-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-07-18 5:12 ` Kukjin Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='005701cfa246$df97ed40$9ec7c7c0$@samsung.com' \
--to=kgene.kim-sze3o3uu22jbdgjk7y7tuq@public.gmane.org \
--cc=ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).