From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jingoo Han Subject: Re: [PATCH V5 1/2] video: exynos_dp: Add device tree support to DP driver Date: Tue, 16 Oct 2012 11:02:53 +0900 Message-ID: <005a01cdab42$5a8ca390$0fa5eab0$%han@samsung.com> References: <1350074859-23226-1-git-send-email-ajaykumar.rs@samsung.com> <50788F25.2040003@gmail.com> <009d01cdaaad$0fa33230$2ee99690$%han@samsung.com> <507C7C9E.1030503@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <507C7C9E.1030503@gmail.com> Content-language: ko Sender: linux-samsung-soc-owner@vger.kernel.org To: 'Sylwester Nawrocki' Cc: 'Florian Tobias Schandinat' , 'Ajay Kumar' , linux-samsung-soc@vger.kernel.org, linux-fbdev@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, 'Tomasz Figa' , 'Thomas Abraham' , 'Jingoo Han' List-Id: devicetree@vger.kernel.org On Tuesday, October 16, 2012 6:14 AM Sylwester Nawrocki wrote > > On 10/15/2012 10:14 AM, Jingoo Han wrote: > > On Saturday, October 13, 2012 6:44 AM Sylwester Nawrocki wrote > >> > >> On 10/12/2012 10:47 PM, Ajay Kumar wrote: > >>> This patch enables device tree based discovery support for DP driver. > >>> The driver is modified to handle platform data in both the cases: > >>> with DT and non-DT. > >>> > >>> Signed-off-by: Ajay Kumar > >>> Acked-by: Jingoo Han > >>> --- > >>> drivers/video/exynos/exynos_dp_core.c | 161 ++++++++++++++++++++++++++++++--- > >>> drivers/video/exynos/exynos_dp_core.h | 2 + > >>> 2 files changed, 149 insertions(+), 14 deletions(-) > ... > >>> @@ -953,8 +1062,13 @@ static int __devexit exynos_dp_remove(struct platform_device *pdev) > >>> struct exynos_dp_platdata *pdata = pdev->dev.platform_data; > >>> struct exynos_dp_device *dp = platform_get_drvdata(pdev); > >> > >> This doesn't belong to your patch, but the above 2 lines could be written as: > >> > >> struct exynos_dp_device *dp = dev_get_drvdata(&pdev->dev); > >> > >> Same in functions exynos_dp_suspend() and exynos_dp_resume(). > > > > No, above 2 lines cannot be reduced to 1 line, as you mentioned. > > This is because it makes build error. > > Sorry, my bad. It looks fine in case of exynos_dp_remove(). > > But at exynos_dp_suspend/resume() there is something like: > > > static int exynos_dp_suspend(struct device *dev) > { > struct platform_device *pdev = to_platform_device(dev); > struct exynos_dp_platdata *pdata = pdev->dev.platform_data; > struct exynos_dp_device *dp = platform_get_drvdata(pdev); > > > You need only pdata and dp there. I think that simpler form would > do as well: > > struct exynos_dp_device *dp = dev_get_drvdata(dev); > struct exynos_dp_platdata *pdata = dev->platform_data; OK, I see. I will accept your suggestion, because it is helpful to reduce lines. Then, I will send v8 patch, soon. > > > Sorry, this is just a nitpicking. > > BTW, shouldn't CONFIG_EXYNOS_VIDEO depend on ARCH_EXYNOS ? > > > -- > Regards, > Sylwester > -- > To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html