From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CD6BEB64DA for ; Wed, 12 Jul 2023 20:36:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232360AbjGLUgm (ORCPT ); Wed, 12 Jul 2023 16:36:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231532AbjGLUgl (ORCPT ); Wed, 12 Jul 2023 16:36:41 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6708B1FF1 for ; Wed, 12 Jul 2023 13:36:39 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-51fe084cf3cso1334867a12.1 for ; Wed, 12 Jul 2023 13:36:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689194198; x=1691786198; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qTIfZiBXGeNx2LL2qDkANMIcRNuFQoGE8jZgmUEj/Bs=; b=y+sINyL0AJvDXbwpXs4l+ZyafLmlSiYHCSuzz3gsyTZQVlTGfA6Lz9uFnL2VFF48vy Vn1iVIMiOM8BeOdr+M51utyIo/cJtoKwpOK1R82IJ58PRdl/MGvHLQZHY2PQG6y/l/kp OKlGDzND4jIND6udhfdWG+W2n8X5RfzOIFCT6BzxfMbRuc9dvIpshRmluKdQkD4yaPhG HRyQDDXpxv5+PwrFqZ1MJ+1SscC82BMk7dqtOIT7XiRWlIVC0ZIfrRN0Pfu0B7WvESCF kiTQ2GW/Z89xvc4X+pKKUL3wYq7h0inozKAd2Gx89lUsRhSsuVAhzgClSdvY7uAyA0Fz OUZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689194198; x=1691786198; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qTIfZiBXGeNx2LL2qDkANMIcRNuFQoGE8jZgmUEj/Bs=; b=O5+LRHh19xuOEqt1wzQ3e9oN/+WVkaJ9CGeFdliHdyIqc6WvKEE+5De0Ik5yXtFH2D iN/6SJZmt4f0yPUAfPfSfMKBJUm5XlXlFcafeGCEz8fHWA7QX3aaALmT7ZdnHbKKoZwh Cib2SiE8tnVpa5Hztvl/+m65IH0WWX7JugXV5cI2NyAVgde68P4P7Cdhc7Ucl1m6Aq1j SQaSfOzf0x3gqfRF9yZZt602v/vmptB4Z+vspMJvYhxv9Xm64AmZKi3MGkP/nG/W+DxS zTQJpIR/y2gbEbUblTj8A0hKkkxNcOp035/mpOFt+pRt8hWOA8oDNRxCe8ZrpP0nx9+s wgJQ== X-Gm-Message-State: ABy/qLYCOGol2HrPgcZD6DCDyNeXtaOAs4FH9pP5r3V2XCB2jf2tNojP Yc3F64Tld+BZ1GpxlbTxJf050A== X-Google-Smtp-Source: APBJJlHhCGGtmxYQDbv6iLN7rNp7N/lmAxjHx0hFv2Tn4xTdwchatR/400eMahUldDdsgzTE8wW+xg== X-Received: by 2002:aa7:cd8b:0:b0:51e:1656:bb24 with SMTP id x11-20020aa7cd8b000000b0051e1656bb24mr15088788edv.26.1689194197823; Wed, 12 Jul 2023 13:36:37 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id j20-20020aa7c0d4000000b0051d9ee1c9d3sm3254199edp.84.2023.07.12.13.36.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jul 2023 13:36:37 -0700 (PDT) Message-ID: <006f9599-6aa4-52ac-068a-831893ec6bf8@linaro.org> Date: Wed, 12 Jul 2023 22:36:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/2] dt-bindings: net: fsl,fec: Add TX clock controls Content-Language: en-US To: =?UTF-8?B?VmVzYSBKw6TDpHNrZWzDpGluZW4=?= Cc: Wei Fang , Shenwei Wang , Clark Wang , NXP Linux Team , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Russell King , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230711150808.18714-1-vesa.jaaskelainen@vaisala.com> <20230711150808.18714-2-vesa.jaaskelainen@vaisala.com> From: Krzysztof Kozlowski In-Reply-To: <20230711150808.18714-2-vesa.jaaskelainen@vaisala.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/07/2023 17:08, Vesa Jääskeläinen wrote: > With fsl,fec-tx-clock-output one can control if TX clock is routed outside > of the chip. > > With fsl,fec-tx-clk-as-ref-clock one can select if external TX clock is as > reference clock. > > Signed-off-by: Vesa Jääskeläinen > --- > .../devicetree/bindings/net/fsl,fec.yaml | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml b/Documentation/devicetree/bindings/net/fsl,fec.yaml > index b494e009326e..c09105878bc6 100644 > --- a/Documentation/devicetree/bindings/net/fsl,fec.yaml > +++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml > @@ -166,6 +166,21 @@ properties: > description: > If present, indicates that the hardware supports waking up via magic packet. > > + fsl,fec-tx-clock-output: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + If present, ENETx_TX_CLK output driver is enabled. > + If not present, ENETx_TX_CLK output driver is disabled. Here... > + > + fsl,fec-tx-clk-as-ref-clock: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + If present, gets ENETx TX reference clk from the ENETx_TX_CLK pin. In > + this use case, an external OSC provides the clock for both the external > + PHY and the internal controller. > + If not present, ENETx TX reference clock is driven by ref_enetpllx. This > + clock is also output to pins via the IOMUX.ENET_REF_CLKx function. and here: In general, Common Clock Framework and its bindings should be used for handling clock providers and consumers. Why it cannot be used for these two cases? Best regards, Krzysztof