[PATCH v2 0/3] amlogic SoC's power-domains fixes

[PATCH v2 0/3] amlogic SoC's power-domains fixes

[George Stark]

Here's some fixes to the bindings and device tree related to Amlogic A1 SoC.
The SoC provides dedicated power domain for for almost all periphery.

Changes in v2:
  dt-bindings: spi: amlogic,a1-spifc: make power-domains required
    - drop the patch
  dt-bindings: thermal: amlogic,thermal: add optional power-domains
    - drop required conditional
    - rewrite commit message
  dt-bindings: i2c: amlogic,meson6-i2c: add optional power-domains
    - add RvB: Neil Armstrong <neil.armstrong@linaro.org>
    - add RvB: Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
  arm64: dts: meson: a1: bind power domain to temperature sensor
    - add RvB: Neil Armstrong <neil.armstrong@linaro.org>
  previous version [1]

[1] https://lore.kernel.org/lkml/20240708194808.1819185-3-gnstark@salutedevices.com/T/#m398c283b369108c5c557e68b7a1ada9abf3e5cba

George Stark (3):
  dt-bindings: i2c: amlogic,meson6-i2c: add optional power-domains
  dt-bindings: thermal: amlogic,thermal: add optional power-domains
  arm64: dts: meson: a1: bind power domain to temperature sensor

 Documentation/devicetree/bindings/i2c/amlogic,meson6-i2c.yaml  | 3 +++
 Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml | 3 +++
 arch/arm64/boot/dts/amlogic/meson-a1.dtsi                      | 1 +
 3 files changed, 7 insertions(+)

--
2.25.1

[PATCH v2 1/3] dt-bindings: i2c: amlogic,meson6-i2c: add optional power-domains

[George Stark]

On newer SoCs, the I2C hardware can require a power domain to operate.
Since the same compatible is used for older and newer SoCs make
power-domains property optional.

Signed-off-by: George Stark <gnstark@salutedevices.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
---
 Documentation/devicetree/bindings/i2c/amlogic,meson6-i2c.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/i2c/amlogic,meson6-i2c.yaml b/Documentation/devicetree/bindings/i2c/amlogic,meson6-i2c.yaml
index 26bed558c6b8..c4cc8af18280 100644
--- a/Documentation/devicetree/bindings/i2c/amlogic,meson6-i2c.yaml
+++ b/Documentation/devicetree/bindings/i2c/amlogic,meson6-i2c.yaml
@@ -30,6 +30,9 @@ properties:
   clocks:
     minItems: 1
 
+  power-domains:
+    maxItems: 1
+
 required:
   - compatible
   - reg
-- 
2.25.1

Re: [PATCH v2 1/3] dt-bindings: i2c: amlogic,meson6-i2c: add optional power-domains

[Andi Shyti]

Hi George,

On Thu, Jul 11, 2024 at 01:32:12AM GMT, George Stark wrote:
> On newer SoCs, the I2C hardware can require a power domain to operate.
> Since the same compatible is used for older and newer SoCs make
> power-domains property optional.
> 
> Signed-off-by: George Stark <gnstark@salutedevices.com>
> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

Just this one pushed to i2c/i2c-host.

Thanks,
Andi

[PATCH v2 2/3] dt-bindings: thermal: amlogic,thermal: add optional power-domains

[George Stark]

On newer SoCs, the thermal hardware can require a power domain to
operate so add corresponding optional property.

Signed-off-by: George Stark <gnstark@salutedevices.com>
---
 Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml b/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml
index 01fccdfc4178..462bd7237bb7 100644
--- a/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml
+++ b/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml
@@ -30,6 +30,9 @@ properties:
   clocks:
     maxItems: 1
 
+  power-domains:
+    maxItems: 1
+
   amlogic,ao-secure:
     description: phandle to the ao-secure syscon
     $ref: /schemas/types.yaml#/definitions/phandle
-- 
2.25.1

Re: [PATCH v2 2/3] dt-bindings: thermal: amlogic,thermal: add optional power-domains

[Krzysztof Kozlowski]

On 11/07/2024 00:32, George Stark wrote:
> On newer SoCs, the thermal hardware can require a power domain to
> operate so add corresponding optional property.
> 
> Signed-off-by: George Stark <gnstark@salutedevices.com>

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

[PATCH v2 3/3] arm64: dts: meson: a1: bind power domain to temperature sensor

[George Stark]

Meson A1 temperature sensor has dedicated power domain so bind it
to the device node.

Signed-off-by: George Stark <gnstark@salutedevices.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
index dd5695963caa..86d77f51c25c 100644
--- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
@@ -919,6 +919,7 @@ cpu_temp: temperature-sensor@4c00 {
 				assigned-clock-rates = <500000>;
 				#thermal-sensor-cells = <0>;
 				amlogic,ao-secure = <&sec_AO>;
+				power-domains = <&pwrc PWRC_I2C_ID>;
 			};
 
 			hwrng: rng@5118 {
-- 
2.25.1

Re: [PATCH v2 0/3] amlogic SoC's power-domains fixes

[George Stark]

Hello

 From this series i2c patch was applied.
Are the thermal sensor's dts and bindings patches ok? Should I do 
anything on it?


On 7/11/24 01:32, George Stark wrote:
> Here's some fixes to the bindings and device tree related to Amlogic A1 SoC.
> The SoC provides dedicated power domain for for almost all periphery.
> 
> Changes in v2:
>    dt-bindings: spi: amlogic,a1-spifc: make power-domains required
>      - drop the patch
>    dt-bindings: thermal: amlogic,thermal: add optional power-domains
>      - drop required conditional
>      - rewrite commit message
>    dt-bindings: i2c: amlogic,meson6-i2c: add optional power-domains
>      - add RvB: Neil Armstrong <neil.armstrong@linaro.org>
>      - add RvB: Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
>    arm64: dts: meson: a1: bind power domain to temperature sensor
>      - add RvB: Neil Armstrong <neil.armstrong@linaro.org>
>    previous version [1]
> 
> [1] https://lore.kernel.org/lkml/20240708194808.1819185-3-gnstark@salutedevices.com/T/#m398c283b369108c5c557e68b7a1ada9abf3e5cba
> 
> George Stark (3):
>    dt-bindings: i2c: amlogic,meson6-i2c: add optional power-domains
>    dt-bindings: thermal: amlogic,thermal: add optional power-domains
>    arm64: dts: meson: a1: bind power domain to temperature sensor
> 
>   Documentation/devicetree/bindings/i2c/amlogic,meson6-i2c.yaml  | 3 +++
>   Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml | 3 +++
>   arch/arm64/boot/dts/amlogic/meson-a1.dtsi                      | 1 +
>   3 files changed, 7 insertions(+)
> 
> --
> 2.25.1
> 

-- 
Best regards
George

Re: [PATCH v2 0/3] amlogic SoC's power-domains fixes

[George Stark]

Hello Neil

Please take a look at this series. It's 2 months already since ack

On 7/11/24 01:32, George Stark wrote:
> Here's some fixes to the bindings and device tree related to Amlogic A1 SoC.
> The SoC provides dedicated power domain for for almost all periphery.
> 
> Changes in v2:
>    dt-bindings: spi: amlogic,a1-spifc: make power-domains required
>      - drop the patch
>    dt-bindings: thermal: amlogic,thermal: add optional power-domains
>      - drop required conditional
>      - rewrite commit message
>    dt-bindings: i2c: amlogic,meson6-i2c: add optional power-domains
>      - add RvB: Neil Armstrong <neil.armstrong@linaro.org>
>      - add RvB: Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
>    arm64: dts: meson: a1: bind power domain to temperature sensor
>      - add RvB: Neil Armstrong <neil.armstrong@linaro.org>
>    previous version [1]
> 
> [1] https://lore.kernel.org/lkml/20240708194808.1819185-3-gnstark@salutedevices.com/T/#m398c283b369108c5c557e68b7a1ada9abf3e5cba
> 
> George Stark (3):
>    dt-bindings: i2c: amlogic,meson6-i2c: add optional power-domains
>    dt-bindings: thermal: amlogic,thermal: add optional power-domains
>    arm64: dts: meson: a1: bind power domain to temperature sensor
> 
>   Documentation/devicetree/bindings/i2c/amlogic,meson6-i2c.yaml  | 3 +++
>   Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml | 3 +++
>   arch/arm64/boot/dts/amlogic/meson-a1.dtsi                      | 1 +
>   3 files changed, 7 insertions(+)
> 
> --
> 2.25.1
> 

-- 
Best regards
George

Re: [PATCH v2 0/3] amlogic SoC's power-domains fixes

[neil.armstrong]

Hi,

On 11/09/2024 23:56, George Stark wrote:
> Hello Neil
> 
> Please take a look at this series. It's 2 months already since ack

I'll take patch 3 after patch 2 is applied on thermal tree.

Daniel could you take patch 2 ?

Thanks,
Neil

> 
> On 7/11/24 01:32, George Stark wrote:
>> Here's some fixes to the bindings and device tree related to Amlogic A1 SoC.
>> The SoC provides dedicated power domain for for almost all periphery.
>>
>> Changes in v2:
>>    dt-bindings: spi: amlogic,a1-spifc: make power-domains required
>>      - drop the patch
>>    dt-bindings: thermal: amlogic,thermal: add optional power-domains
>>      - drop required conditional
>>      - rewrite commit message
>>    dt-bindings: i2c: amlogic,meson6-i2c: add optional power-domains
>>      - add RvB: Neil Armstrong <neil.armstrong@linaro.org>
>>      - add RvB: Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
>>    arm64: dts: meson: a1: bind power domain to temperature sensor
>>      - add RvB: Neil Armstrong <neil.armstrong@linaro.org>
>>    previous version [1]
>>
>> [1] https://lore.kernel.org/lkml/20240708194808.1819185-3-gnstark@salutedevices.com/T/#m398c283b369108c5c557e68b7a1ada9abf3e5cba
>>
>> George Stark (3):
>>    dt-bindings: i2c: amlogic,meson6-i2c: add optional power-domains
>>    dt-bindings: thermal: amlogic,thermal: add optional power-domains
>>    arm64: dts: meson: a1: bind power domain to temperature sensor
>>
>>   Documentation/devicetree/bindings/i2c/amlogic,meson6-i2c.yaml  | 3 +++
>>   Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml | 3 +++
>>   arch/arm64/boot/dts/amlogic/meson-a1.dtsi                      | 1 +
>>   3 files changed, 7 insertions(+)
>>
>> -- 
>> 2.25.1
>>
> 

Re: (subset) [PATCH v2 0/3] amlogic SoC's power-domains fixes

[Neil Armstrong]

Hi,

On Thu, 11 Jul 2024 01:32:11 +0300, George Stark wrote:
> Here's some fixes to the bindings and device tree related to Amlogic A1 SoC.
> The SoC provides dedicated power domain for for almost all periphery.
> 
> Changes in v2:
>   dt-bindings: spi: amlogic,a1-spifc: make power-domains required
>     - drop the patch
>   dt-bindings: thermal: amlogic,thermal: add optional power-domains
>     - drop required conditional
>     - rewrite commit message
>   dt-bindings: i2c: amlogic,meson6-i2c: add optional power-domains
>     - add RvB: Neil Armstrong <neil.armstrong@linaro.org>
>     - add RvB: Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
>   arm64: dts: meson: a1: bind power domain to temperature sensor
>     - add RvB: Neil Armstrong <neil.armstrong@linaro.org>
>   previous version [1]
> 
> [...]

Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v6.13/arm64-dt)

[3/3] arm64: dts: meson: a1: bind power domain to temperature sensor
      https://git.kernel.org/amlogic/c/7e3b4f56a76b233a70db09ddaa5e822f7cddf371

These changes has been applied on the intermediate git tree [1].

The v6.13/arm64-dt branch will then be sent via a formal Pull Request to the Linux SoC maintainers
for inclusion in their intermediate git branches in order to be sent to Linus during
the next merge window, or sooner if it's a set of fixes.

In the cases of fixes, those will be merged in the current release candidate
kernel and as soon they appear on the Linux master branch they will be
backported to the previous Stable and Long-Stable kernels [2].

The intermediate git branches are merged daily in the linux-next tree [3],
people are encouraged testing these pre-release kernels and report issues on the
relevant mailing-lists.

If problems are discovered on those changes, please submit a signed-off-by revert
patch followed by a corrective changeset.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git
[2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
[3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git

-- 
Neil