From: Byungho An <bh74.an@samsung.com>
To: 'Vince Bridgers' <vbridgers2013@gmail.com>
Cc: netdev@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
devicetree@vger.kernel.org, 'David Miller' <davem@davemloft.net>,
'GIRISH K S' <ks.giri@samsung.com>,
'SIVAREDDY KALLAM' <siva.kallam@samsung.com>,
'Vipul Chandrakant' <vipul.pandya@samsung.com>,
'Ilho Lee' <ilho215.lee@samsung.com>,
'Jay Bhat' <j.bhat@samsung.com>
Subject: RE: [PATCH V11 2/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver
Date: Sat, 22 Mar 2014 15:23:41 -0700 [thread overview]
Message-ID: <008901cf461d$63cbf2e0$2b63d8a0$@samsung.com> (raw)
In-Reply-To: <CAOwfj2O=c7YmcxwCLb1EDsu5j=PG7C_5LTrqrcSkpaTOQp-_Yg@mail.gmail.com>
Vince Bridgers <vbridgers2013@gmail.com> :
> On Sat, Mar 22, 2014 at 1:23 AM, Byungho An <bh74.an@samsung.com> wrote:
> > From: Siva Reddy <siva.kallam@samsung.com>
> >
> > This patch adds support for Samsung 10Gb ethernet driver(sxgbe).
> >
[snip]
> > +static int sxgbe_init_rx_buffers(struct net_device *dev,
> > + struct sxgbe_rx_norm_desc *p, int i,
> > + unsigned int dma_buf_sz,
> > + struct sxgbe_rx_queue *rx_ring)
> > +{
> > + struct sxgbe_priv_data *priv = netdev_priv(dev);
> > + struct sk_buff *skb;
> > +
> > + skb = __netdev_alloc_skb(dev, dma_buf_sz, GFP_KERNEL);
> > + if (!skb)
> > + return -ENOMEM;
> > +
> > + skb_reserve(skb, NET_IP_ALIGN);
>
> Considering using netdev_alloc_skb_ip_align here as well. Looks like
> it was changed in refill, but not here
OK. Thanks
> > --
> > To unsubscribe from this list: send the line "unsubscribe netdev" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-03-22 22:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-22 6:23 [PATCH V11 2/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver Byungho An
2014-03-22 11:45 ` Francois Romieu
2014-03-22 21:12 ` Byungho An
2014-03-22 13:29 ` Tomasz Figa
2014-03-22 21:55 ` Byungho An
2014-03-22 21:59 ` Tomasz Figa
2014-03-22 23:15 ` Byungho An
2014-03-22 19:01 ` Vince Bridgers
2014-03-22 20:04 ` Joe Perches
2014-03-23 0:39 ` Byungho An
2014-03-22 19:39 ` Vince Bridgers
2014-03-22 22:23 ` Byungho An [this message]
2014-03-22 19:50 ` Vince Bridgers
2014-03-22 20:07 ` Vince Bridgers
2014-03-23 0:39 ` Byungho An
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='008901cf461d$63cbf2e0$2b63d8a0$@samsung.com' \
--to=bh74.an@samsung.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=ilho215.lee@samsung.com \
--cc=j.bhat@samsung.com \
--cc=ks.giri@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=siva.kallam@samsung.com \
--cc=vbridgers2013@gmail.com \
--cc=vipul.pandya@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).