From: Matthias Brugger <matthias.bgg@gmail.com>
To: Frank Wunderlich <frank-w@public-files.de>,
Krzysztof Kozlowski <krzk@kernel.org>
Cc: Frank Wunderlich <linux@fw-web.de>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Leilk Liu <leilk.liu@mediatek.com>,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, daniel@makrotopia.org,
john@phrozen.org, eladwf@gmail.com, ansuelsmth@gmail.com
Subject: Re: Aw: Re: [PATCH v1] dt-bindings: spi: add compatibles for mt7988
Date: Mon, 7 Oct 2024 16:16:31 +0200 [thread overview]
Message-ID: <00894b3b-a79f-4d6f-bdfb-249535901e00@gmail.com> (raw)
In-Reply-To: <trinity-5ceed296-8a65-4892-b449-6f832a978d69-1728227502700@3c-app-gmx-bs41>
On 06/10/2024 17:11, Frank Wunderlich wrote:
> Hi
>
>> Gesendet: Sonntag, 06. Oktober 2024 um 14:48 Uhr
>> Von: "Krzysztof Kozlowski" <krzk@kernel.org>
>> Betreff: Re: [PATCH v1] dt-bindings: spi: add compatibles for mt7988
>>
>> On Sun, Oct 06, 2024 at 12:27:39PM +0200, Frank Wunderlich wrote:
>>> From: Frank Wunderlich <frank-w@public-files.de>
>>>
>>> MT7988 has 2 different spi controllers. Add mediatek,ipm-spi-single
>>> and mediatek,ipm-spi-quad compatibles.
>>
>> Why generic compatibles?
>>
>> These are supposed to be SoC-specific.
>
> currently i used the compatibles used in SDK, but got info now, that there is some more discussion needed with mtk.
>
Ok, but please don't introduce generic compatibles. We prever SoC specific ones
with a fall-back (to a different SoC specific one).
Regards,
Matthias
prev parent reply other threads:[~2024-10-07 14:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-06 10:27 [PATCH v1] dt-bindings: spi: add compatibles for mt7988 Frank Wunderlich
2024-10-06 12:48 ` Krzysztof Kozlowski
2024-10-06 15:11 ` Aw: " Frank Wunderlich
2024-10-07 14:16 ` Matthias Brugger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00894b3b-a79f-4d6f-bdfb-249535901e00@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ansuelsmth@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel@makrotopia.org \
--cc=devicetree@vger.kernel.org \
--cc=eladwf@gmail.com \
--cc=frank-w@public-files.de \
--cc=john@phrozen.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=leilk.liu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@fw-web.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).