From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6FA92FF171; Fri, 31 Oct 2025 12:07:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761912476; cv=none; b=MtLtLCackhvcY7ItbCi/O6eEmdc/mNbaHXGw3VTlzWrzs3Hhp5JqGrFmuDagbISSjJS+ORu/zonPaLE4DTDVjLfEpEHvL0yI4SnG4T6h2OlCJ2MFPXHgkd/o8N07bT48faVULVol6ZdYU19Oqd1jJ+ojEULC5i6Ohn+1Q6ot+RE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761912476; c=relaxed/simple; bh=FdIPLrzBazADvULcobccxNMUECw5dXroZ8Nui3p0uOg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uyXtxO1WCRvKf+ADAGoEdhOZY+9P7BZzgcTiefxjhOdxDLlT/AFshCTIRErPDgXO5VwfaWxnoabgOIGicxSeJFU7rL++54DlDRawAhhiNq/RmA2AACSF30qHL3GsWkO2a9GszldfoI11cBT399kyhg6FpDCEy4q7ObIitehmjmI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WbVCnwqI; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WbVCnwqI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82C3BC4CEE7; Fri, 31 Oct 2025 12:07:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1761912476; bh=FdIPLrzBazADvULcobccxNMUECw5dXroZ8Nui3p0uOg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=WbVCnwqIONAJBBxEzpEBdg+UMrZQzZhvOZ4ZviB3Mu6Y4i+eQ6B9xiQe/3lSty8J4 4v2tlbV0XOKc8hoUcFvRY0zH+nlhe0Gn56a3S2xJmqnZtqz3zpc3RUmzciUeO7i4ew 1yhd5i8jkJy/roBbcxrL6JVwfAmAPE6Th0uAbAy3o1NCZViv7wLwYNemMurtcjP62m 43Yujj07cqiPXq+VS8D53Xd8uw5farO+6ZQpKkmP2Ggy1faZ6gcSdXee3ttHqiXoP2 aSvNTds4qwjaCpWNGzkIbq03wBCsnbnuatJeesPmF0dkljqLx5Ci+SRHoZsiaioDku ODDwH6TOkpm5Q== Message-ID: <008ce91a-9037-4f18-9639-f1ccda277624@kernel.org> Date: Fri, 31 Oct 2025 13:07:51 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 1/2] dt-bindings: memory: mediatek: Add SMI reset and clamp for MT8188 To: =?UTF-8?B?RnJpZGF5IFlhbmcgKOadqOmYsyk=?= , "robh@kernel.org" , "matthias.bgg@gmail.com" , =?UTF-8?B?WW9uZyBXdSAo5ZC05YuHKQ==?= , "p.zabel@pengutronix.de" , "conor+dt@kernel.org" , AngeloGioacchino Del Regno Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "devicetree@vger.kernel.org" , Project_Global_Chrome_Upstream_Group References: <20250917120724.8650-1-friday.yang@mediatek.com> <20250917120724.8650-2-friday.yang@mediatek.com> <5e3a0317-31b2-43f1-9a4b-b66447a6044d@kernel.org> <1c84112b5a7fa48d8422f531e660aa1b49ec6487.camel@mediatek.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <1c84112b5a7fa48d8422f531e660aa1b49ec6487.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 31/10/2025 07:10, Friday Yang (杨阳) wrote: > On Sat, 2025-10-18 at 18:42 +0200, Krzysztof Kozlowski wrote: >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> >> >> On 17/09/2025 14:07, Friday Yang wrote: >>> Add 'resets' and 'reset-names' properties for SMI LARBs to support >>> SMI reset operations. >> >> Not informative... >> >>> diff --git a/Documentation/devicetree/bindings/memory- >>> controllers/mediatek,smi-larb.yaml >>> b/Documentation/devicetree/bindings/memory- >>> controllers/mediatek,smi-larb.yaml >>> index 2e7fac4b5094..fc5feb2eac1f 100644 >>> --- a/Documentation/devicetree/bindings/memory- >>> controllers/mediatek,smi-larb.yaml >>> +++ b/Documentation/devicetree/bindings/memory- >>> controllers/mediatek,smi-larb.yaml >>> @@ -70,6 +70,12 @@ properties: >>> description: the hardware id of this larb. It's only required >>> when this >>> hardware id is not consecutive from its M4U point of view. >>> >>> + resets: >>> + maxItems: 1 >>> + >>> + reset-names: >>> + const: larb >> >> Is the reset valid for all existing devices as well? Commit msg does >> not >> explain that... it is pretty useless - you say what you did. We see >> that >> from the diff. Explain something not obvious. >> > > Thanks, I could add more descriptions here, like below: > > On the MediaTek MT8188 SoC, bus glitches may occur during MTCMOS > on/off transitions. To prevent these glitches from causing errors, > SMI requires clamp and reset operations. This issue specifically > affects the image, camera, and IPE subsystems. This explains why you need it. But I asked more questions than only "whY". Read the question: "Is the reset valid for all existing devices as well?" Where is the answer for that? I still do not know... Do not reply to only pieces of review. > This change adds the > 'resets' and 'reset-names' properties to the SMI LARBs within > these subsystems to support the necessary reset operations. Read again my message: " it is pretty useless - you say what you did" That's the same, drop. So again you just cared to implement only piece of review. Best regards, Krzysztof