From: Jiebing Chen <jiebing.chen@amlogic.com>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: shuai.li@amlogic.com, devicetree@vger.kernel.org,
Stephen Boyd <sboyd@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
Neil Armstrong <neil.armstrong@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-amlogic@lists.infradead.org, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
linux-kernel@vger.kernel.org, zhe.wang@amlogic.com,
Jerome Brunet <jbrunet@baylibre.com>,
Mark Brown <broonie@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
jian.xu@amlogic.com, Kevin Hilman <khilman@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: Re: [PATCH v4 1/6] dt-bindings: clock: meson: Add audio power domain for s4 soc
Date: Thu, 20 Mar 2025 10:43:30 +0800 [thread overview]
Message-ID: <0096ba23-3433-4f98-92ee-321c3461dff0@amlogic.com> (raw)
In-Reply-To: <174237350819.971004.1098115771430334211.robh@kernel.org>
在 2025/3/19 16:38, Rob Herring (Arm) 写道:
> [ EXTERNAL EMAIL ]
>
> On Wed, 19 Mar 2025 15:04:44 +0800, jiebing chen wrote:
>> Audio power domain found on S4 device.it need to enable before audio work.
>>
>> Signed-off-by: jiebing chen <jiebing.chen@amlogic.com>
>> ---
>> .../bindings/clock/amlogic,axg-audio-clkc.yaml | 20 +++++++++++++++++++-
>> 1 file changed, 19 insertions(+), 1 deletion(-)
>>
> My bot found errors running 'make dt_binding_check' on your patch:
thanks for review, sorry , I missed your previous email, the mail was
accidentally intercepted
pip3 install yamllint
DT_SCHEMA_FILES=Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yaml
DT_CHECKER_FLAGS=-m make W=1 dt_binding_check
we can see these warnings, and fix it in next verison, thanks again
>
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yaml:105:7: [warning] wrong indentation: expected 4 but found 6 (indentation)
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.example.dtb: clock-controller@0: reg: [[0, 0, 0, 180]] is too short
> from schema $id: http://devicetree.org/schemas/clock/amlogic,axg-audio-clkc.yaml#
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250319-audio_drvier-v4-1-686867fad719@amlogic.com
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>
next prev parent reply other threads:[~2025-03-20 2:43 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 7:04 [PATCH v4 0/6] Add support for S4 audio jiebing chen via B4 Relay
2025-03-19 7:04 ` [PATCH v4 1/6] dt-bindings: clock: meson: Add audio power domain for s4 soc jiebing chen via B4 Relay
2025-03-19 8:38 ` Rob Herring (Arm)
2025-03-20 2:43 ` Jiebing Chen [this message]
2025-03-19 7:04 ` [PATCH v4 2/6] dt-bindings: clock: axg-audio: Add mclk and sclk pad clock ids jiebing chen via B4 Relay
2025-03-19 8:22 ` Krzysztof Kozlowski
2025-03-19 10:09 ` Jiebing Chen
2025-03-19 19:31 ` Krzysztof Kozlowski
2025-03-20 2:26 ` Jiebing Chen
2025-03-20 2:29 ` Jiebing Chen
2025-03-19 7:04 ` [PATCH v4 3/6] dt-bindings: Asoc: axg-audio: Add s4 audio tocodec jiebing chen via B4 Relay
2025-03-19 8:23 ` Krzysztof Kozlowski
2025-03-19 7:04 ` [PATCH v4 4/6] ASoC: meson: g12a-toacodec: Add s4 tocodec driver jiebing chen via B4 Relay
2025-03-19 19:02 ` kernel test robot
2025-03-20 8:29 ` kernel test robot
2025-03-20 8:46 ` Jerome Brunet
2025-03-20 8:53 ` Jiebing Chen
2025-03-19 7:04 ` [PATCH v4 5/6] clk: meson: axg-audio: Add the mclk pad div for s4 chip jiebing chen via B4 Relay
2025-03-20 8:42 ` Jerome Brunet
2025-03-20 8:59 ` Jiebing Chen
2025-03-20 10:05 ` kernel test robot
2025-03-19 7:04 ` [PATCH v4 6/6] arm64: dts: amlogic: Add Amlogic S4 Audio jiebing chen via B4 Relay
2025-03-19 8:26 ` Krzysztof Kozlowski
2025-03-19 8:46 ` Jiebing Chen
2025-03-19 8:49 ` Krzysztof Kozlowski
2025-03-19 10:38 ` Jiebing Chen
2025-03-19 19:31 ` Krzysztof Kozlowski
2025-03-20 2:31 ` Jiebing Chen
2025-03-19 23:10 ` [PATCH v4 0/6] Add support for S4 audio Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0096ba23-3433-4f98-92ee-321c3461dff0@amlogic.com \
--to=jiebing.chen@amlogic.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=jian.xu@amlogic.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=shuai.li@amlogic.com \
--cc=tiwai@suse.com \
--cc=zhe.wang@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox