From: Shawn Lin <shawn.lin@rock-chips.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
"James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: shawn.lin@rock-chips.com,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Bart Van Assche <bvanassche@acm.org>,
YiFeng Zhao <zyf@rock-chips.com>, Liang Chen <cl@rock-chips.com>,
linux-scsi@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/3] dt-bindings: ufs: Document Rockchip UFS host controller
Date: Fri, 9 Aug 2024 08:33:56 +0800 [thread overview]
Message-ID: <009a9eb8-ff0f-4d77-8ff9-d54b92be5f0d@rock-chips.com> (raw)
In-Reply-To: <a4f8059f-efe0-4874-8746-24e4cf9b9e89@kernel.org>
Hi Krzysztof
在 2024/8/8 18:34, Krzysztof Kozlowski 写道:
> On 08/08/2024 05:52, Shawn Lin wrote:
>> Document Rockchip UFS host controller for RK3576 SoC.
>>
>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>>
>> ---
>>
>> Changes in v2:
>> - renmae file name
>> - fix all errors and pass the dt_binding_check:
>> make dt_binding_check DT_SCHEMA_FILES=rockchip,rk3576-ufs.yaml
>
>
> You did much more. Some properties appeared which were here not
> before... The way you send patches makes it difficult to review. Look:
>
Yes, will update full changelog next version.
> b4 diff '<1723089163-28983-3-git-send-email-shawn.lin@rock-chips.com>'
> Grabbing thread from
> lore.kernel.org/all/1723089163-28983-3-git-send-email-shawn.lin@rock-chips.com/t.mbox.gz
> Checking for older revisions
> Grabbing search results from lore.kernel.org
> Added from v1: 4 patches
> ---
> Analyzing 18 messages in the thread
> WARNING: duplicate messages found at index 2
> Subject 1: dt-bindings: ufs: Document Rockchip UFS host controller
> Subject 2: dt-bindings: ufs: Document Rockchip UFS host controller
> 2 is not a reply... assume additional patch
> Looking for additional code-review trailers on lore.kernel.org
> Analyzing 0 code-review messages
> Preparing fake-am for v1: Init support for RK3576 UFS controller
> range: e86f0d80765d..3ae8e722f6ab
> Preparing fake-am for v2: scsi: ufs: core: Export
> ufshcd_dme_link_startup() helper
> ERROR: v2 series incomplete; unable to create a fake-am range
> ---
> Could not create fake-am range for upper series v2
>
>
> So how can we handle it? Your job is to use standard process so life of
> reviewers is not more difficult than it should be.
>
> Provide FULL CHANGELOG with explanation what happened here.
Sorry for that. I'll improve them when the dependency is solved.
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2024-08-09 0:35 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 3:52 [PATCH v2 0/3] Init support for RK3576 UFS controller Shawn Lin
2024-08-08 3:52 ` [PATCH v2 2/3] dt-bindings: ufs: Document Rockchip UFS host controller Shawn Lin
2024-08-08 5:29 ` Rob Herring (Arm)
2024-08-08 6:10 ` Shawn Lin
2024-08-08 10:28 ` Krzysztof Kozlowski
2024-08-08 10:34 ` Krzysztof Kozlowski
2024-08-09 0:33 ` Shawn Lin [this message]
2024-08-08 3:52 ` [PATCH v2 3/3] scsi: ufs: rockchip: init support for UFS Shawn Lin
2024-08-08 10:36 ` Krzysztof Kozlowski
2024-08-09 0:53 ` Shawn Lin
2024-08-09 5:44 ` Krzysztof Kozlowski
2024-08-09 6:11 ` Shawn Lin
2024-08-08 10:39 ` Krzysztof Kozlowski
2024-08-09 6:28 ` Manivannan Sadhasivam
2024-08-09 8:16 ` Shawn Lin
2024-08-10 9:28 ` Manivannan Sadhasivam
2024-08-12 1:28 ` Shawn Lin
2024-08-12 4:10 ` Manivannan Sadhasivam
2024-08-12 6:24 ` Shawn Lin
2024-08-12 16:55 ` Manivannan Sadhasivam
2024-08-13 3:52 ` Shawn Lin
2024-08-13 7:22 ` Shawn Lin
2024-08-16 7:52 ` Manivannan Sadhasivam
2024-08-09 19:06 ` Bart Van Assche
2024-08-08 4:27 ` [RESEND PATCH v2 2/3] dt-bindings: ufs: Document Rockchip UFS host controller Shawn Lin
2024-08-08 9:30 ` Rob Herring (Arm)
2024-08-08 10:30 ` Krzysztof Kozlowski
2024-08-08 10:29 ` Krzysztof Kozlowski
[not found] ` <1723089163-28983-2-git-send-email-shawn.lin@rock-chips.com>
2024-08-09 18:27 ` [PATCH v2 1/3] scsi: ufs: core: Export ufshcd_dme_link_startup() helper Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=009a9eb8-ff0f-4d77-8ff9-d54b92be5f0d@rock-chips.com \
--to=shawn.lin@rock-chips.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=cl@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=robh+dt@kernel.org \
--cc=zyf@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).