From: Rohit Agarwal <quic_rohiagar@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<agross@kernel.org>, <andersson@kernel.org>,
<konrad.dybcio@linaro.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>
Cc: <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/3] dt-bindings: power: rpmpd: Remove the SoC specific entries
Date: Thu, 6 Jul 2023 16:33:56 +0530 [thread overview]
Message-ID: <00a04f70-b0d2-2ac8-d03d-93f48c036fed@quicinc.com> (raw)
In-Reply-To: <529beea3-3f36-3837-35c4-1efa25d8f1f2@linaro.org>
On 7/6/2023 4:27 PM, Krzysztof Kozlowski wrote:
> On 06/07/2023 12:53, Rohit Agarwal wrote:
>> On 7/6/2023 4:15 PM, Krzysztof Kozlowski wrote:
>>> On 06/07/2023 11:20, Rohit Agarwal wrote:
>>>> Remove the SoC specific entries and add a generic set of defines
>>>> that can be used by all the SoCs. This will remove the duplicate
>>>> entries among SoCs.
>>>> The arrangement of the defines is done according to the frequency
>>>> used in SoC specific entries in the driver to avoid wastage of
>>>> memory.
>>>>
>>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>>>> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>> Please compile kernel with this commit and tell us what is wrong... Even
>>> if bindings were not an ABI, but they are, this would not work.
>> Do you mean that individually this commit would fail compilation?
>> Yes, we would need all the patches together for compilation to be
>> successful.
> Yeah, it is not bisectable.
>
> Another problem is ABI impact, but I think Konrad covered it.
Yes, Thanks
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-07-06 11:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 9:20 [PATCH 0/3] Refactor the rpmhpd macros Rohit Agarwal
2023-07-06 9:20 ` [PATCH 1/3] dt-bindings: power: rpmpd: Remove the SoC specific entries Rohit Agarwal
2023-07-06 9:59 ` Konrad Dybcio
2023-07-06 10:07 ` Rohit Agarwal
2023-07-06 10:45 ` Krzysztof Kozlowski
2023-07-06 10:53 ` Rohit Agarwal
2023-07-06 10:57 ` Krzysztof Kozlowski
2023-07-06 11:03 ` Rohit Agarwal [this message]
2023-07-06 9:20 ` [PATCH 2/3] soc: qcom: rpmpd: Update the entries of PD macros Rohit Agarwal
2023-07-06 9:20 ` [PATCH 3/3] soc: qcom: rpmphd: " Rohit Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00a04f70-b0d2-2ac8-d03d-93f48c036fed@quicinc.com \
--to=quic_rohiagar@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).