From: "Sricharan" <sricharan@codeaurora.org>
To: 'Rob Herring' <robh@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
iommu@lists.linux-foundation.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, robin.murphy@arm.com,
robdclark@gmail.com, joro@8bytes.org,
srinivas.kandagatla@linaro.org,
laurent.pinchart@ideasonboard.com, Will.Deacon@arm.com,
stepanm@codeaurora.org, treding@nvidia.com
Subject: RE: [PATCH V2 1/5] iommu/msm: Add DT adaptation
Date: Tue, 12 Apr 2016 21:04:28 +0530 [thread overview]
Message-ID: <00a101d194d0$d22edcd0$768c9670$@codeaurora.org> (raw)
In-Reply-To: <20160411134728.GA21468@rob-hp-laptop>
Hi Rob,
> On Wed, Apr 06, 2016 at 07:59:31PM +0530, Sricharan R wrote:
> > The driver currently works based on platform data. Remove this and add
> > support for DT. A single master can have multiple ports connected to
> > more than one iommu.
> >
> > master
> > |
> > |
> > |
> > ------------------------
> > | |
> > IOMMU0 IOMMU1
>
> You've got mixtures of tabs and spaces here. Either fully use leading tabs
or
> use spaces everywhere.
Ok, will change this properly.
>
> > | |
> > ctx0 ctx1 ctx0 ctx1
> >
>
> It is preferred to split bindings to separate patch.
Ok, will split it.
> > +The QCOM IOMMU is an implementation compatible with the ARM VMSA
> > +short descriptor page tables. It provides address translation for bus
> > +masters outside of the CPU, each connected to the IOMMU through a
> port called micro-TLB.
> > +
> > +Required Properties:
> > +
> > + - compatible: Must contain "qcom,iommu-v0".
>
> You need SoC specific compatible strings in addition.
>
Ok, will add it.
Regards,
Sricharan
next prev parent reply other threads:[~2016-04-12 15:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 14:29 [PATCH V2 0/5] iommu/msm: Add DT adaptation and generic bindings support Sricharan R
2016-04-06 14:29 ` [PATCH V2 1/5] iommu/msm: Add DT adaptation Sricharan R
[not found] ` <1459952975-1250-2-git-send-email-sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-04-09 22:38 ` Laurent Pinchart
2016-04-12 15:27 ` Sricharan
2016-04-11 13:47 ` Rob Herring
2016-04-12 15:34 ` Sricharan [this message]
2016-04-06 14:29 ` [PATCH V2 2/5] iommu/msm: Move the contents from msm_iommu_dev.c to msm_iommu.c Sricharan R
2016-04-06 14:29 ` [PATCH V2 3/5] iommu/msm: Add support for generic master bindings Sricharan R
2016-04-06 14:29 ` [PATCH V2 4/5] iommu/msm: use generic ARMV7S short descriptor pagetable ops Sricharan R
2016-04-26 14:17 ` Will Deacon
2016-04-27 5:37 ` Sricharan
2016-04-06 14:29 ` [PATCH V2 5/5] iommu/msm: Remove driver BROKEN Sricharan R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00a101d194d0$d22edcd0$768c9670$@codeaurora.org' \
--to=sricharan@codeaurora.org \
--cc=Will.Deacon@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=stepanm@codeaurora.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).