devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Tomasz Figa' <tomasz.figa@gmail.com>, linux-samsung-soc@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
	devicetree-discuss@lists.ozlabs.org,
	broonie@opensource.wolfsonmicro.com, kwangwoo.lee@gmail.com,
	jacmet@sunsite.dk, augulis.darius@gmail.com,
	mcuelenaere@gmail.com, linux@arm.linux.org.uk
Subject: RE: [RFC PATCH 4/7] ARM: s3c64xx: Fix build error with CONFIG_S3C_DEV_FB disabled
Date: Wed, 09 Jan 2013 16:15:23 -0800	[thread overview]
Message-ID: <00a201cdeec7$99f5d560$cde18020$@samsung.com> (raw)
In-Reply-To: <1357774909-29938-5-git-send-email-tomasz.figa@gmail.com>

Tomasz Figa wrote:
> 
> If there is no board selecting CONFIG_S3C_DEV_FB enabled, build will fail
on
> arch/arm/mach-s3c64xx/pm.c, where s3c_device_fb is referenced.
> 
> This patch adds ifdef guard around the code making it compile only when
> CONFIG_S3C_DEV_FB is enabled.
> 
> Signed-off-by: Tomasz Figa <tomasz.figa@gmail.com>
> ---
>  arch/arm/mach-s3c64xx/pm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-s3c64xx/pm.c b/arch/arm/mach-s3c64xx/pm.c
> index f6b13a2..3686785 100644
> --- a/arch/arm/mach-s3c64xx/pm.c
> +++ b/arch/arm/mach-s3c64xx/pm.c
> @@ -338,10 +338,10 @@ int __init s3c64xx_pm_init(void)
> 
>  	for (i = 0; i < ARRAY_SIZE(s3c64xx_pm_domains); i++)
>  		pm_genpd_init(&s3c64xx_pm_domains[i]->pd, NULL, false);
> -
> +#ifdef CONFIG_S3C_DEV_FB
>  	if (dev_get_platdata(&s3c_device_fb.dev))
>  		pm_genpd_add_device(&s3c64xx_pm_f.pd,
> &s3c_device_fb.dev);
> -
> +#endif
>  	return 0;
>  }
> 
> --
> 1.8.1

This should be separated patch from this series as a fix.

Let me pick this up into -fixes.

Thanks.

- Kukjin

  reply	other threads:[~2013-01-10  0:15 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-09 23:41 [RFC PATCH 0/7] Initial Device Tree support for S3C64xx Tomasz Figa
2013-01-09 23:41 ` [RFC PATCH 1/7] ARM: common: vic: Parse interrupt and resume masks from device tree Tomasz Figa
2013-01-10 11:03   ` Mark Brown
2013-01-10 11:10     ` Tomasz Figa
2013-01-10 11:24       ` Mark Brown
2013-01-09 23:41 ` [RFC PATCH 2/7] ARM: common: vic: Fix invalid first IRQ number in OF-based registration Tomasz Figa
2013-01-09 23:41 ` [RFC PATCH 3/7] ARM: s3c64xx: Add support for OF-based VIC initialization Tomasz Figa
2013-01-10 11:10   ` Mark Brown
2013-01-09 23:41 ` [RFC PATCH 4/7] ARM: s3c64xx: Fix build error with CONFIG_S3C_DEV_FB disabled Tomasz Figa
2013-01-10  0:15   ` Kukjin Kim [this message]
2013-01-10  0:32     ` Tomasz Figa
2013-01-09 23:41 ` [RFC PATCH 5/7] ARM: s3c64xx: Add board file for boot using Device Tree Tomasz Figa
     [not found]   ` <1357774909-29938-6-git-send-email-tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-01-10  0:24     ` Kukjin Kim
2013-01-10  0:38       ` Tomasz Figa
2013-01-10 10:52   ` Mark Brown
2013-01-10 10:55     ` Tomasz Figa
2013-01-09 23:41 ` [RFC PATCH 6/7] ARM: dts: Add basic dts include files for Samsung S3C64xx SoCs Tomasz Figa
2013-01-09 23:41 ` [RFC PATCH 7/7] ARM: dts: Add dts file for S3C6410-based Mini6410 board Tomasz Figa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='00a201cdeec7$99f5d560$cde18020$@samsung.com' \
    --to=kgene.kim@samsung.com \
    --cc=augulis.darius@gmail.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=jacmet@sunsite.dk \
    --cc=kwangwoo.lee@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mcuelenaere@gmail.com \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).