From: <ansuelsmth@gmail.com>
To: "'Bjorn Andersson'" <bjorn.andersson@linaro.org>
Cc: <agross@kernel.org>, "'Rob Herring'" <robh+dt@kernel.org>,
"'Mark Rutland'" <mark.rutland@arm.com>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: R: [PATCH 1/2] firmware: qcom_scm: add ipq806x with no clock
Date: Thu, 12 Mar 2020 10:25:26 +0100 [thread overview]
Message-ID: <00aa01d5f850$2b6ddcb0$82499610$@gmail.com> (raw)
In-Reply-To: <20200312054649.GG1098305@builder>
> On Wed 11 Mar 06:09 PDT 2020, Ansuel Smith wrote:
>
> > ipq806x rpm definition was missing for a long time.
> > Add this to make this soc support rpm.
> >
>
> I merged the dt-binding patch, but please update dts to use:
> compatible = "qcom,scm-ipq806x", "qcom,scm";
>
> instead of adding the platform specific compatible in the driver.
>
> Regards,
> Bjorn
>
Should I drop the added compatible in qcom_scm.c or just
keep it and add the definition in the ipq806x dts?
> > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> > ---
> > drivers/firmware/qcom_scm.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/firmware/qcom_scm.c
> b/drivers/firmware/qcom_scm.c
> > index 059bb0fbae9e..d13ef3cd8cf5 100644
> > --- a/drivers/firmware/qcom_scm.c
> > +++ b/drivers/firmware/qcom_scm.c
> > @@ -1144,6 +1144,7 @@ static const struct of_device_id
> qcom_scm_dt_match[] = {
> >
> SCM_HAS_BUS_CLK)
> > },
> > { .compatible = "qcom,scm-ipq4019" },
> > + { .compatible = "qcom,scm-ipq806x" },
> > { .compatible = "qcom,scm-msm8660", .data = (void *)
> SCM_HAS_CORE_CLK },
> > { .compatible = "qcom,scm-msm8960", .data = (void *)
> SCM_HAS_CORE_CLK },
> > { .compatible = "qcom,scm-msm8916", .data = (void
> *)(SCM_HAS_CORE_CLK |
> > --
> > 2.25.0
> >
prev parent reply other threads:[~2020-03-12 9:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 13:09 [PATCH 1/2] firmware: qcom_scm: add ipq806x with no clock Ansuel Smith
2020-03-11 13:09 ` [PATCH 2/2] devicetree: bindings: firmware: add ipq806x to qcom_scm Ansuel Smith
2020-03-12 5:46 ` [PATCH 1/2] firmware: qcom_scm: add ipq806x with no clock Bjorn Andersson
2020-03-12 9:25 ` ansuelsmth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00aa01d5f850$2b6ddcb0$82499610$@gmail.com' \
--to=ansuelsmth@gmail.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).