From: "Adrian Schmutzler" <mail@adrianschmutzler.de>
To: "'Rob Herring'" <robh+dt@kernel.org>,
"'Pavel Machek'" <pavel@ucw.cz>, "'Dan Murphy'" <dmurphy@ti.com>,
"'Linus Walleij'" <linus.walleij@linaro.org>,
<devicetree@vger.kernel.org>
Subject: RE: [PATCH v2 1/2] dt-bindings: leds: add LED_FUNCTION for wlan2g/wlan5g
Date: Sat, 19 Sep 2020 23:45:18 +0200 [thread overview]
Message-ID: <00b701d68ece$2b237700$816a6500$@adrianschmutzler.de> (raw)
In-Reply-To: <20200919172733.57217-1-freifunk@adrianschmutzler.de>
[-- Attachment #1: Type: text/plain, Size: 1887 bytes --]
> -----Original Message-----
> From: Adrian Schmutzler [mailto:freifunk@adrianschmutzler.de]
> Sent: Samstag, 19. September 2020 19:28
> To: Rob Herring <robh+dt@kernel.org>; Pavel Machek <pavel@ucw.cz>; Dan
> Murphy <dmurphy@ti.com>; Linus Walleij <linus.walleij@linaro.org>;
> devicetree@vger.kernel.org; Adrian Schmutzler
> <freifunk@adrianschmutzler.de>
> Subject: [PATCH v2 1/2] dt-bindings: leds: add LED_FUNCTION for
> wlan2g/wlan5g
>
> Many consumer "routers" have dedicated LEDs for specific WiFi bands, e.g.
> one for 2.4 GHz and one for 5 GHz. These LEDs specifically indicate the state
> of the relevant band, so the latter should be included in the function name.
> LED_FUNCTION_WLAN will remain for general cases or when the LED is used
> for more than one band.
>
> This essentially is equivalent to how we use LED_FUNCTION_LAN and
> LED_FUNCTION_WAN instead of just having LED_FUNCTION_ETHERNET.
I only just became aware of the linux-leds@vger.kernel.org mailing list, and resubmitted there.
Sorry for the noise. Maybe get_maintainers.sh should be updated for this file.
Best
Adrian
>
> Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
>
> ---
>
> Changes in v2:
> - Without typo this time. Sorry.
> ---
> include/dt-bindings/leds/common.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/dt-bindings/leds/common.h b/include/dt-
> bindings/leds/common.h
> index 52b619d44ba2..debbd406ff17 100644
> --- a/include/dt-bindings/leds/common.h
> +++ b/include/dt-bindings/leds/common.h
> @@ -89,6 +89,8 @@
> #define LED_FUNCTION_USB "usb"
> #define LED_FUNCTION_WAN "wan"
> #define LED_FUNCTION_WLAN "wlan"
> +#define LED_FUNCTION_WLAN2G "wlan2g"
> +#define LED_FUNCTION_WLAN5G "wlan5g"
> #define LED_FUNCTION_WPS "wps"
>
> #endif /* __DT_BINDINGS_LEDS_H */
> --
> 2.20.1
[-- Attachment #2: openpgp-digital-signature.asc --]
[-- Type: application/pgp-signature, Size: 834 bytes --]
next prev parent reply other threads:[~2020-09-19 21:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-19 17:27 [PATCH v2 1/2] dt-bindings: leds: add LED_FUNCTION for wlan2g/wlan5g Adrian Schmutzler
2020-09-19 17:27 ` [PATCH v2 2/2] dt-bindings: leds: add LED_FUNCTION_RSSI Adrian Schmutzler
2020-09-19 21:45 ` Adrian Schmutzler [this message]
2020-09-23 21:04 ` [PATCH v2 1/2] dt-bindings: leds: add LED_FUNCTION for wlan2g/wlan5g Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00b701d68ece$2b237700$816a6500$@adrianschmutzler.de' \
--to=mail@adrianschmutzler.de \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=linus.walleij@linaro.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).