From: "Chanho Park" <chanho61.park@samsung.com>
To: "'Chanwoo Choi'" <cwchoi00@gmail.com>,
"'Sylwester Nawrocki'" <s.nawrocki@samsung.com>,
"'Tomasz Figa'" <tomasz.figa@gmail.com>,
"'Chanwoo Choi'" <cw00.choi@samsung.com>,
"'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
"'Stephen Boyd'" <sboyd@kernel.org>,
"'Michael Turquette'" <mturquette@baylibre.com>,
"'Rob Herring'" <robh+dt@kernel.org>,
"'Krzysztof Kozlowski'" <krzysztof.kozlowski+dt@linaro.org>
Cc: "'Sam Protsenko'" <semen.protsenko@linaro.org>,
"'Alim Akhtar'" <alim.akhtar@samsung.com>,
<linux-samsung-soc@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-clk@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH 2/6] dt-bindings: clock: exynosautov9: add fsys1 clock definitions
Date: Wed, 27 Jul 2022 16:53:51 +0900 [thread overview]
Message-ID: <00ba01d8a18e$0345be80$09d13b80$@samsung.com> (raw)
In-Reply-To: <7aac0100-5f45-4586-b13e-df0f8bd95060@gmail.com>
> Subject: Re: [PATCH 2/6] dt-bindings: clock: exynosautov9: add fsys1 clock
> definitions
>
> On 22. 7. 27. 15:01, Chanho Park wrote:
> > Add fsys1(for usb and mmc) clock definitions.
> >
> > Signed-off-by: Chanho Park <chanho61.park@samsung.com>
> > ---
> > .../dt-bindings/clock/samsung,exynosautov9.h | 25 +++++++++++++++++++
> > 1 file changed, 25 insertions(+)
> >
> > diff --git a/include/dt-bindings/clock/samsung,exynosautov9.h
> b/include/dt-bindings/clock/samsung,exynosautov9.h
> > index 6305a84396ce..7e11e681da5c 100644
> > --- a/include/dt-bindings/clock/samsung,exynosautov9.h
> > +++ b/include/dt-bindings/clock/samsung,exynosautov9.h
> > @@ -228,6 +228,31 @@
> >
> > #define FSYS0_NR_CLK 37
> >
> > +/* CMU_FSYS1 */
> > +#define FOUT_MMC_PLL 1
> > +
> > +#define CLK_MOUT_FSYS1_BUS_USER 2
> > +#define CLK_MOUT_MMC_PLL 3
>
> nitpik. This clock id doesn't have 'FSYS1' word. Is it right?
Nice catch. I copied it from the SoC User manual but it should have the FSYS1 prefix because it's definitely included in the FSYS1 cmu block
I'll update it next patchset.
Best Regards,
Chanho Park
next prev parent reply other threads:[~2022-07-27 7:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220727060612epcas2p1e3631dbc4775de76cd62554a20bae716@epcas2p1.samsung.com>
2022-07-27 6:01 ` [PATCH 0/6] fsys0/1 clock support for Exynos Auto v9 SoC Chanho Park
[not found] ` <CGME20220727060612epcas2p355e7f9ca3700cad4778e944cbdbf2d50@epcas2p3.samsung.com>
2022-07-27 6:01 ` [PATCH 1/6] dt-bindings: clk: exynosautov9: add fys0 clock definitions Chanho Park
2022-07-27 7:39 ` Chanwoo Choi
2022-07-28 8:17 ` Krzysztof Kozlowski
[not found] ` <CGME20220727060612epcas2p34e861279ece7fbd3c7c87ce02c7d795c@epcas2p3.samsung.com>
2022-07-27 6:01 ` [PATCH 2/6] dt-bindings: clock: exynosautov9: add fsys1 " Chanho Park
2022-07-27 7:38 ` Chanwoo Choi
2022-07-27 7:53 ` Chanho Park [this message]
[not found] ` <CGME20220727060612epcas2p4b844ea92fe11c302337a320b222947d3@epcas2p4.samsung.com>
2022-07-27 6:01 ` [PATCH 3/6] dt-bindings: clock: exynosautov9: add schema for cmu_fsys0/1 Chanho Park
2022-07-27 7:39 ` Chanwoo Choi
2022-07-28 8:18 ` Krzysztof Kozlowski
[not found] ` <CGME20220727060612epcas2p3fa8d9a1e8ab3db929b3518ac8aca770c@epcas2p3.samsung.com>
2022-07-27 6:01 ` [PATCH 4/6] arm64: dts: exynosautov9: add fsys0/1 clock DT nodes Chanho Park
2022-07-27 7:40 ` Chanwoo Choi
[not found] ` <CGME20220727060612epcas2p1e79b8d8bfb9e8a3ea351c4dbd7c42b7d@epcas2p1.samsung.com>
2022-07-27 6:01 ` [PATCH 5/6] clk: samsung: exynosautov9: add fsys0 clock support Chanho Park
2022-07-27 7:44 ` Chanwoo Choi
2022-07-28 8:19 ` Krzysztof Kozlowski
[not found] ` <CGME20220727060612epcas2p47e21a2545b686d536de47518f7b5c199@epcas2p4.samsung.com>
2022-07-27 6:01 ` [PATCH 6/6] clk: samsung: exynosautov9: add fsys1 " Chanho Park
2022-07-27 7:44 ` Chanwoo Choi
2022-07-28 8:20 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00ba01d8a18e$0345be80$09d13b80$@samsung.com' \
--to=chanho61.park@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=cwchoi00@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).