From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 310C7C46467 for ; Sun, 27 Nov 2022 20:58:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229690AbiK0U61 (ORCPT ); Sun, 27 Nov 2022 15:58:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229664AbiK0U60 (ORCPT ); Sun, 27 Nov 2022 15:58:26 -0500 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 210B4F76 for ; Sun, 27 Nov 2022 12:58:25 -0800 (PST) Received: by mail-lj1-x235.google.com with SMTP id z4so11070148ljq.6 for ; Sun, 27 Nov 2022 12:58:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=y0DuQsNLT0RY6V02XnWfmVJTL0d/Zc+EKxzoplKAPRg=; b=cWTmZztQXVYg/pGFJwKQrIUs9ASsk1f86dyJ6BV6j9A9XNSYJkoTUJihtLQAxxRPh4 S0GnfVSi8NkiSNJKZoFWgLu0ALu2gO7K4dd0I6ouEmc14PPrJdewmFvK7qfJHsUHM3MF bmtvIW0ZPTKrmhMsdlxxteltgm/s3KXePOhwpBwELndHDOSCpcW14A3rCj/VZB5/X8xP ogJHRszafv+YN0tpqehqE+NiIUkLCTgys8RE0HG+7o/4RHg6ekANvcjPzCvVFZktrRFX ZQGZ3hOShGb/LGWR6YZ5jhU76nSjWic8CmyK3rBtUU1sFJwS6rScaTVhJScrI1pfY6xx 98ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=y0DuQsNLT0RY6V02XnWfmVJTL0d/Zc+EKxzoplKAPRg=; b=tOWkdppiX/uLdO0ksLh2NiFfQzwChJ67wIUv4mRzVq97cP8ZkjrhL/6KbM9mmOKt2T 16oeWNgvoArjFvLbepMPqh9OR1Zw0rjvMCVc64CHSGerJ0TPabdmFLVBTPKLlpippyyF ZKkHrK1mExWPQEV1yrqTXgm8njsxwAybnLtTS5R1DjLv00w4vVl0gL3xbh8vtHANGRY9 YwlqDv0NmUH3UG9bri3yz3gvM6RAAWTvRrDsX3BQRKLqQXvlbfyCPsQQw9JG+cz/0t2B Fm/GxNRak83TAI95qdisF464iVWSNhkPLO3uF+flrMNkK4Sl11pcqBRxmYjlKlaZhT1c HHsw== X-Gm-Message-State: ANoB5pl4Dq2Urrragg1Z9hL7Oztlq3FLjfRBACwN1jAkR752iZ3k7R0w Kgm2XnpncBDwMxaG1XJhcYsYJw== X-Google-Smtp-Source: AA0mqf7DSbp7zd1DjzQpiy8x4qXr0QOwLtJh8XqXRY3opc8q48qUhIu5CXz2s3UXoaXUh3DG0POO9Q== X-Received: by 2002:a2e:bcc5:0:b0:279:3851:1420 with SMTP id z5-20020a2ebcc5000000b0027938511420mr12784992ljp.265.1669582703489; Sun, 27 Nov 2022 12:58:23 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id w10-20020ac25d4a000000b004a8f824466bsm1410359lfd.188.2022.11.27.12.58.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Nov 2022 12:58:23 -0800 (PST) Message-ID: <00cc31a2-39b1-9bb3-5b79-3c6d51cd5d51@linaro.org> Date: Sun, 27 Nov 2022 21:58:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v6 3/7] dt-bindings: drm/bridge: anx7625: Add mode-switch support Content-Language: en-US To: Pin-yen Lin , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J . Wysocki" , Prashant Malani , Benson Leung , Guenter Roeck Cc: Javier Martinez Canillas , Stephen Boyd , dri-devel@lists.freedesktop.org, Hsin-Yi Wang , Thomas Zimmermann , devicetree@vger.kernel.org, chrome-platform@lists.linux.dev, linux-acpi@vger.kernel.org, Marek Vasut , Xin Ji , Lyude Paul , =?UTF-8?Q?N=c3=adcolas_F_=2e_R_=2e_A_=2e_Prado?= , AngeloGioacchino Del Regno , linux-kernel@vger.kernel.org, Allen Chen References: <20221124102056.393220-1-treapking@chromium.org> <20221124102056.393220-4-treapking@chromium.org> From: Krzysztof Kozlowski In-Reply-To: <20221124102056.393220-4-treapking@chromium.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 24/11/2022 11:20, Pin-yen Lin wrote: > Analogix 7625 can be used in systems to switch the DP traffic between > two downstreams, which can be USB Type-C DisplayPort alternate mode > lane or regular DisplayPort output ports. > > Update the binding to accommodate this usage by introducing a > data-lanes and a mode-switch property on endpoints. > > Also include the link to the product brief in the bindings. > > Signed-off-by: Pin-yen Lin > > --- > > Changes in v6: > - Remove switches node and use endpoints and data-lanes property to > describe the connections. Except missing testing few things... > > .../display/bridge/analogix,anx7625.yaml | 73 ++++++++++++++++++- > 1 file changed, 71 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > index 4590186c4a0b..5fdbf1f3bab8 100644 > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > @@ -12,7 +12,8 @@ maintainers: > > description: | > The ANX7625 is an ultra-low power 4K Mobile HD Transmitter > - designed for portable devices. > + designed for portable devices. Product brief is available at > + https://www.analogix.com/en/system/files/AA-002291-PB-6-ANX7625_ProductBrief.pdf > > properties: > compatible: > @@ -112,10 +113,36 @@ properties: > data-lanes: true > > port@1: > - $ref: /schemas/graph.yaml#/properties/port > + $ref: /schemas/graph.yaml#/properties/port-base I don't understand why you are changing this line. > description: > Video port for panel or connector. > > + patternProperties: > + "^endpoint@[01]$": > + $ref: /schemas/media/video-interfaces.yaml# > + type: object > + unevaluatedProperties: false > + > + properties: > + reg: > + maxItems: 1 > + > + remote-endpoint: true > + > + data-lanes: > + minItems: 1 > + uniqueItems: true These are confusing... you allow only one item, so why minItems and uniqueItems? > + items: > + - enum: [ 0, 1, 2, 3] > + > + mode-switch: > + type: boolean > + description: Register this node as a Type-C mode switch or not. > + > + required: > + - reg > + - remote-endpoint > + > required: > - port@0 > - port@1 > @@ -186,3 +213,45 @@ examples: > }; > }; > }; > + - | > + &i2c3 { > + anx_bridge_dp: anx7625-dp@58 { Messed up indentation. > + compatible = "analogix,anx7625 Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation "; > + reg = <0x58>; Best regards, Krzysztof