From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jon Hunter <jonathanh@nvidia.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>
Cc: Wayne Chang <waynec@nvidia.com>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH V4 1/5] dt-bindings: usb: Add binding for Cypress cypd4226 I2C driver
Date: Tue, 17 Jan 2023 18:40:52 +0100 [thread overview]
Message-ID: <00d0e406-034f-d634-4475-a6c84a4928ac@linaro.org> (raw)
In-Reply-To: <dbb0cc82-4b15-b99c-bfbe-0f6af8f2e8dc@nvidia.com>
On 17/01/2023 18:16, Jon Hunter wrote:
>
> On 16/01/2023 19:03, Krzysztof Kozlowski wrote:
>> On 16/01/2023 16:50, Jon Hunter wrote:
>>> From: Wayne Chang <waynec@nvidia.com>
>>>
>>> add device-tree binding documentation for Cypress cypd4226 type-C
>>> controller's I2C interface. It is a standard i2c slave with GPIO
>>> input as IRQ interface.
>>>
>>> Signed-off-by: Wayne Chang <waynec@nvidia.com>
>>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
>>> ---
>>> V3 -> V4: no changes
>>> V2 -> V3: fix additionalProperties warning on new schema
>>> V1 -> V2: based on the review comments. Fix some addressed issues on
>>>
>>> .../bindings/usb/cypress,cypd4226.yaml | 86 +++++++++++++++++++
>>> 1 file changed, 86 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml b/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml
>>> new file mode 100644
>>> index 000000000000..5ac28ab4e7a1
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml
>>> @@ -0,0 +1,86 @@
>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/usb/cypress,cypd4226.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Cypress cypd4226 UCSI I2C Type-C Controller
>>> +
>>> +maintainers:
>>> + - Wayne Chang <waynec@nvidia.com>
>>> +
>>> +description: |
>>> + The Cypress cypd4226 UCSI I2C type-C controller is a I2C interface type-C
>>> + controller.
>>> +
>>> +properties:
>>> + compatible:
>>> + const: cypress,cypd4226
>>> +
>>> + '#address-cells':
>>> + const: 1
>>> +
>>> + '#size-cells':
>>> + const: 0
>>> +
>>> + reg:
>>> + const: 0x08
>>> +
>>> + interrupts:
>>> + maxItems: 1
>>> +
>>> + cypress,firmware-build:
>>> + enum:
>>> + - nv
>>> + - gn
>>> + description: |
>>> + the name of the CCGx firmware built for product series.
>>> + should be set one of following:
>>> + - "nv" for the RTX product series
>>> + - "gn" for the Jetson product series
>>
>> This is a friendly reminder during the review process.
>>
>> It seems my previous comments were not fully addressed. Maybe my
>> feedback got lost between the quotes, maybe you just forgot to apply it.
>> Please go back to the previous discussion and either implement all
>> requested changes or keep discussing them.
>
>
> Thanks. Apologies for this. I will sort this out in the next revision.
These could have been comments from Rob about this property.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-17 17:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 15:50 [PATCH V4 0/5] Add device-tree support for Cypress CYP4226 Jon Hunter
2023-01-16 15:50 ` [PATCH V4 1/5] dt-bindings: usb: Add binding for Cypress cypd4226 I2C driver Jon Hunter
2023-01-16 19:03 ` Krzysztof Kozlowski
2023-01-17 17:16 ` Jon Hunter
2023-01-17 17:40 ` Krzysztof Kozlowski [this message]
2023-01-16 15:50 ` [PATCH V4 2/5] usb: typec: ucsi_ccg: Add OF support Jon Hunter
2023-01-16 15:50 ` [PATCH V4 3/5] usb: typec: ucsi_ccg: Replace ccgx to well-known regex Jon Hunter
2023-01-17 12:02 ` Heikki Krogerus
2023-01-17 17:17 ` Jon Hunter
2023-01-17 23:29 ` Jon Hunter
2023-01-18 9:13 ` Heikki Krogerus
2023-01-19 10:45 ` Jon Hunter
2023-01-20 7:19 ` Goswami, Sanket
2023-01-16 15:50 ` [PATCH V4 4/5] i2c: nvidia-gpu: " Jon Hunter
2023-01-17 12:06 ` Heikki Krogerus
2023-01-16 15:50 ` [PATCH V4 5/5] arm64: tegra: Populate USB Type-C Controller for Jetson AGX Orin Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00d0e406-034f-d634-4475-a6c84a4928ac@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=waynec@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).