From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Ayush Singh <ayushdevel1325@gmail.com>, greybus-dev@lists.linaro.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org, vaishnav@beagleboard.org,
jkridner@beagleboard.org, nm@ti.com,
krzysztof.kozlowski+dt@linaro.org, vigneshr@ti.com,
kristo@kernel.org, robh+dt@kernel.org, conor+dt@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 1/3] dt-bindings: net: Add ti,cc1352p7
Date: Thu, 5 Oct 2023 10:37:50 +0200 [thread overview]
Message-ID: <00e6e500-bf34-44fd-8f6c-f93bed1b1892@linaro.org> (raw)
In-Reply-To: <aa63918f-3a95-5e86-d61d-91a59cf643ad@gmail.com>
On 05/10/2023 10:21, Ayush Singh wrote:
>>> + clocks:
>>> + maxItems: 2
>>> +
>>> + clock-names:
>>> + description:
>>> + sclk_hf is the main system (mcu and peripherals) clock
>>> + sclk_lf is low-frequency system clock
>> This does no go here, but to clocks. I wrote how it should be done.
>> Don't ignore the feedback.
> It was suggested to use `clock-names` by Nishanth Menon in the previous
> email, so I thought this was what it meant. I will remove clock-names if
> that's better.
clock-names could stay, but this description belongs to "clocks:" how I
wrote last time.
>>> + items:
>>> + - const: sclk_hf
>>> + - const: sclk_lf
>>> +
>>> + reset-gpios: true
>>
>> No, really, why do you change correct code into incorrect one? Who asked
>> you to drop maxItems?
> I found that many bindings (`display/ilitek,ili9486.yaml`,
Panels are constrained by panel-common.
> `iio/dac/adi,ad5758.yaml`) use this pattern instead of `maxItems` for
This I fixed now.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-10-05 8:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 18:46 [PATCH v7 0/3] greybus: Add BeaglePlay Greybus Driver Ayush Singh
2023-10-04 18:46 ` [PATCH v7 1/3] dt-bindings: net: Add ti,cc1352p7 Ayush Singh
2023-10-05 8:01 ` Krzysztof Kozlowski
2023-10-05 8:21 ` Ayush Singh
2023-10-05 8:37 ` Krzysztof Kozlowski [this message]
2023-10-05 11:19 ` Nishanth Menon
2023-10-04 18:46 ` [PATCH v7 2/3] greybus: Add BeaglePlay Linux Driver Ayush Singh
2023-10-05 9:08 ` Greg KH
2023-10-05 9:48 ` Ayush Singh
2023-10-05 10:39 ` Greg KH
2023-10-04 18:46 ` [PATCH v7 3/3] dts: ti: k3-am625-beagleplay: Add beaglecc1352 Ayush Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00e6e500-bf34-44fd-8f6c-f93bed1b1892@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=ayushdevel1325@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=jkridner@beagleboard.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=vaishnav@beagleboard.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).