Re: [PATCH v3 3/4] drm/panel-edp: Add eDP sharp panel support

[Dmitry Baryshkov <dmitry.baryshkov@linaro.org>]

On 09/02/2022 11:55, Sankeerth Billakanti wrote:
> Add support for the 14" sharp,lq140m1jw46 eDP panel.
> 
> Signed-off-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com>

Please excuse my ignorance, is there any reason, why we can't use 
generic panel-edp here?

> ---
> 
> Changes in v3:
>    None
> 
>   drivers/gpu/drm/panel/panel-edp.c | 31 +++++++++++++++++++++++++++++++
>   1 file changed, 31 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
> index a394a15..5d13ccc 100644
> --- a/drivers/gpu/drm/panel/panel-edp.c
> +++ b/drivers/gpu/drm/panel/panel-edp.c
> @@ -1605,6 +1605,34 @@ static const struct panel_desc sharp_lq123p1jx31 = {
>   	},
>   };
>   
> +static const struct drm_display_mode sharp_lq140m1jw46_mode = {
> +	.clock = 144370,
> +	.hdisplay = 1920,
> +	.hsync_start = 1920 + 48,
> +	.hsync_end = 1920 + 48 + 32,
> +	.htotal = 1920 + 48 + 32 + 80,
> +	.vdisplay = 1080,
> +	.vsync_start = 1080 + 3,
> +	.vsync_end = 1080 + 3 + 5,
> +	.vtotal = 1080 + 3 + 5 + 69,
> +	.flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
> +};
> +
> +static const struct panel_desc sharp_lq140m1jw46 = {
> +	.modes = &sharp_lq140m1jw46_mode,
> +	.num_modes = 1,
> +	.bpc = 8,
> +	.size = {
> +		.width = 309,
> +		.height = 174,
> +	},
> +	.delay = {
> +		.hpd_absent = 80,
> +		.enable = 50,
> +		.unprepare = 500,
> +	},
> +};
> +
>   static const struct drm_display_mode starry_kr122ea0sra_mode = {
>   	.clock = 147000,
>   	.hdisplay = 1920,
> @@ -1719,6 +1747,9 @@ static const struct of_device_id platform_of_match[] = {
>   		.compatible = "sharp,lq123p1jx31",
>   		.data = &sharp_lq123p1jx31,
>   	}, {
> +		.compatible = "sharp,lq140m1jw46",
> +		.data = &sharp_lq140m1jw46,
> +	}, {
>   		.compatible = "starry,kr122ea0sra",
>   		.data = &starry_kr122ea0sra,
>   	}, {


-- 
With best wishes
Dmitry