[PATCH] ARM: dts: Explicitly set dr_mode on exynos5250-snow

[PATCH] ARM: dts: Explicitly set dr_mode on exynos5250-snow

[Sjoerd Simons]

Explicitly set the dr_mode for the dwc3 controller on the
Snow board to host mode. This is required to ensure the
controller is initialized in the right mode if the kernel is
build with USB gadget support.

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
---
 arch/arm/boot/dts/exynos5250-snow.dts | 4 ++++
 arch/arm/boot/dts/exynos5250.dtsi     | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
index e51fcef..60429ad 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -624,4 +624,8 @@
 	num-cs = <1>;
 };
 
+&usbdrd_dwc3 {
+	dr_mode = "host";
+};
+
 #include "cros-ec-keyboard.dtsi"
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index f21b9aa..d55c1a2 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -555,7 +555,7 @@
 		#size-cells = <1>;
 		ranges;
 
-		dwc3 {
+		usbdrd_dwc3: dwc3 {
 			compatible = "synopsys,dwc3";
 			reg = <0x12000000 0x10000>;
 			interrupts = <0 72 0>;
-- 
2.1.3

Re: [PATCH] ARM: dts: Explicitly set dr_mode on exynos5250-snow

[Javier Martinez Canillas]

Hello Sjoerd,

On Fri, Nov 14, 2014 at 8:46 PM, Sjoerd Simons
<sjoerd.simons@collabora.co.uk> wrote:
> Explicitly set the dr_mode for the dwc3 controller on the
> Snow board to host mode. This is required to ensure the
> controller is initialized in the right mode if the kernel is
> build with USB gadget support.

The patch looks good to me.

Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>

Kukjin,

I think $subject is -rc material since this issue is seen after commit
508423b ("ARM: exynos_defconfig: enable USB gadget support") which
landed in 3.18.

Best regards,
Javier

RE: [PATCH] ARM: dts: Explicitly set dr_mode on exynos5250-snow

[Kukjin Kim]

Javier Martinez Canillas wrote:
> 
> Hello Sjoerd,
> 
Hi,

> On Fri, Nov 14, 2014 at 8:46 PM, Sjoerd Simons
> <sjoerd.simons@collabora.co.uk> wrote:
> > Explicitly set the dr_mode for the dwc3 controller on the
> > Snow board to host mode. This is required to ensure the
> > controller is initialized in the right mode if the kernel is
> > build with USB gadget support.
> 
> The patch looks good to me.
> 
> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> 
> Kukjin,
> 
> I think $subject is -rc material since this issue is seen after commit
> 508423b ("ARM: exynos_defconfig: enable USB gadget support") which
> landed in 3.18.
> 
Yeah, you're right. I'll queue this into -fixes for 3.18.

Thanks,
Kukjin