devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jason-JH Lin (林睿祥)" <Jason-JH.Lin@mediatek.com>
To: "jassisinghbrar@gmail.com" <jassisinghbrar@gmail.com>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"krzysztof.kozlowski@linaro.org" <krzysztof.kozlowski@linaro.org>,
	"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org"
	<krzysztof.kozlowski+dt@linaro.org>,
	"angelogioacchino.delregno@collabora.com"
	<angelogioacchino.delregno@collabora.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Singo Chang (張興國)" <Singo.Chang@mediatek.com>,
	"Johnson Wang (王聖鑫)" <Johnson.Wang@mediatek.com>,
	"Jason-ch Chen (陳建豪)" <Jason-ch.Chen@mediatek.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"Shawn Sung (宋孝謙)" <Shawn.Sung@mediatek.com>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"Nancy Lin (林欣螢)" <Nancy.Lin@mediatek.com>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"Elvis Wang (王军)" <Elvis.Wang@mediatek.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH 07/15] mailbox: mediatek: Add loop pkt flag and irq handling for loop command
Date: Mon, 25 Sep 2023 05:21:48 +0000	[thread overview]
Message-ID: <00f0bae9940be7b397c587c651e23c6c1e19a174.camel@mediatek.com> (raw)
In-Reply-To: <5d528036-e506-7b95-69bb-7748b26d2aa8@linaro.org>

Hi Krzysztof,

Thanks for the reviews.

On Sat, 2023-09-23 at 20:03 +0200, Krzysztof Kozlowski wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On 18/09/2023 21:21, Jason-JH.Lin wrote:
> > CMDQ client can use a loop flag for the CMDQ packet to make current
> > command buffer jumps to the beginning when GCE executes to the end
> > of commands buffer.
> > 
> > GCE irq occurs when GCE executes to the end of command instruction.
> > If the CMDQ packet is a loopping command, GCE irq handler can not
> > delete the CMDQ task and disable the GCE thread.
> > 
> > Add cmdq_mbox_stop to support thread disable
> 
> How or where do you add it? I do not see it in this patch. Your
> patchset
> looks randomly organized.

This will be used in cmdq_pkt_finialize_loop() at [PATCH 8/15].

mtk-cmdq-helper.c and mtk-cmdq-mailbox.c are not in the
same maintainer's tree, so I separate this to another patch from [PATCH
8/15].

Regards,
Jason-JH.Lin

> 
> Best regards,
> Krzysztof
> 
> 

  reply	other threads:[~2023-09-25  5:22 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-18 19:21 [PATCH 00/15] Add CMDQ secure driver for SVP Jason-JH.Lin
2023-09-18 19:21 ` [PATCH 01/15] dt-bindings: mailbox: Add property for CMDQ secure driver Jason-JH.Lin
2023-09-19 16:46   ` Rob Herring
2023-09-21 15:12     ` Jason-JH Lin (林睿祥)
2023-09-18 19:21 ` [PATCH 02/15] dt-bindings: gce: mt8195: Add CMDQ_SYNC_TOKEN_SECURE_THR_EOF event id Jason-JH.Lin
2023-09-23 18:01   ` Krzysztof Kozlowski
2023-09-25  5:05     ` Jason-JH Lin (林睿祥)
2023-09-25  6:42       ` Krzysztof Kozlowski
2023-09-25  9:11         ` Jason-JH Lin (林睿祥)
2023-09-25  9:28           ` Krzysztof Kozlowski
2023-09-26  2:45             ` Jason-JH Lin (林睿祥)
2023-09-18 19:21 ` [PATCH 03/15] soc: mailbox: Add SPR definition for GCE Jason-JH.Lin
2023-09-23 18:02   ` Krzysztof Kozlowski
2023-09-25  5:08     ` Jason-JH Lin (林睿祥)
2023-09-25  6:42       ` Krzysztof Kozlowski
2023-09-25 10:24         ` Jason-JH Lin (林睿祥)
2023-09-18 19:21 ` [PATCH 04/15] soc: mailbox: Add cmdq_pkt_logic_command to support math operation Jason-JH.Lin
2023-09-18 19:21 ` [PATCH 05/15] mailbox: mediatek: Add cmdq_pkt_write_s_reg_value to CMDQ driver Jason-JH.Lin
2023-09-18 19:21 ` [PATCH 06/15] mailbox: mediatek: Add cmdq_mbox_stop to disable GCE thread Jason-JH.Lin
2023-09-19  1:24   ` CK Hu (胡俊光)
2023-09-21 14:15     ` Jason-JH Lin (林睿祥)
2023-09-23 18:02   ` Krzysztof Kozlowski
2023-09-25  5:10     ` Jason-JH Lin (林睿祥)
2023-09-23 18:07   ` Krzysztof Kozlowski
2023-09-25  5:25     ` Jason-JH Lin (林睿祥)
2023-09-18 19:21 ` [PATCH 07/15] mailbox: mediatek: Add loop pkt flag and irq handling for loop command Jason-JH.Lin
2023-09-23 18:03   ` Krzysztof Kozlowski
2023-09-25  5:21     ` Jason-JH Lin (林睿祥) [this message]
2023-09-25  6:44       ` Krzysztof Kozlowski
2023-09-26  3:20         ` Jason-JH Lin (林睿祥)
2023-09-26 20:32           ` Krzysztof Kozlowski
2023-09-18 19:21 ` [PATCH 08/15] soc: mediatek: Add cmdq_pkt_finalize_loop to CMDQ driver Jason-JH.Lin
2023-09-19  1:38   ` CK Hu (胡俊光)
2023-09-21 14:25     ` Jason-JH Lin (林睿祥)
2023-09-23 18:04   ` Krzysztof Kozlowski
2023-09-23 18:08   ` Krzysztof Kozlowski
2023-09-25  6:04     ` Jason-JH Lin (林睿祥)
2023-09-25  6:40       ` Krzysztof Kozlowski
2023-09-18 19:21 ` [PATCH 09/15] mailbox: mediatek: Add secure CMDQ driver support for " Jason-JH.Lin
2023-09-18 19:21 ` [PATCH 10/15] mailbox: mediatek: Add CMDQ secure mailbox driver Jason-JH.Lin
2023-09-18 19:22 ` [PATCH 11/15] soc: mediatek: Add cmdq_insert_backup_cookie before EOC for secure pkt Jason-JH.Lin
2023-09-19  3:04   ` CK Hu (胡俊光)
2023-09-21 14:28     ` Jason-JH Lin (林睿祥)
2023-09-18 19:22 ` [PATCH 12/15] mailbox: mediatek: Add CMDQ driver support for mt8188 Jason-JH.Lin
2023-09-18 19:22 ` [PATCH 13/15] mailbox: mediatek: Add mt8188 support for CMDQ secure driver Jason-JH.Lin
2023-09-23 18:09   ` Krzysztof Kozlowski
2023-09-25  6:01     ` Jason-JH Lin (林睿祥)
2023-09-25  6:45       ` Krzysztof Kozlowski
2023-09-25  9:02         ` Jason-JH Lin (林睿祥)
2023-09-18 19:22 ` [PATCH 14/15] mailbox: mediatek: Add mt8195 " Jason-JH.Lin
2023-09-23 18:08   ` Krzysztof Kozlowski
2023-09-25  5:48     ` Jason-JH Lin (林睿祥)
2023-09-18 19:22 ` [PATCH 15/15] arm64: dts: mediatek: mt8195: Add CMDQ secure driver support for gce0 Jason-JH.Lin
2023-09-20  3:08 ` [PATCH 00/15] Add CMDQ secure driver for SVP CK Hu (胡俊光)
2023-09-21 14:44   ` Jason-JH Lin (林睿祥)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00f0bae9940be7b397c587c651e23c6c1e19a174.camel@mediatek.com \
    --to=jason-jh.lin@mediatek.com \
    --cc=Elvis.Wang@mediatek.com \
    --cc=Jason-ch.Chen@mediatek.com \
    --cc=Johnson.Wang@mediatek.com \
    --cc=Nancy.Lin@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=Shawn.Sung@mediatek.com \
    --cc=Singo.Chang@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=chunkuang.hu@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jassisinghbrar@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).