From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Aahil Awatramani <aahila@google.com>,
David Dillow <dillow@google.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Andi Shyti <andi.shyti@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: i2c: designware: allow fine tuning tuning waveform from device tree
Date: Thu, 1 Feb 2024 08:33:48 +0100 [thread overview]
Message-ID: <00f8ae5d-5556-4ef6-9bb9-d1cdac5bea9e@linaro.org> (raw)
In-Reply-To: <20240201044623.374389-1-aahila@google.com>
On 01/02/2024 05:46, Aahil Awatramani wrote:
> The Synopsys i2c driver allows a user to override the parameters
Driver? That already suggests it is not suitable for binding...
> controlling the waveform using ACPI; this is useful for fine tuning when
> needed to make spec compliance. Extend this support to the device tree to
> allow non-ACPI platforms the same capabilities.
>
> Signed-off-by: Aahil Awatramani <aahila@google.com>
> ---
> Documentation/devicetree/bindings/i2c/i2c.txt | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c.txt b/Documentation/devicetree/bindings/i2c/i2c.txt
> index fc3dd7ec0445..3c33c36571f9 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c.txt
> @@ -45,6 +45,24 @@ wants to support one of the below features, it should adapt these bindings.
> Number of nanoseconds the SCL signal takes to rise; t(r) in the I2C
> specification.
>
> +- i2c-scl-ss-hcnt
> + HCNT value for standard speed mode in I2C Controller.
I have no clue what is HCNT, so I expect you to help us understand what
is this and why this is suitable for DT. Your reference to driver
suggests it is not suitable for DT.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-02-01 7:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 4:46 [PATCH 1/2] dt-bindings: i2c: designware: allow fine tuning tuning waveform from device tree Aahil Awatramani
2024-02-01 4:46 ` [PATCH 2/2] " Aahil Awatramani
2024-02-01 7:34 ` Krzysztof Kozlowski
2024-02-01 7:33 ` Krzysztof Kozlowski [this message]
2024-02-01 11:46 ` [PATCH 1/2] dt-bindings: " Andy Shevchenko
2024-02-09 21:05 ` Aahil Awatramani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00f8ae5d-5556-4ef6-9bb9-d1cdac5bea9e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=aahila@google.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dillow@google.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).