From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 706A8C77B7C for ; Fri, 5 May 2023 07:23:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231138AbjEEHXZ (ORCPT ); Fri, 5 May 2023 03:23:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230398AbjEEHXY (ORCPT ); Fri, 5 May 2023 03:23:24 -0400 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B26661208B for ; Fri, 5 May 2023 00:23:22 -0700 (PDT) Received: by mail-pg1-x530.google.com with SMTP id 41be03b00d2f7-517bdc9e81dso695118a12.1 for ; Fri, 05 May 2023 00:23:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683271402; x=1685863402; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=A2yKNPJcgXuBTQDFXv4jaSslsM07zOnVYJZxig2x9i4=; b=dtQzQov+0p/RzYncCKQaVUMWU4t0WRUjybRHMJNDo1UG/1cPQe3Y8DxjAEjSl3fd57 q74DqkaAW1ScT6BEoKbWfoebFZz2nOIX9fcHj9Ro+igFh82W5lwL97XV7LrqqoIchuwp d3Ijwz4zwgFkHpk6SIX8fQksa00DUyL2dUKAyhEYroI3jtJgMF8jOFQ8dpw6NR1Fx7q3 76WWls16JOCb9I5L2qvkCxW8T7wlfBLsgPsa3Vhz/l3Ndxd+RrveS92skLlZEWnlS4xC IbOyilaUksuYX8xbjDxIGgOvSxnYYES4ip3NjuldvcinXYo3+nMcs8X+AuZN6ctnaqQ9 pi0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683271402; x=1685863402; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A2yKNPJcgXuBTQDFXv4jaSslsM07zOnVYJZxig2x9i4=; b=h7HZKEvcHEeIdW/kDPE6ge61k8UeXiowHwSeV5kddnzcio/vNeB8RD+gNpD5VMBOHK tii9cZFlJXyAfoT8RAg6IZxYRY9gUfi07qNCq6jPfGOZ+9VssLJxKLMPh4QsuUX92LAR XvhSxigNQbZzyqbp5MeL8OrZ4CfgLPMcHZ+xL20Ve+OYOhnwEmCoAb30QvIVaOpoOU5x 4Bn5sQVS6Ey2z/12s7AYN4nqIZI81YXGex/r7FXCY7g4qI13TLfWmK9Of/PXMd0O5ne9 q4fUtOeEJ77zOAjH6YSlnM6tZkI/ZBkAGLHM+Didi4Dpw+BmDKYgwVe4K/HBKgI0Ohvj OFkQ== X-Gm-Message-State: AC+VfDxLn6Nwbq+4iNhEWOGLIxDgBOd0jIC9mIzTZcnVhxewFa1URjdm 3ATCZqBP728zM0i7TVtRSlktMA== X-Google-Smtp-Source: ACHHUZ6ltTmBcEmc6ra7RXQIFPm3nD026L5Oiar11un/XedEAE/88qZiBIBzWQk2h06gO9CvWul6ig== X-Received: by 2002:a17:902:ba86:b0:1a6:bd5c:649d with SMTP id k6-20020a170902ba8600b001a6bd5c649dmr539297pls.56.1683271402127; Fri, 05 May 2023 00:23:22 -0700 (PDT) Received: from [192.168.1.8] ([223.233.65.180]) by smtp.gmail.com with ESMTPSA id v4-20020a1709029a0400b001aafe56ea70sm959277plp.5.2023.05.05.00.23.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 May 2023 00:23:21 -0700 (PDT) Message-ID: <00fbdc3d-901d-e3f7-9128-ddf070242217@linaro.org> Date: Fri, 5 May 2023 12:53:15 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v10 1/4] dt-bindings: phy: qcom,qmp-usb: Drop legacy bindings and move to newer one (SM6115 & QCM2290) From: Bhupesh Sharma To: Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-phy@lists.infradead.org, agross@kernel.org, linux-kernel@vger.kernel.org, andersson@kernel.org, bhupesh.linux@gmail.com, robh+dt@kernel.org, konrad.dybcio@linaro.org, kishon@kernel.org, vkoul@kernel.org, krzysztof.kozlowski+dt@linaro.org, dmitry.baryshkov@linaro.org References: <20230502053534.1240553-1-bhupesh.sharma@linaro.org> <20230502053534.1240553-2-bhupesh.sharma@linaro.org> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Krzysztof, On 5/4/23 10:42 PM, Bhupesh Sharma wrote: > On Wed, 3 May 2023 at 21:55, Krzysztof Kozlowski > wrote: >> >> On 02/05/2023 07:35, Bhupesh Sharma wrote: >>> 'qcom,msm8996-qmp-usb3-phy.yaml' defines bindings for several PHYs >>> which predate USB -> USB+DP migration. Since SM6115 and QCM2290 >>> nodes for USB QMP phy are being added to dtsi files by followup patches, >>> move these bindings instead to the newer style >>> 'qcom,sc8280xp-qmp-usb3-uni-phy.yaml' file. >>> >> >> >>> clock-names: >>> - items: >>> - - const: aux >>> - - const: ref >>> - - const: com_aux >>> - - const: pipe >>> + maxItems: 4 >>> >>> power-domains: >>> maxItems: 1 >>> @@ -71,6 +69,42 @@ required: >>> >>> additionalProperties: false >>> >>> +allOf: >>> + - if: >>> + properties: >>> + compatible: >>> + contains: >>> + enum: >>> + - qcom,qcm2290-qmp-usb3-phy >>> + - qcom,sm6115-qmp-usb3-phy >>> + then: >>> + properties: >>> + clocks: >>> + maxItems: 4 >>> + clock-names: >>> + items: >>> + - const: cfg_ahb >>> + - const: ref >>> + - const: com_aux >>> + - const: pipe >> >> I am pretty sure I acked it and there were no changes here... but since >> you did not include it, then lets keep the clock order the same as >> sc8280xp. ABI is anyway affected, right? > > Yes, I forgot to include your Ack in this version :( > Ok, I will fix the clock order in v11. I just noticed that the clock orders are actually the same as sc8280xp. The only clock diff between sm6115 and sc8280xp is actually 'cfg_ahb' clock used by sm6115 instead of 'aux' used by sc8280xp. So, the clock order for sc8280xp is: + - const: aux + - const: ref + - const: com_aux + - const: pipe whereas the same for sm6115 is: + - const: cfg_ahb + - const: ref + - const: com_aux + - const: pipe Or, am I missing something? If not, may be I can include your Ack to help get this applied :) Thanks, Bhupesh