public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: <ansuelsmth@gmail.com>
To: "'Vinod Koul'" <vkoul@kernel.org>
Cc: "'Andy Gross'" <agross@codeaurora.org>,
	"'Jonathan McDowell'" <noodles@earth.li>,
	"'Andy Gross'" <agross@kernel.org>,
	"'Bjorn Andersson'" <bjorn.andersson@linaro.org>,
	"'Kishon Vijay Abraham I'" <kishon@ti.com>,
	"'Rob Herring'" <robh+dt@kernel.org>,
	"'Mark Rutland'" <mark.rutland@arm.com>,
	<linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<devicetree@vger.kernel.org>
Subject: R: [PATCH v10 1/2] phy: qualcomm: add qcom ipq806x dwc usb phy driver
Date: Mon, 20 Jul 2020 14:25:18 +0200	[thread overview]
Message-ID: <010801d65e90$d57d2b60$80778220$@gmail.com> (raw)
In-Reply-To: <20200720062545.GC12965@vkoul-mobl>



> -----Messaggio originale-----
> Da: Vinod Koul <vkoul@kernel.org>
> Inviato: lunedì 20 luglio 2020 08:26
> A: Ansuel Smith <ansuelsmth@gmail.com>
> Cc: Andy Gross <agross@codeaurora.org>; Jonathan McDowell
> <noodles@earth.li>; Andy Gross <agross@kernel.org>; Bjorn Andersson
> <bjorn.andersson@linaro.org>; Kishon Vijay Abraham I <kishon@ti.com>;
> Rob Herring <robh+dt@kernel.org>; Mark Rutland
> <mark.rutland@arm.com>; linux-arm-msm@vger.kernel.org; linux-
> kernel@vger.kernel.org; devicetree@vger.kernel.org
> Oggetto: Re: [PATCH v10 1/2] phy: qualcomm: add qcom ipq806x dwc usb
> phy driver
> 
> On 17-07-20, 15:16, Ansuel Smith wrote:
> > This has lost in the original push for the dwc3 qcom driver.
> > This is needed for ipq806x SoC as without this the usb ports
> > doesn't work at all.
> 
> Applied both, thanks
> 
> My script found below errors with W=1, can you please send fixes for
> these
> 

Since you applied them should I send a new patch or a v11 of 
this patchset?

> drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:140: warning: Function
> parameter or member 'phy_dwc3' not described in
> 'usb_phy_write_readback'
> drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:140: warning: Function
> parameter or member 'offset' not described in 'usb_phy_write_readback'
> drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:140: warning: Function
> parameter or member 'mask' not described in 'usb_phy_write_readback'
> drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:140: warning: Function
> parameter or member 'val' not described in 'usb_phy_write_readback'
> drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:182: warning: Function
> parameter or member 'phy_dwc3' not described in 'usb_ss_write_phycreg'
> drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:182: warning: Function
> parameter or member 'addr' not described in 'usb_ss_write_phycreg'
> drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:182: warning: Function
> parameter or member 'val' not described in 'usb_ss_write_phycreg'
> drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:219: warning: Function
> parameter or member 'phy_dwc3' not described in 'usb_ss_read_phycreg'
> drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:219: warning: Function
> parameter or member 'addr' not described in 'usb_ss_read_phycreg'
> drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:219: warning: Function
> parameter or member 'val' not described in 'usb_ss_read_phycreg'
> 
> --
> ~Vinod


  reply	other threads:[~2020-07-20 12:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-17 13:16 [PATCH v10 1/2] phy: qualcomm: add qcom ipq806x dwc usb phy driver Ansuel Smith
2020-07-17 13:16 ` [PATCH v10 2/2] devicetree: bindings: phy: Document ipq806x dwc3 qcom phy Ansuel Smith
2020-07-20  6:25 ` [PATCH v10 1/2] phy: qualcomm: add qcom ipq806x dwc usb phy driver Vinod Koul
2020-07-20 12:25   ` ansuelsmth [this message]
2020-07-20 12:41     ` R: " Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='010801d65e90$d57d2b60$80778220$@gmail.com' \
    --to=ansuelsmth@gmail.com \
    --cc=agross@codeaurora.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kishon@ti.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=noodles@earth.li \
    --cc=robh+dt@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox