From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] arm64: dts: qcom: sm8150: use 'gpios' suffix for PCI GPIOs
Date: Tue, 14 Nov 2023 16:30:08 +0100 [thread overview]
Message-ID: <0109c9c9-3556-4b65-83b6-7d8b37b775a0@linaro.org> (raw)
In-Reply-To: <81c4d6c3-1fce-4bb2-ad07-89f1482dd686@linaro.org>
On 13/11/2023 13:00, Konrad Dybcio wrote:
> On 11.11.2023 17:42, Krzysztof Kozlowski wrote:
>> Linux handles both versions, but bindings expect GPIO properties to
>> have 'gpios' suffix instead of 'gpio':
>>
>> sa8155p-adp.dtb: pci@1c00000: Unevaluated properties are not allowed ('perst-gpio' was unexpected)
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
> What about the 'enable-gpio' right below it?
It needs to be documented first. enable-gpio/s seems to be missing from
the bindings and I did not have enough of time to investigate whether
this is correct in the first place.
That's why I thought about fixing only already accepted perst-gpios.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-14 15:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-11 16:42 [PATCH 1/6] arm64: dts: qcom: sc8180x-flex-5g: use 'gpios' suffix for PCI GPIOs Krzysztof Kozlowski
2023-11-11 16:42 ` [PATCH 2/6] arm64: dts: qcom: sc8180x-primus: " Krzysztof Kozlowski
2023-11-13 11:59 ` Konrad Dybcio
2023-11-11 16:42 ` [PATCH 3/6] arm64: dts: qcom: sm8150: " Krzysztof Kozlowski
2023-11-13 12:00 ` Konrad Dybcio
2023-11-14 15:30 ` Krzysztof Kozlowski [this message]
2023-11-11 16:42 ` [PATCH 4/6] arm64: dts: qcom: sm6115: align mem timer size cells with bindings Krzysztof Kozlowski
2023-11-22 17:18 ` Konrad Dybcio
2023-11-11 16:42 ` [RFT PATCH 5/6] arm64: dts: qcom: sm6125: add interrupts to DWC3 USB controller Krzysztof Kozlowski
2023-11-21 21:26 ` Marijn Suijten
2023-11-11 16:42 ` [RFT PATCH 6/6] arm64: dts: qcom: sm6375-pdx225: add fixed touchscreen AVDD regulator Krzysztof Kozlowski
2023-11-13 11:59 ` [PATCH 1/6] arm64: dts: qcom: sc8180x-flex-5g: use 'gpios' suffix for PCI GPIOs Konrad Dybcio
2023-12-08 2:57 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0109c9c9-3556-4b65-83b6-7d8b37b775a0@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).