Re: [PATCH v6 4/5] media: platform: mediatek: isp_30: add mediatek ISP3.0 camsv

["CK Hu (胡俊光)" <ck.hu@mediatek.com>]

Hi, Julien:

On Mon, 2024-07-29 at 16:48 +0200, Julien Stephan wrote:
>  	 
> External email : Please do not click links or open attachments until you have verified the sender or the content.
>  From: Phi-bang Nguyen <pnguyen@baylibre.com>
> 
> This driver provides a path to bypass the SoC ISP so that image data
> coming from the SENINF can go directly into memory without any image
> processing. This allows the use of an external ISP.
> 
> Signed-off-by: Phi-bang Nguyen <pnguyen@baylibre.com>
> Signed-off-by: Florian Sylvestre <fsylvestre@baylibre.com>
> [Paul Elder fix irq locking]
> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
> Co-developed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Co-developed-by: Julien Stephan <jstephan@baylibre.com>
> Signed-off-by: Julien Stephan <jstephan@baylibre.com>
> ---

[snip]

> +
> +static void fmt_to_sparams(u32 mbus_fmt, struct mtk_cam_sparams *sparams)
> +{
> +switch (mbus_fmt) {
> +/*
> + * SBGGR values coming from isp5.0 configuration.
> + * not tested on isp2.0

I don't know what does this comment mean.
Remove the code that you does not test and you could remove this comment.

Regards,
CK

> + */
> +case MEDIA_BUS_FMT_SBGGR12_1X12:
> +case MEDIA_BUS_FMT_SGBRG12_1X12:
> +case MEDIA_BUS_FMT_SGRBG12_1X12:
> +case MEDIA_BUS_FMT_SRGGB12_1X12:
> +sparams->w_factor = 1;
> +sparams->module_en_pak = 0x4;
> +sparams->fmt_sel = 0x2;
> +sparams->pak = 0x5;
> +sparams->imgo_stride = 0x000B0000;
> +break;
> +case MEDIA_BUS_FMT_SBGGR10_1X10:
> +case MEDIA_BUS_FMT_SGBRG10_1X10:
> +case MEDIA_BUS_FMT_SGRBG10_1X10:
> +case MEDIA_BUS_FMT_SRGGB10_1X10:
> +sparams->w_factor = 1;
> +sparams->module_en_pak = 0x4;
> +sparams->fmt_sel = 0x1;
> +sparams->pak = 0x6;
> +sparams->imgo_stride = 0x000B0000;
> +break;
> +case MEDIA_BUS_FMT_SBGGR8_1X8:
> +case MEDIA_BUS_FMT_SGBRG8_1X8:
> +case MEDIA_BUS_FMT_SGRBG8_1X8:
> +case MEDIA_BUS_FMT_SRGGB8_1X8:
> +sparams->w_factor = 1;
> +sparams->module_en_pak = 0x4;
> +sparams->fmt_sel = 0x0;
> +sparams->pak = 0x7;
> +sparams->imgo_stride = 0x000B0000;
> +break;
> +case MEDIA_BUS_FMT_UYVY8_1X16:
> +case MEDIA_BUS_FMT_VYUY8_1X16:
> +case MEDIA_BUS_FMT_YUYV8_1X16:
> +case MEDIA_BUS_FMT_YVYU8_1X16:
> +sparams->w_factor = 2;
> +sparams->module_en_pak = 0x8;
> +sparams->fmt_sel = 0x1000003;
> +sparams->pak = 0x0;
> +sparams->imgo_stride = 0x00090000;
> +break;
> +default:
> +break;
> +}
> +}
> +