Re: [PATCH v6 1/3] dt-bindings: i3c: Add support for Qualcomm I3C controller

Krzysztof Kozlowski
2025-07-01T08:58:10Z

On 01/07/2025 09:18, Mukesh Kumar Savaliya wrote:
> Add device tree bindings for the Qualcomm I3C controller. This includes
> the necessary documentation and properties required to describe the
> hardware in the device tree.

Last sentence is completely redundant. How would you add bindings
without necessary documentation? Does it make any sense to add bindings
without neccesary documentation and properties? No, it does not. Say
something useful or keep it simple. And I reject patches created to meet
KPIs/goals like amount of lines of patches (second pattern: other patch
was for IPQ5424 where I asked to shorten and qualcomm kept it two lines...).

> +maintainers:
> + - Mukesh Kumar Savaliya <mukesh.savaliya@oss.qualcomm.com>
> +
> +description:
> + I3C in master mode supports up to 12.5MHz, SDR mode data transfer in mixed
> + bus mode (I2C and I3C target devices on same i3c bus). It also supports
> + hotjoin, IBI mechanism.
> +
> + I3C Controller nodes must be child of GENI based Qualcomm Universal
> + Peripharal. Please refer GENI based QUP wrapper controller node bindings
> + described in Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml.
Your cover letter - or this changelog - should explain what is your plan
in updating that one.

Best regards,
Krzysztof