Re: [PATCH v6 1/3] dt-bindings: i3c: Add support for Qualcomm I3C controller

ALOK TIWARI
2025-07-01T08:57:19Z

On 7/1/2025 12:48 PM, Mukesh Kumar Savaliya wrote:
> Add device tree bindings for the Qualcomm I3C controller. This includes
> the necessary documentation and properties required to describe the
> hardware in the device tree.
>
> Signed-off-by: Mukesh Kumar Savaliya<mukesh.savaliya@oss.qualcomm.com>
> Reviewed-by: Rob Herring (Arm)<robh@kernel.org>
> ---
> .../bindings/i3c/qcom,geni-i3c.yaml | 59 +++++++++++++++++++
> 1 file changed, 59 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/i3c/qcom,geni-i3c.yaml
>
> diff --git a/Documentation/devicetree/bindings/i3c/qcom,geni-i3c.yaml b/Documentation/devicetree/bindings/i3c/qcom,geni-i3c.yaml
> new file mode 100644
> index 000000000000..45022327aee7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i3c/qcom,geni-i3c.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id:https://urldefense.com/v3/__http://devicetree.org/schemas/i3c/qcom,geni-
> i3c.yaml*__;Iw!!ACWV5N9M2RV99hQ!
> PBExY8d6MKcoXxa6GINMC0xaLabw8ZZ5entM7BVRBDg5TTn0wX4bOd-
> BYUvy71WMSS1Yd5r1Fo9h40H4ug1cfxGkUxWZ0lw3TKY$
> +$schema:https://urldefense.com/v3/__http://devicetree.org/meta-schemas/
> core.yaml*__;Iw!!ACWV5N9M2RV99hQ!
> PBExY8d6MKcoXxa6GINMC0xaLabw8ZZ5entM7BVRBDg5TTn0wX4bOd-
> BYUvy71WMSS1Yd5r1Fo9h40H4ug1cfxGkUxWZDFlVARk$
> +
> +title: Qualcomm Geni based QUP I3C Controller
> +
> +maintainers:
> + - Mukesh Kumar Savaliya<mukesh.savaliya@oss.qualcomm.com>
> +
> +description:
> + I3C in master mode supports up to 12.5MHz, SDR mode data transfer in mixed
> + bus mode (I2C and I3C target devices on same i3c bus). It also supports
> + hotjoin, IBI mechanism.

Hot-join
IBI (In-Band Interrupt)

> +
> + I3C Controller nodes must be child of GENI based Qualcomm Universal

"nodes must be children" ?

> + Peripharal. Please refer GENI based QUP wrapper controller node bindings
> + described in Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml.

Thanks,
Alok