[PATCH v6 0/3] Add Qualcomm i3c controller driver support

Mukesh Kumar Savaliya
2025-07-01T07:19:40Z

This patchset adds i3c controller support for the qualcomm's QUPV3 based
Serial engine (SE) hardware controller.

The I3C SE(Serial Engine) controller implements I3C master functionality
as defined in the MIPI Specifications for I3C, Version 1.0.

This patchset was tested on SM8550 MTP device and data transferhas been
tested in I3C SDR mode.

Features tested and supported :
Standard CCC commands.
I3C SDR mode private transfers in PIO mode.
I2C transfers in PIO mode.

Signed-off-by: Mukesh Kumar Savaliya <mukesh.savaliya@oss.qualcomm.com>
----
Link to V5: https://lore.kernel.org/all/20250420081530.2708238-1-quic_msavaliy@quicinc.com/

v5->v6 :
- Cleaned up with the alignment and Addressed comments from Alok.
- Kconfig change - Do not Depends on I3C. Follow same as other i3c controller drivers.
- Probe : Do not set PM to active state as controller is not initialized yet.
- Updated email domain from quicinc.com to oss.qualcomm.com.

Link to V4: https://lore.kernel.org/all/20250411113516.87958-1-quic_msavaliy@quicinc.com/
v4->v5:
- Define macros value in lower case hex.
- Removed unused macro SLV_ADDR_SHFT.
- Used FIELD_PREP to write command into M_PARAM and removed CCC_HDR_CMD_SHFT macro.
- Include units.h headerfile and use xHZ macros instead of local defined macro.
- Changed PACKING_BYTES_PW to PACKING_BYTES_PER_WORD.
- I3C_ADDR_MASK : Use I2C_ADDR_MASK instead of local define and maintain i3c purpose.
- geni_i3c_clk_map: converted array initializations for frequency mapping as per C99 standard.
- Removed bus NULL pointer check from geni_i3c_clk_map_idx() as it's not possible to NULL there.
- inline functions set_new_addr_slot(), clear_new_addr_slot() and is_new_addr_slot_set().
- geni_i3c_handle_err() : Added line space after each condition and removed %s from string print.
- geni_i3c_irq() : Used hardcoded value 4 for sizeof(u32 val).
- geni_i3c_irq() : simplified condition check and alignment with new variable fifo_read_status.
- _i3c_geni_execute_command() : Reversed if and else block for natural positive look.
- geni_i3c_perform_daa() : DCR, BCR, PID - used GENMASK and FIELD_PREP instead of manual shift.
- geni_i3c_perform_daa() : Used parity8() function to simplify and add a comment for readability.

Link to V3: https://lore.kernel.org/lkml/20250403134644.3935983-1-quic_msavaliy@quicinc.com/T/
v3->v4:
- Dropped "clock-names" property from dt-bindings as suggested by krzysztof.
- Makefile: Correct order sequence for i3c-qcom-geni.c.
- Indentation corrected around print statement.
- geni_i3c_probe() : Exit with return 0 instead of ret for success.
- Added sparse annotations around i3c_geni_runtime_get_mutex_lock()/_unlock().

Link to V2: https://patchwork.kernel.org/project/linux-arm-msm/cover/20250326141641.3471906-1-quic_msavaliy@quicinc.com/
v2 -> v3:
- Removed "master" word from compatible and dt-bindings filename.
- Changed compatible qcom,i3c-master to qcom,geni-i3c.
- Renamed qcom,i3c-master.yaml to qcom,geni-i3c.yaml matchin to compatible name.
- Removed const from compatible property from yaml.
- Changed driver file name from qcom-i3c-master.c to i3c-qcom-geni.c.
- Changed Kconfig and Makefile accordingly as per driver filename changes.
- Changed se-clk to se inside devm_clk_get(&pdev->dev, "se-clk").
- Removed "se-clock-frequency" read from DTSI and fixed frequency within driver.

Link to V1: https://lore.kernel.org/lkml/20250205143109.2955321-1-quic_msavaliy@quicinc.com/
v1-> v2 :
- Removed bindings word from subject title of dt-bindings patch.
- Use Controller name instead of Master as per MIPI alliance guidance and updated title.
- Added description field for the i3c master into dt-bindings.
- Changed title to "Qualcomm Geni based QUP I3C Controller".
- Changed compatible to "qcom,i3c-master" matching dt-binding file and driver.
- Changed "interrupts-extended" property to "interrupts" as suggested by krzysztof.
- Dropped reg, clock minItems and added maxItems similar to other dt-bindings.
- Removed clock-names property from dt-bindings suggested by Krzysztof, Bjorn.
- Set "se-clock-frequency" set it within drivers as suggested by Rob.
- Removed "dfs-index" property and manage it within driver as suggested by Rob.
- Removed "interrupts" maxItems as we need only 1 interrupt in this change.
- Added comment for mutex lock mentioning purpose in sruct geni_i3c_dev .
- Return with dev_err_probe() instead of error log and then return -ENXIO from probe().
- Removed dev_dbg(&pdev->dev, "Geni I3C probed\n") print log as suggested by krzysztof.
- Removed CONFIG_PM and else part around runtime PM operations following other drivers.
- Removed Module alias MODULE_ALIAS("platform:geni_i3c_master").
- Replaced MASTER with GENI in the Title of MAINTAINER file.
- Removed duplications from the commit log and removed unwanted statement.
- Formatted license and copyright similar to other files.
- Removed SLV_ADDR_MSK and used FIELD_PREP/FIELD_GET instead of local bit shifting operations.
- Used direct bit positions for each internal Error bit of DM_I3C_CB_ERR.
- Removed Unused SLV_ADDR_MSK and added SLAVE_ADDR_MASK as GENMASK(15,9).
- Renamed spinlock as irq_lock.
- Removed dfs_idx from geni_i3c_dev and made it local inside qcom_geni_i3c_conf().
- Use boolean cur_is_write instead of enum i3c_trans_dir/gi3c->cur_rnw.
- Used DECLARE_BITMAP and related set/clear_bit APIs instead of manual operation.
- Inline the error messages from geni_i3c_err_log directly to improve readability
and avoid unnecessary jumps caused by the geni_i3c_err_code enum.
- Converted clk_src_freq of struct geni_i3c_clk_settings to HZ.
- Removed unwanted debug logs from geni_i3c_clk_map_idx().
- clk_od_fld and itr renamed to clk_od_idx and clk_idx respectively to map actual usage.
- Added se-clock-frequency to be read from DTSI, if none, then default to 100MHz source.
- Changed Error log during bus_init() if OD and PP mode frequencies avaiable or not.
- Used FIELD_PREP and standard BIT operations inside qcom_geni_i3c_conf() instead manual shifting.
- Removed unnecessary parentheses from geni_i3c_irq().
- Moved geni_se_abort_m_cmd() implementation to a new helper function geni_i3c_abort_xfer().
- Removed unwanted reinitialization of cur_len, cur_idx, cur_rnw from _i3c_geni_execute_command().
- Removed dev_dbg logs which were meant for developmental debug purpose.
- Removed unnecessary check nxfers <= 0 from geni_i3c_master_priv_xfers().
- Replaced devm_kzalloc() by kzalloc() inside geni_i3c_master_attach_i2c_dev() to use
kfree() from counter function geni_i3c_master_detach_i2c_dev().
- Replaced devm_kzalloc() by kzalloc() inside geni_i3c_master_attach_i3c_dev() to use
kfree() from counter function geni_i3c_master_detach_i3c_dev().
- Removed geni_i3c_master_reattach_i3c_dev() function as default returns 0.
- Removed goto label from geni_i3c_master_bus_init() by reorganizing internal code.
Also used i3c_geni_runtime_get_mutex_lock()/unlock() instead of get_sync() similar to other places.
- Added indent to fallthrough for switch cases inside geni_i3c_master_supports_ccc_cmd().
- Renamed i3c_geni_rsrcs_init() to i3c_geni_resources_init().
- Changed devm_ioremap_resource() to devm_platform_ioremap_resource(), removed platform_get_resource().
- Replaced dev_err() with dev_err_probe() for core clock named se-clk.
- Removed development debug prints for votings from gi3c->se.icc_paths.
- Probe(): Changed all dev_err() to dev_error_probe() with proper log messages.
- Probe(): Moved static resource allocation immediately after gi3c object allocation.
- Probe(): Disabled PM if i3c master registration fails during probe().
- Remove(): Unregister master first and then added Disable of PM as opposite to probe().
- Removed I3C_CCC_ENTHDR support as it's not supported.
----

Mukesh Kumar Savaliya (3):
dt-bindings: i3c: Add support for Qualcomm I3C controller
i3c: master: Add Qualcomm I3C controller driver
MAINTAINERS: Add maintainer for Qualcomm's I3C controller driver

.../bindings/i3c/qcom,geni-i3c.yaml | 59 +
MAINTAINERS | 8 +
drivers/i3c/master/Kconfig | 12 +
drivers/i3c/master/Makefile | 1 +
drivers/i3c/master/i3c-qcom-geni.c | 1158 +++++++++++++++++
5 files changed, 1238 insertions(+)
create mode 100644 Documentation/devicetree/bindings/i3c/qcom,geni-i3c.yaml
create mode 100644 drivers/i3c/master/i3c-qcom-geni.c

--
2.25.1