From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Nikita Travkin <nikita@trvn.ru>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 1/3] dt-bindings: mfd: qcom,spmi-pmic: Add pm8916 vm-bms and lbc
Date: Sun, 17 Sep 2023 10:32:16 +0200 [thread overview]
Message-ID: <011074e5-cec2-1c69-7324-30d9ab653577@linaro.org> (raw)
In-Reply-To: <fac4a27d08108bd6e902ba0fa4708ec4@trvn.ru>
On 17/09/2023 10:26, Nikita Travkin wrote:
> Krzysztof Kozlowski писал(а) 17.09.2023 12:58:
>> On 16/09/2023 15:57, Nikita Travkin wrote:
>>> PM8916 (and probably some other similar pmics) have hardware blocks for
>>> battery monitoring and charging. Add patterns for respecive nodes so the
>>
>> typo: respective
>>
>
> Oops, will fix if we get to v2.
>
>>> dt for those blocks can be validated properly.
>>>
>>> Signed-off-by: Nikita Travkin <nikita@trvn.ru>
>>> ---
>>> Schemas for those devices were added in [1].
>>
>> "Dependency"
>>
>
> You are right, will try to word it better next time.
>
>>>
>>> [1] https://lore.kernel.org/r/20230915-pm8916-bms-lbc-v3-0-f30881e951a0@trvn.ru
>>> ---
>>> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 6 ++++++
>>> 1 file changed, 6 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
>>> index 9f03436b1cdc..8bcd76748faa 100644
>>> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
>>> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
>>> @@ -133,9 +133,15 @@ patternProperties:
>>> type: object
>>> $ref: /schemas/sound/qcom,pm8916-wcd-analog-codec.yaml#
>>>
>>> + "^battery@[0-9a-f]+$":
>>> + type: object
>>> + oneOf:
>>> + - $ref: /schemas/power/supply/qcom,pm8916-bms-vm.yaml#
>>
>> That's just ref, so no need for oneOf... unless you already think this
>> will grow with different schemas like the charger below?
>>
>
> Yes, I think some other PMICs have different battery/fuel-gauge
> blocks too so I'd like to have some room for expansion here.
There is always room. Which other device will have different battery
charger?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-09-17 8:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-16 13:57 [PATCH 0/3] pm8916: Add BMS and charger Nikita Travkin
2023-09-16 13:57 ` [PATCH 1/3] dt-bindings: mfd: qcom,spmi-pmic: Add pm8916 vm-bms and lbc Nikita Travkin
2023-09-16 14:18 ` Rob Herring
2023-09-17 7:58 ` Krzysztof Kozlowski
2023-09-17 8:26 ` Nikita Travkin
2023-09-17 8:32 ` Krzysztof Kozlowski [this message]
2023-09-17 8:54 ` Nikita Travkin
2023-09-17 9:13 ` Krzysztof Kozlowski
2023-09-16 13:57 ` [PATCH 2/3] arm64: dts: qcom: pm8916: Add BMS and charger Nikita Travkin
2023-09-16 13:57 ` [PATCH 3/3] arm64: dts: qcom: msm8916-longcheer-l8150: Add battery " Nikita Travkin
2023-09-20 14:50 ` Konrad Dybcio
2023-09-20 15:01 ` Nikita Travkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=011074e5-cec2-1c69-7324-30d9ab653577@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikita@trvn.ru \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).