From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: alex.ts.wang@fii-foxconn.com
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
george.kw.lee@fii-foxconn.com, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>
Subject: Re: [PATCH] dt: aspeed: clemente: move hdd_led to its own gpio-leds group
Date: Fri, 14 Nov 2025 14:27:16 +1030 [thread overview]
Message-ID: <0118d17eb884ee664a035d44ddbbec56a418e353.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20251023-leo-dts-add-shunt-resistor-v1-1-5d9980aba308@fii-foxconn.com>
On Thu, 2025-10-23 at 18:26 +0800, Alex Wang via B4 Relay wrote:
> From: Alex Wang <alex.ts.wang@fii-foxconn.com>
>
> The gpio-leds driver requires all GPIOs in a group to be available;
> if any GPIO in the group is missing the whole group will not be
> created.
>
To me its behaviour appears inconsistent. Contrast:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/leds/leds-gpio.c?h=v6.18-rc1#n176
with
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/leds/leds-gpio.c?h=v6.18-rc1#n281
The driver should probably pick one policy or the other?
> The hdd_led GPIO is only present after standby power is
> enabled, which can prevent other LEDs in the same group from being
> created and blocks properly setting 'bmc_ready_noled'.
>
> Move the 'hdd_led' node into a separate gpio-leds group so that other
> LEDs are not blocked and the 'bmc_ready_noled' flag can be set
> correctly.
How is standby power applied? What are you doing to enable the use of
hdd-leds once that occurs?
Andrew
prev parent reply other threads:[~2025-11-14 3:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 10:26 [PATCH] dt: aspeed: clemente: move hdd_led to its own gpio-leds group Alex Wang via B4 Relay
2025-11-14 3:57 ` Andrew Jeffery [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0118d17eb884ee664a035d44ddbbec56a418e353.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=alex.ts.wang@fii-foxconn.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=george.kw.lee@fii-foxconn.com \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).