From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Matt Ranostay <mranostay@ti.com>,
vigneshr@ti.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: k3-j72*: correct compatible for syscon entries
Date: Thu, 13 Oct 2022 09:05:11 -0400 [thread overview]
Message-ID: <0118faac-7d50-ddb2-2914-0610b83efe6c@linaro.org> (raw)
In-Reply-To: <20221012180052.89840-1-mranostay@ti.com>
On 12/10/2022 14:00, Matt Ranostay wrote:
> Add missing ti,j721e-system-controller to bus defines in mcu/wakeup
> domains to avoid the following similar warnings from dt-schema checks:
>
> arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: syscon@40f00000: compatible: ['syscon', 'simple-mfd'] is too short'
>
> Signed-off-by: Matt Ranostay <mranostay@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 2 +-
> arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 2 +-
> arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
> index e5be78a58682..b5c666f98ba4 100644
> --- a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
> @@ -35,7 +35,7 @@ k3_reset: reset-controller {
> };
>
> mcu_conf: syscon@40f00000 {
> - compatible = "syscon", "simple-mfd";
> + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd";
That's a different SoC, so probably you should use dedicated compatible
here.
> reg = <0x00 0x40f00000 0x00 0x20000>;
> #address-cells = <1>;
> #size-cells = <1>;
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
> index df08724bbf1c..5d9ec221fa34 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
> @@ -35,7 +35,7 @@ k3_reset: reset-controller {
> };
>
> mcu_conf: syscon@40f00000 {
> - compatible = "syscon", "simple-mfd";
> + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd";
> reg = <0x0 0x40f00000 0x0 0x20000>;
> #address-cells = <1>;
> #size-cells = <1>;
> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
> index 4d1bfabd1313..3845d162d3c6 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
> @@ -69,7 +69,7 @@ wkup_gpio_intr: interrupt-controller@42200000 {
> };
>
> mcu_conf: syscon@40f00000 {
> - compatible = "syscon", "simple-mfd";
> + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd";
Here as wekk - it's a j721s2?
> reg = <0x0 0x40f00000 0x0 0x20000>;
> #address-cells = <1>;
> #size-cells = <1>;
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-10-13 13:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 18:00 [PATCH] arm64: dts: k3-j72*: correct compatible for syscon entries Matt Ranostay
2022-10-13 13:05 ` Krzysztof Kozlowski [this message]
2022-10-17 8:09 ` Matt Ranostay
2022-10-18 22:48 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0118faac-7d50-ddb2-2914-0610b83efe6c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mranostay@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).