From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Bastian Krause <bst@pengutronix.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [PATCH 1/2] dt-bindings: reset: imx-src: add syscon and simple-mfd compatibles
Date: Mon, 16 Jan 2023 10:15:04 +0100 [thread overview]
Message-ID: <01425fed-b782-1cde-a808-eceee12bbf46@linaro.org> (raw)
In-Reply-To: <20230113-syscon-child-mfd-v1-1-0dd31b7de373@pengutronix.de>
On 13/01/2023 18:32, Bastian Krause wrote:
> This allows passing the reboot mode from the OS to the bootloader via the
> syscon-reboot-mode binding. Add a "simple-mfd" to support probing such a
> child node. The actual reboot mode node could then be defined in a
> board device-tree or fixed up by the bootloader.
>
> Suggested-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> Signed-off-by: Bastian Krause <bst@pengutronix.de>
> ---
> Documentation/devicetree/bindings/reset/fsl,imx-src.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml b/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml
> index b11ac533f914c..9ec734e14e9f5 100644
> --- a/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml
> +++ b/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml
> @@ -38,6 +38,8 @@ properties:
> - items:
> - const: "fsl,imx6q-src"
> - const: "fsl,imx51-src"
> + - const: "syscon"
> + - const: "simple-mfd"
This is not sufficient. You can easily check it by yourself - add
syscon-reboot-mode node and run dtbs_check.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-16 9:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 17:32 [PATCH 0/2] Support Child MFD Cells for the i.MX6QDL Reset Controller Bastian Krause
2023-01-13 17:32 ` [PATCH 1/2] dt-bindings: reset: imx-src: add syscon and simple-mfd compatibles Bastian Krause
2023-01-16 8:18 ` Krzysztof Kozlowski
2023-01-16 9:15 ` Krzysztof Kozlowski [this message]
2023-01-13 17:32 ` [PATCH 2/2] ARM: dts: imx6qdl: support child mfd cells for the reset controller Bastian Krause
2023-01-16 8:20 ` Krzysztof Kozlowski
2023-01-16 8:21 ` Krzysztof Kozlowski
2023-01-16 8:27 ` Ahmad Fatoum
2023-01-16 9:14 ` Krzysztof Kozlowski
2023-01-16 9:26 ` Ahmad Fatoum
2023-01-16 10:15 ` Krzysztof Kozlowski
2023-01-16 11:53 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01425fed-b782-1cde-a808-eceee12bbf46@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=a.fatoum@pengutronix.de \
--cc=bst@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).