From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kukjin Kim Subject: RE: [PATCH v6 01/16] clk: samsung: add common clock framework helper functions for Samsung platforms Date: Thu, 07 Mar 2013 10:44:30 +0900 Message-ID: <015a01ce1ad5$4f89a4e0$ee9ceea0$%kim@samsung.com> References: <1361175686-19400-1-git-send-email-thomas.abraham@linaro.org> <201303030208.49722.heiko@sntech.de> <51333149.1060105@gmail.com> <2984153.Xctncej7hL@flatron> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-reply-to: <2984153.Xctncej7hL@flatron> Content-language: ko Sender: linux-samsung-soc-owner@vger.kernel.org To: 'Tomasz Figa' , linux-arm-kernel@lists.infradead.org Cc: 'Sylwester Nawrocki' , =?ISO-8859-1?Q?'Heiko_St=FCbner'?= , linux-samsung-soc@vger.kernel.org, mturquette@linaro.org, devicetree-discuss@lists.ozlabs.org, 'Thomas Abraham' , t.figa@samsung.com List-Id: devicetree@vger.kernel.org Tomasz Figa wrote: >=20 > Hi, >=20 > On Sunday 03 of March 2013 12:17:29 Sylwester Nawrocki wrote: > > Hi, > > > > On 03/03/2013 02:08 AM, Heiko St=FCbner wrote: > > > But is there an easy way to define more than one alias? On the s3= c2416 > > > for example the hsmmc hclk is the "hsmmc" io-clock, as well as th= e > > > source for the "mmc_busclk.0". Same for the "uart" pclk, that is = also > > > a baud clock source. > > This driver currently provides for only one additional clkdev looku= p > > entry per a platform clock. I pointed out this desing issue in the > > early version of the patch set. It's because a machine clock defini= tion > > is coupled with a clock consumer definition. And IMO various > > samsung_clock_register_* functions should not have > > clk_register_clkdev() inside them. I.e. first step could be registe= ring > > all machine clocks and in the second one clkdev lookup entries coul= d be > > created. This is how most (all?) existing SoC clock drivers are > > working. > > > > But those multiple aliases are important only for machines with dev= ice > > tree support, aren't they ? >=20 > I suppose you meant _without_ device tree support, right? >=20 > > I hope this patch series gets merged early to linux-next in the 3.1= 0 > > cycle so the multiple accumulated fixup patches for this clock driv= er > > can be merged as well and issues like that you pointed out can be > > resolved with incremental patches. >=20 > Yes, I hope so too. > Yes, I will in this weekend. Note, I will modify [07/16] for universal_c210 as per Kyungmin's reques= t, I'm not sure about universal_c210 though. Thanks. - Kukjin