From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACAFBC433FE for ; Tue, 26 Apr 2022 06:31:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235756AbiDZGeX (ORCPT ); Tue, 26 Apr 2022 02:34:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245292AbiDZGeW (ORCPT ); Tue, 26 Apr 2022 02:34:22 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89EBE140AD for ; Mon, 25 Apr 2022 23:31:16 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id z19so7783224edx.9 for ; Mon, 25 Apr 2022 23:31:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=o60Xdt5/lIQwm3L1GGhGdikwdOr9Y2T0obDjUUJBvKM=; b=J5JP8COoziPIOC17a1AheYKEJ74nJMdOvTMVfjYEI62ywlbIffHES6TQyJ5BFbsjaK tY9ZyUKyb9v4HGphUo/lSTdBB3cioJKtkzd6i+n7lg4Zn1uTju1dAIwnS3f2Q+qzDS6d cB8OUjlNse0gs68Usif4169gsBrvcoKvNWM8ShCNQC9l8ns943iDaQO1cp3erX75a8q5 ME5XfexVA2CzmiLdNs8XgcRIwqWsxTAHjM98eosxAtu5ovZ/VcuaouLPy5I2Ey+//Ok9 jebbYJa9e/jOJ4HAf1lBwWUvCRN7R4R2a3BaaOlV82IOVI6z/tVhzK2TuFQyOtcY/jFQ KRGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=o60Xdt5/lIQwm3L1GGhGdikwdOr9Y2T0obDjUUJBvKM=; b=6ZNuCIhuYuskibr/wPOi1h7csGPEYIeKpKrr+0AxMNMfhn+xB85j8FxIdaOP/Hz/Q4 V7bf/PDUypiBasDQLyzrnptFcas7LHpvxz4AJib5bV2a6Q06bFYyINi3VYUDUibdNRSs x2eTpaVSmrlikJxHLzEUHvujqmPMtgekSM09EcPlKWFlWUo5locXziKeFgeD8jkIyOM4 W9o3lsQfsNI1Goia4Q/LAJwkXUICtRcHmnWpNDIaCw+qfnzNNg+O1GONv0QUIen92luR 2G0EdrSTiXpfJsRTkrGEWCb+zLCUsoA6I+3NtWDhHcRvLQ3xRnm8bjIMWd8/IeGD1IVn u+tQ== X-Gm-Message-State: AOAM533VK3D301cGGBA3gW6ukonTzTvo/slhm/DveTlHxIlOxWWDcbhy rega9WoHdBMmid3pOMZtNXfRPA== X-Google-Smtp-Source: ABdhPJwxSeWO8cf9PYw5+0di2Y79/EaTY+pCk5EE82cxph/Dq3q5Z8dUFxTXDfTKxIZkq+xt1jrpKA== X-Received: by 2002:a50:cd8c:0:b0:41c:bb5a:1c7b with SMTP id p12-20020a50cd8c000000b0041cbb5a1c7bmr22624009edi.351.1650954675180; Mon, 25 Apr 2022 23:31:15 -0700 (PDT) Received: from [192.168.0.244] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id lb18-20020a170907785200b006efe7bb40b0sm4347749ejc.74.2022.04.25.23.31.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Apr 2022 23:31:14 -0700 (PDT) Message-ID: <0169c4ac-fdce-29b7-553a-14dc7df532d1@linaro.org> Date: Tue, 26 Apr 2022 08:31:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 1/1] dt-bindings: nvmem: mediatek: Convert mtk-efuse binding to YAML Content-Language: en-US To: "allen-kh.cheng" , Srinivas Kandagatla , Matthias Brugger , Rob Herring , Krzysztof Kozlowski Cc: Lala Lin , Project_Global_Chrome_Upstream_Group@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Chen-Yu Tsai , Ryder Lee References: <20220425084800.2021-1-allen-kh.cheng@mediatek.com> <20220425084800.2021-2-allen-kh.cheng@mediatek.com> <9d65b713e3ffdd34dcca532c4c97fa98b124bde4.camel@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <9d65b713e3ffdd34dcca532c4c97fa98b124bde4.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 26/04/2022 08:23, allen-kh.cheng wrote: >>> +properties: >>> + compatible: >>> + oneOf: >>> + - enum: >>> + - mediatek,mt8173-efuse >>> + - mediatek,efuse >> >> Still no changes... >> > > I just want to confirm again. > > "Generic compatibles should not be used standalone" > > It seems we should remove mediatek,efuse and keep "mediatek,mt8173- > efuse"in binding. have I got that right? You should comment for which chipsets this compatible is and add a deprecated:true. In such case it cannot be part of enum but separate item in this oneOf. Best regards, Krzysztof